AGENT-1113: enhance the unconfigured-ignition command to support the interactive workflow #9529
Conversation
|
@andfasano: This pull request references AGENT-1113 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
@andfasano: This pull request references AGENT-1113 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@andfasano: This pull request references AGENT-1113 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
andfasano
force-pushed
the
abi-unconfigured-interactive-ignition
branch
from
a2405d8 to
139346c
Compare
| // required by the agent-start-ui.service. | ||
| rendezvousHostContent := fmt.Sprintf("%s\nAIUI_APP_API_URL=%s", getRendezvousHostEnv("http", rendezvousIP, "", "", agentWorkflow.Workflow), rendezvousIP) | ||
| rendezvousHostFile := ignition.FileFromString(rendezvousHostEnvPath, "root", 0644, rendezvousHostContent) | ||
| config.Storage.Files = append(config.Storage.Files, rendezvousHostFile) |
There was a problem hiding this comment.
This isn't needed for MVP, but there'd be no harm in doing it unconditionally since the appliance doesn't pass an agentConfig.
There was a problem hiding this comment.
Well, it will pass it when the appliance liveiso command will support it (cc @danielerez )
Support the '--interactive' flag when invoking the 'unconfigured-igintiion' API. The flow is enabled using the 'enableInteractiveFlow' property in appliance-config.yaml For more details see: openshift/installer#9529
Support the '--interactive' flag when invoking the 'unconfigured-igintiion' API. The flow is enabled using the 'enableInteractiveFlow' property in appliance-config.yaml For more details see: openshift/installer#9529
Support the '--interactive' flag when invoking the 'unconfigured-igintiion' API. The flow is enabled using the 'enableInteractiveFlow' property in appliance-config.yaml For more details see: openshift/installer#9529
Required to allow the UnconfiguredIgnition asset to have also AgentConfig as a dependency - to retrieve the rendezvous ip. Since InfraEnv was also dependent on AgentConfig, the presence of both files caused the asset fetcher to discard the InfraEnv content from the disk, forcing an unwanted asset re-generation.
Also the rendezvous host file is now a template when the rendezvous IP is not defined (to be used by the agent TUI). The assisted UI will take care of creating the cluster/infraenv
andfasano
force-pushed
the
abi-unconfigured-interactive-ignition
branch
2 times, most recently
from
ea12072 to
4c96e3b
Compare
andfasano
force-pushed
the
abi-unconfigured-interactive-ignition
branch
from
4c96e3b to
3f73cda
Compare
andfasano
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@andfasano: This pull request references AGENT-1113 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@andfasano: This pull request references AGENT-1113 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
@andfasano: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This patch adds a new flag
--interactiveto theunconfigured-ignitioncommand to support the interactive disconnected workflow.It is possible to specify the rendezvous IP via the agent-config.yaml file.
The interactive workflow spins up the assisted-ui after the assisted-service (and it's mutually exclusive with the automatic workflow services).
Required by:
Related to: