OCPBUGS-46470: Power VS: ResourceManager also to override for Internal deploy

[miyamotoh]

Further debugging revealed ResourceManager endpoint must also be overridden for Disconnected deploy on PowerVS with CAPI. Like #9143, this PR starts setting/passing ResourceManager override to CCM.

One thing that's perhaps noteworthy is that we are adding logic of those endpoint overrides to be in platformStatus as well (as in platformSpec) in pkg/asset/manifests/infrastructure.go, which should be the way, rather than machine-controller container in machine-api-controllers pod trying to update platformStatus which RBAC blocks.

[mjturek]

/lgtm

[mjturek]

/retitle OCPBUGS-46470: Power VS: ResourceManager also to override for Internal deploy

[openshift-ci-robot]

@miyamotoh: This pull request references Jira Issue OCPBUGS-46470, which is invalid:

• expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Further debugging revealed ResourceManager endpoint must also be overridden for Disconnected deploy on PowerVS with CAPI. Like #9143, this PR starts setting/passing ResourceManager override to CCM.

One thing that's perhaps noteworthy is that we are adding logic of those endpoint overrides to be in platformStatus as well (as in platformSpec) in pkg/asset/manifests/infrastructure.go, which should be the way, rather than machine-controller container in machine-api-controllers pod trying to update platformStatus which RBAC blocks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[mjturek]

/jira-refresh

[mjturek]

/assign r4f4

[r4f4]

/test e2e-powervs-capi-ovn

[mjturek]

/jira refresh

[openshift-ci-robot]

@mjturek: This pull request references Jira Issue OCPBUGS-46470, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juliemathew

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: juliemathew.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@mjturek: This pull request references Jira Issue OCPBUGS-46470, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juliemathew

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[r4f4]

/test e2e-powervs-capi-ovn

[openshift-ci]

@miyamotoh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	511bd2f	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/e2e-powervs-capi-ovn	511bd2f	link	false	/test e2e-powervs-capi-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[mjturek]

@r4f4 there seems to be some ongoing issues with CI due to resource contention. I've deployed with these changes myself and it went without a hitch

INFO All cluster operators have completed progressing
INFO Checking to see if there is a route at openshift-console/console...
DEBUG Route found in openshift-console namespace: console
DEBUG OpenShift console route is admitted
INFO Install complete!
INFO To access the cluster as the system:admin user when using 'oc', run
INFO     export KUBECONFIG=???
INFO Access the OpenShift web-console here: ???
INFO Login to the console with user: "???", and password: "???"
DEBUG Time elapsed per stage:
DEBUG    Network-infrastructure Provisioning: 9m26s
DEBUG Post-network, pre-machine Provisioning: 16s
DEBUG                   Machine Provisioning: 6m0s
DEBUG       Infrastructure Post-provisioning: 1m22s
DEBUG                     Bootstrap Complete: 32m41s
DEBUG                                    API: 7m16s
DEBUG                      Bootstrap Destroy: 41s
DEBUG            Cluster Operators Available: 28m34s
DEBUG               Cluster Operators Stable: 50s
INFO Time elapsed: 1h20m22

[r4f4]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [r4f4]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 43fa24e and 2 for PR HEAD 511bd2f in total