[release-4.17] no-jira: Collect bootstrap logs when control plane provisioning fails #9308
+29
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a ControlPlaneCreation error that is returned on all non-baremetal platforms when control plane machines fail to provision so that we can parse the error and gather logs when appropriate.
Creates a function for gathering and analyzing bootstrap logs so that it can be reused.
Gathers and analyzes bootstrap logs on provisioning failure. This will help gather serial console & other logs during provisioning failures. Prior to this change. gathering only happened if infra provisioning succeeded but we can gather more logs to help us understand provisioning failures.
Wraps control plane provisioning errors on baremetal IPI with the ControlPlaneCreationError so that gather bootstrap will run automatically in that case.
|
/approve |
openshift-ci
bot
added
the
backport-risk-assessed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
approved
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
patrickdillon
added
jira/valid-bug
openshift-merge-bot
bot
merged commit 6e3f5e3
into
openshift:release-4.17
22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #9123
/assign patrickdillon