Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-46035: fix skew support for node-joiner #9307

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

OCPBUGS-46035: fix skew support for node-joiner #9307

wants to merge 2 commits into from

Conversation

andfasano
Copy link
Contributor

This patch allows to run the oc adm node-image commands using oc 4.17.x against a cluster 4.18

@andfasano
Copy link
Contributor Author

/assign @rwsu

@andfasano andfasano mentioned this pull request Dec 11, 2024
Open
@openshift-ci openshift-ci bot requested review from bfournie and zaneb December 11, 2024 16:02
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Dec 11, 2024
@openshift-ci-robot
Copy link
Contributor

@andfasano: This pull request references Jira Issue OCPBUGS-46035, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This patch allows to run the oc adm node-image commands using oc 4.17.x against a cluster 4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Dec 11, 2024
@andfasano
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Dec 12, 2024
@openshift-ci-robot
Copy link
Contributor

@andfasano: This pull request references Jira Issue OCPBUGS-46035, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @bmanzari

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Dec 12, 2024
@openshift-ci openshift-ci bot requested a review from bmanzari December 12, 2024 09:35
rwsu
rwsu reviewed Dec 12, 2024
View reviewed changes
Copy link
Contributor

@rwsu rwsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2024
bfournie
bfournie reviewed Dec 13, 2024
View reviewed changes
pkg/asset/agent/joiner/clusterinfo.go Show resolved Hide resolved
pkg/asset/agent/joiner/clusterinfo.go Show resolved Hide resolved
pkg/asset/agent/joiner/clusterinfo.go Show resolved Hide resolved
pkg/asset/agent/joiner/clusterinfo.go Outdated
clusterConfig, err := ci.Client.CoreV1().ConfigMaps("kube-system").Get(context.Background(), "cluster-config-v1", metav1.GetOptions{})
if err != nil {
if errors.IsNotFound(err) {
return nil, nil
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe need a unit test for this?

@andfasano
node-joiner: added support for oc 4.17.z
b4e9043 
Since machineconfigs, idms and icp permissions are not available
@andfasano
added tests
78bb608
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2024
@bfournie
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2024
@andfasano
Copy link
Contributor Author

A backport to 4.18 will be required by #9265

@andfasano
Copy link
Contributor Author

/test e2e-agent-compact-ipv4-none-platform
/test e2e-agent-compact-ipv4-appliance-diskimage

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 16, 2024

@andfasano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 78bb608 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-agent-compact-ipv4-none-platform 78bb608 link false /test e2e-agent-compact-ipv4-none-platform

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

pawanpinjarkar
pawanpinjarkar approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@pawanpinjarkar pawanpinjarkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pawanpinjarkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 43fa24e and 2 for PR HEAD 78bb608 in total

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfournie bfournie bfournie left review comments

@rwsu rwsu rwsu left review comments

@pawanpinjarkar pawanpinjarkar pawanpinjarkar approved these changes

@zaneb zaneb Awaiting requested review from zaneb

@bmanzari bmanzari Awaiting requested review from bmanzari

Assignees

@rwsu rwsu

@bfournie bfournie

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andfasano @openshift-ci-robot @bfournie @rwsu @pawanpinjarkar