Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure: avoid timeouts due to growfs #9305

Closed
wants to merge 1 commit into from

Conversation

r4f4
Copy link
Contributor

@r4f4 r4f4 commented Dec 11, 2024

Using the workaround in [1] until the issue is fixed in RHCOS.

[1] coreos/fedora-coreos-tracker#1183 (comment)

Using the workaround in [1] until the issue is fixed in RHCOS.

[1] coreos/fedora-coreos-tracker#1183 (comment)
@r4f4
Copy link
Contributor Author

r4f4 commented Dec 11, 2024

/test e2e-azure-ovn

@patrickdillon
Copy link
Contributor

@r4f4 what about adding to control plane nodes too?

@jlebon wonder if you could ptal

Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

@r4f4: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 813eb77 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jlebon
Copy link
Member

jlebon commented Dec 11, 2024

/approve

It looks fine to me. Just to be clear though, this is only required for very large disks. Not sure on how conditionalized this code path here is/needs to be based on that. (I vaguely recall that on Azure we always provision 1T disks to get the higher IOPS tier? If that's the case, then this is fine.)

Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jlebon
Once this PR has been reviewed and has the lgtm label, please ask for approval from r4f4. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@r4f4
Copy link
Contributor Author

r4f4 commented Dec 11, 2024

There is an alternative implementation with a separate /var partition at #9310

@r4f4
Copy link
Contributor Author

r4f4 commented Dec 12, 2024

/close

I'm going to close this in favor of #9310. If 9310 ends up not being the way forward, we can reopen this PR.

@openshift-ci openshift-ci bot closed this Dec 12, 2024
Copy link
Contributor

openshift-ci bot commented Dec 12, 2024

@r4f4: Closed this PR.

In response to this:

/close

I'm going to close this in favor of #9310. If 9310 ends up not being the way forward, we can reopen this PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants