-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azure: avoid timeouts due to growfs #9305
Conversation
Using the workaround in [1] until the issue is fixed in RHCOS. [1] coreos/fedora-coreos-tracker#1183 (comment)
/test e2e-azure-ovn |
@r4f4: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/approve It looks fine to me. Just to be clear though, this is only required for very large disks. Not sure on how conditionalized this code path here is/needs to be based on that. (I vaguely recall that on Azure we always provision 1T disks to get the higher IOPS tier? If that's the case, then this is fine.) |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jlebon The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There is an alternative implementation with a separate |
/close I'm going to close this in favor of #9310. If 9310 ends up not being the way forward, we can reopen this PR. |
@r4f4: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Using the workaround in [1] until the issue is fixed in RHCOS.
[1] coreos/fedora-coreos-tracker#1183 (comment)