Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-45932: IBMCloud: Add service overrides #9297

Open
wants to merge 2 commits into
base: release-4.16
Choose a base branch
from
Open

OCPBUGS-45932: IBMCloud: Add service overrides #9297

wants to merge 2 commits into from

Conversation

cjschaef
Copy link
Member

@cjschaef cjschaef commented Dec 9, 2024

Add additional IBM Cloud service override support for COS Config
and Global Catalog, for IBM Cloud Terraform plugin and any
Cluster Operators.

Related: https://issues.redhat.com/browse/OCPBUGS-45932
Related: https://issues.redhat.com/browse/OCPBUGS-34974

@cjschaef
OCPBUGS-34974: IBMCloud: Add service overrides
e4130e0 
Add additional IBM Cloud service override support for COS Config
and Global Catalog, for IBM Cloud Terraform plugin and any
Cluster Operators.

Related: https://issues.redhat.com/browse/OCPBUGS-34974
@cjschaef
IBMCloud: Bump IBM Cloud TF plugin
f8db74f 
Bump the IBM Cloud TF plugin commit to pull in required
changes for COS endpoint configuration.
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 9, 2024
@openshift-ci-robot
Copy link
Contributor

@cjschaef: This pull request references Jira Issue OCPBUGS-45932, which is invalid:

  • expected dependent Jira Issue OCPBUGS-45726 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Add additional IBM Cloud service override support for COS Config
and Global Catalog, for IBM Cloud Terraform plugin and any
Cluster Operators.

Related: https://issues.redhat.com/browse/OCPBUGS-45932
Related: https://issues.redhat.com/browse/OCPBUGS-34974

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jhixson74 and rvanderp3 December 9, 2024 22:41
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign patrickdillon for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cjschaef
Copy link
Member Author

cjschaef commented Dec 9, 2024

I think this still requires an update to openshift/api first.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 9, 2024

@cjschaef: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/altinfra-e2e-aws-ovn-single-node f8db74f link false /test altinfra-e2e-aws-ovn-single-node
ci/prow/e2e-gcp-ovn-byo-vpc f8db74f link false /test e2e-gcp-ovn-byo-vpc
ci/prow/images f8db74f link true /test images
ci/prow/e2e-aws-ovn-single-node f8db74f link false /test e2e-aws-ovn-single-node
ci/prow/altinfra-e2e-aws-ovn f8db74f link false /test altinfra-e2e-aws-ovn
ci/prow/altinfra-e2e-aws-ovn-localzones f8db74f link false /test altinfra-e2e-aws-ovn-localzones
ci/prow/e2e-aws-ovn f8db74f link true /test e2e-aws-ovn
ci/prow/e2e-aws-ovn-shared-vpc-custom-security-groups f8db74f link false /test e2e-aws-ovn-shared-vpc-custom-security-groups
ci/prow/e2e-gcp-ovn f8db74f link true /test e2e-gcp-ovn
ci/prow/terraform-images f8db74f link true /test terraform-images
ci/prow/altinfra-images f8db74f link true /test altinfra-images
ci/prow/e2e-aws-ovn-imdsv2 f8db74f link false /test e2e-aws-ovn-imdsv2
ci/prow/e2e-openstack-nfv-intel f8db74f link false /test e2e-openstack-nfv-intel
ci/prow/altinfra-e2e-aws-custom-security-groups f8db74f link false /test altinfra-e2e-aws-custom-security-groups
ci/prow/openstack-manifests f8db74f link true /test openstack-manifests
ci/prow/e2e-gcp-secureboot f8db74f link false /test e2e-gcp-secureboot
ci/prow/e2e-aws-ovn-edge-zones f8db74f link false /test e2e-aws-ovn-edge-zones
ci/prow/altinfra-e2e-aws-ovn-fips f8db74f link false /test altinfra-e2e-aws-ovn-fips
ci/prow/e2e-ibmcloud-ovn f8db74f link false /test e2e-ibmcloud-ovn
ci/prow/e2e-gcp-ovn-xpn f8db74f link false /test e2e-gcp-ovn-xpn
ci/prow/e2e-aws-ovn-shared-vpc-edge-zones f8db74f link false /test e2e-aws-ovn-shared-vpc-edge-zones
ci/prow/verify-vendor f8db74f link true /test verify-vendor
ci/prow/e2e-aws-ovn-fips f8db74f link false /test e2e-aws-ovn-fips
ci/prow/unit f8db74f link true /test unit
ci/prow/altinfra-e2e-aws-ovn-wavelengthzones f8db74f link false /test altinfra-e2e-aws-ovn-wavelengthzones
ci/prow/e2e-openstack-proxy f8db74f link false /test e2e-openstack-proxy
ci/prow/govet f8db74f link true /test govet
ci/prow/aro-unit f8db74f link true /test aro-unit
ci/prow/terraform-verify-vendor f8db74f link true /test terraform-verify-vendor
ci/prow/golint f8db74f link true /test golint
ci/prow/e2e-aws-ovn-edge-zones-manifest-validation f8db74f link true /test e2e-aws-ovn-edge-zones-manifest-validation
ci/prow/e2e-openstack-ovn f8db74f link true /test e2e-openstack-ovn
ci/prow/okd-scos-e2e-vsphere-ovn f8db74f link false /test okd-scos-e2e-vsphere-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@MayXuQQ
Copy link
Contributor

MayXuQQ commented Dec 13, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 13, 2024
@openshift-ci-robot
Copy link
Contributor

@MayXuQQ: This pull request references Jira Issue OCPBUGS-45932, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.z) matches configured target version for branch (4.16.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-45726 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-45726 targets the "4.17.0" version, which is one of the valid target versions: 4.17.0, 4.17.z
  • bug has dependents

Requesting review from QA contact:
/cc @MayXuQQ

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from MayXuQQ December 13, 2024 07:56
@MayXuQQ
Copy link
Contributor

MayXuQQ commented Dec 13, 2024

pre-merge build failed https://prow.ci.openshift.org/view/gs/test-platform-results/logs/release-openshift-origin-installer-launch-aws-modern/1867487982798245888

make: *** [Makefile:33: bin/linux_amd64/terraform-provider-ibm.zip] Error 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@rvanderp3 rvanderp3 Awaiting requested review from rvanderp3

@MayXuQQ MayXuQQ Awaiting requested review from MayXuQQ

Assignees
No one assigned
Labels
jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjschaef @openshift-ci-robot @MayXuQQ