Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGENT-1027: Dev docs for iscsi #9296

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pawanpinjarkar
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 9, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 9, 2024

@pawanpinjarkar: This pull request references AGENT-1027 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from andfasano and zaneb December 9, 2024 21:19
Copy link
Contributor

openshift-ci bot commented Dec 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from pawanpinjarkar. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Dec 9, 2024

@pawanpinjarkar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pawanpinjarkar
Copy link
Contributor Author

/cc @bfournie @rwsu

@openshift-ci openshift-ci bot requested review from bfournie and rwsu December 11, 2024 15:55
@bfournie
Copy link
Contributor

It would be useful to provide more info on why a secondary interface needs to be provided for iSCSI, i.e. because the default interface on the machine interface is reconfigured by OVN at boot so access to the root volume would be interrupted.

It would also be useful to mention that both the agent ISO and the installed RHCOS image would be accessed via iSCI.

Also why is a minimal agent ISO is required for non-OCI platforms? I believe its since both image are stored in the same location on the iSCSI target there may be a conflict depending on the size but it would be useful to clarify.

It would also be useful to outline any limitations in a mult-inode installation regarding iSCSI, as in each node must have a dedicated iSCSI target.

iSCSI (Internet Small Computer Systems Interface) is a network storage protocol that allows clients (initiators) to send SCSI commands to storage devices (targets) over IP networks. iSCSI provides a centralized and cost-effective storage management to use remote storage as if it were local disk storage.


### Supported version: OpenShift 4.18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Supported version: OpenShift 4.18
### Supported since version: OpenShift 4.18

## Key Systemd Services for iSCSI Boot

### `iscsistart.service`
- **Path**: `data/data/agent/systemd/units/iscsistart.service`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link to the real code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants