Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.15] OCPBUGS-41815: Validate MTU for custom network #9294

Open
wants to merge 2 commits into
base: release-4.15
Choose a base branch
from
Open

[release-4.15] OCPBUGS-41815: Validate MTU for custom network #9294

wants to merge 2 commits into from
+203 −31

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #9104

/assign openshift-ci-robot

mandre added 2 commits December 9, 2024 19:40
@mandre
Validate MTU for custom network
8a97503 
Set the minimum MTU to 1380 when deploying on IPv6. This value
corresponds to the minimum MTU for IPv6, which is 1280, and the
ovn-kubernetes overhead, which is 100.
@mandre
Validate MTU when controlPlanePort uses FixedIPs
a5a3021 
The minimum MTU for the IPv6 network was previously only enforced when
the controlPlanePort used the Network filter. This commit change the
validation to also work when using the Subnet filter from FixedIPs.

This commit does two things:
- populate the ControlPlanePortNetwork struct in CloudInfo even when
  using the Subnet filter and not the Network one.
- move the validation for MTU out of the branch for Network filter from
  the install-config.yaml
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 9, 2024
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-41813 with correct target version. Will retitle the PR to link to the clone.
/retitle [release-4.15] OCPBUGS-41815: Validate MTU for custom network

In response to this:

This is an automated cherry-pick of #9104

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.15] OCPBUGS-41813: Validate MTU for custom network [release-4.15] OCPBUGS-41815: Validate MTU for custom network Dec 9, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 9, 2024
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-41815, which is invalid:

  • expected dependent Jira Issue OCPBUGS-41813 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #9104

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign barbacbd for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 9, 2024

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images a5a3021 link true /test images
ci/prow/e2e-openstack-proxy a5a3021 link false /test e2e-openstack-proxy
ci/prow/okd-scos-e2e-aws-upgrade a5a3021 link false /test okd-scos-e2e-aws-upgrade
ci/prow/okd-scos-e2e-aws-ovn a5a3021 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-openstack-ovn a5a3021 link true /test e2e-openstack-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdbooth mdbooth Awaiting requested review from mdbooth

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@openshift-ci-robot openshift-ci-robot

Labels
jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@openshift-cherrypick-robot @openshift-ci-robot @mandre