Skip to content

OPRUN-3588: Add OperatorLifecycleManagerV1 capability #9196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 2 commits into from
Nov 19, 2024
Merged

OPRUN-3588: Add OperatorLifecycleManagerV1 capability #9196

openshift-merge-bot merged 2 commits into from
Nov 19, 2024

Conversation

@everettraven
Copy link
Contributor

@everettraven everettraven commented Nov 11, 2024 •
edited
Loading

Description

Updates the InstallConfig .capabilities.additionalEnabledCapabilities to add the OperatorLifecycleManagerV1 capability.

Updated openshift/api, openshift/library-go, openshift/client-go to the latest versions to pull in the new capability

Prior ART for adding CVO capability:

@everettraven
dependencies: bump api, library-go, and client-go
3569c92 
to pull in the changes that add the OperatorLifecycleManagerV1
capability to these libraries.

Signed-off-by: everettraven <[email protected]>
@everettraven
Copy link
Contributor Author

everettraven commented Nov 11, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2024
@everettraven
Copy link
Contributor Author

everettraven commented Nov 12, 2024

/retest

1 similar comment
@everettraven
Copy link
Contributor Author

everettraven commented Nov 12, 2024

/retest

tmshort
tmshort approved these changes Nov 14, 2024
View reviewed changes
Copy link

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2024
@perdasilva
Copy link

perdasilva commented Nov 18, 2024 •
edited by openshift-ci bot
Loading

Add OPRUN-3588: to the PR title =D

@everettraven everettraven changed the title Add OperatorLifecycleManagerV1 capability OPRUN-3588: Add OperatorLifecycleManagerV1 capability Nov 18, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 18, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 18, 2024 •
edited by openshift-ci bot
Loading

@everettraven: This pull request references OPRUN-3588 which is a valid jira issue.

Details

In response to this:

Description

Updates the InstallConfig .capabilities.additionalEnabledCapabilities to add the OperatorLifecycleManagerV1 capability.

Updated openshift/api, openshift/library-go, openshift/client-go to the latest versions to pull in the new capability

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@LalatenduMohanty
Copy link
Member

LalatenduMohanty commented Nov 18, 2024

@installer-team Can you please take a look. We need this PR before code branch for 4.18 happens.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 18, 2024 •
edited by openshift-ci bot
Loading

@everettraven: This pull request references OPRUN-3588 which is a valid jira issue.

Details

In response to this:

Description

Updates the InstallConfig .capabilities.additionalEnabledCapabilities to add the OperatorLifecycleManagerV1 capability.

Updated openshift/api, openshift/library-go, openshift/client-go to the latest versions to pull in the new capability

Prior ART for adding CVO capability:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@LalatenduMohanty
Copy link
Member

LalatenduMohanty commented Nov 18, 2024

openshift/cluster-version-operator#1108 is the PR to add the capability to CVO

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 18, 2024 •
edited by openshift-ci bot
Loading

@everettraven: This pull request references OPRUN-3588 which is a valid jira issue.

Details

In response to this:

Description

Updates the InstallConfig .capabilities.additionalEnabledCapabilities to add the OperatorLifecycleManagerV1 capability.

Updated openshift/api, openshift/library-go, openshift/client-go to the latest versions to pull in the new capability

Prior ART for adding CVO capability:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@patrickdillon
Copy link
Contributor

patrickdillon commented Nov 18, 2024

@everettraven the install config crd can be generated with

go generate ./pkg/types/installconfig.go

Can you squash the fix commit? It looks like this pr is just vendoring new dependencies and then generating the new crd, so if you want to squash everything into one commit that is fine too

@everettraven
capabilities: add OperatorLifecycleManagerV1 capability
2abc622 
as a new allowed enum value for the additionalEnabledCapabilities

Signed-off-by: everettraven <[email protected]>
@everettraven everettraven force-pushed the feature/olmv1-capability branch from c4c7b82 to 2abc622 Compare November 18, 2024 17:07
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2024
@everettraven
Copy link
Contributor Author

everettraven commented Nov 18, 2024

@patrickdillon I rolled the fix commit into the commit to regenerate the CRD

@grokspawn grokspawn mentioned this pull request Nov 18, 2024
Merged
5 tasks
@patrickdillon
Copy link
Contributor

patrickdillon commented Nov 18, 2024

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2024
@everettraven
Copy link
Contributor Author

everettraven commented Nov 18, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2024
@dtfranz
Copy link

dtfranz commented Nov 18, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2024
LalatenduMohanty
LalatenduMohanty approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LalatenduMohanty, patrickdillon, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2024

@everettraven: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 2abc622 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jinyunma jinyunma mentioned this pull request Nov 19, 2024
Merged
@openshift-merge-bot openshift-merge-bot bot merged commit 62d3463 into openshift:master Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@barbacbd barbacbd Awaiting requested review from barbacbd

@pawanpinjarkar pawanpinjarkar Awaiting requested review from pawanpinjarkar

2 more reviewers

@LalatenduMohanty LalatenduMohanty LalatenduMohanty approved these changes

@tmshort tmshort tmshort approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@LalatenduMohanty LalatenduMohanty

@dtfranz dtfranz

@tmshort tmshort

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@everettraven @perdasilva @openshift-ci-robot @LalatenduMohanty @patrickdillon @dtfranz @tmshort