asset/templates: remove fileName field #885
Conversation
The fileName field is not needed. The template assets do not need to store this information. This change is part of work that is on-going to add tests to ensure that targeted assets are not assessed as dirty when read back in without being modified. The problem with the fileName field is that it is not set when the asset is loaded from the state file or from on-disk. This causes road-trip tests that compare a generated asset to a read asset to fail.
openshift-ci-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: staebler The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@staebler: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Included in #890. |
2 participants
The fileName field is not needed. The template assets do not need to store this information.
This change is part of work that is on-going to add tests to ensure that targeted assets are not assessed as dirty when read back in without being modified. The problem with the fileName field is that it is not set when the asset is loaded from the state file or from on-disk. This causes road-trip tests that compare a generated asset to a read asset to fail.