assets/templates: remove common templates asset #884
Conversation
openshift-ci-robot
added
size/L
The Common Templates asset is not truly an asset. It does not own any on-disk files, and no other assets depend upon it. This change is part of work that is on-going to add tests to ensure that targeted assets are not assessed as dirty when read back in without being modified. The problem with the Common Templates asset is that it writes files to disk as a targeted asset but then does not load any assets back in. So a test that verifies that the loaded-in asset matches the written asset fails.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, staebler The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@staebler: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Included in #890. |
4 participants
The Common Templates asset is not truly an asset. It does not own any on-disk files, and no other assets depend upon it.
This change is part of work that is on-going to add tests to ensure that targeted assets are not assessed as dirty when read back in without being modified. The problem with the Common Templates asset is that it writes files to disk as a targeted asset but then does not load any assets back in. So a test that verifies that the loaded-in asset matches the written asset fails.