Skip to content

Conversation

@r4f4
Copy link
Contributor

@r4f4 r4f4 commented Jul 8, 2024

As part of the 4.17 branching list.

r4f4 added 4 commits July 8, 2024 19:53
Notice that we had to also bump machine-api-operator to include [1] so
it would build with the latest openshift/api.

[1] openshift/machine-api-operator#1256
So that they are all at 0.30.1 after the kube bump in Openshift.
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 8, 2024

@r4f4: This pull request references CORS-3593 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.17.0" version, but no target version was set.

Details

In response to this:

As part of the 4.17 branching list.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 8, 2024
@openshift-ci openshift-ci bot requested review from bfournie and rwsu July 8, 2024 18:07
@patrickdillon
Copy link
Contributor

/approve

LGTM based on tests

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2024
@patrickdillon
Copy link
Contributor

none of the test failures look related.

/lgtm

@patrickdillon
Copy link
Contributor

@2uasimojo I think hive likes to know when we bump these depencies...

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 5b289b7 and 2 for PR HEAD 00114bd in total

@2uasimojo
Copy link
Member

@2uasimojo I think hive likes to know when we bump these depencies...

Thanks Patrick! cc @lleshchi

@r4f4
Copy link
Contributor Author

r4f4 commented Jul 9, 2024

@2uasimojo I think hive likes to know when we bump these depencies...

Thanks Patrick! cc @lleshchi

Good to know. I'll add to the story description that we should notify Hive when we do the bump after branching.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9526425 and 1 for PR HEAD 00114bd in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 10, 2024

@r4f4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-nfv-intel 00114bd link false /test e2e-openstack-nfv-intel
ci/prow/e2e-openstack-proxy 00114bd link false /test e2e-openstack-proxy
ci/prow/e2e-azurestack 00114bd link false /test e2e-azurestack
ci/prow/e2e-metal-ipi-ovn-dualstack 00114bd link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-azure-ovn-shared-vpc 00114bd link false /test e2e-azure-ovn-shared-vpc

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@patrickdillon
Copy link
Contributor

/override ci/prow/e2e-vsphere-ovn
/skip

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 10, 2024

@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/e2e-vsphere-ovn

Details

In response to this:

/override ci/prow/e2e-vsphere-ovn
/skip

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 318dc21 into openshift:master Jul 10, 2024
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.17.0-202407101641.p0.g318dc21.assembly.stream.el9 for distgit ose-installer-altinfra.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants