hack/get-terraform: Remove obsolete script #853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/hold
openshift-ci-robot
added
size/XXL
Contributor
|
/lgtm |
Contributor
|
/retest |
Now that we're vendoring Terraform, we no longer need a script to pull down pre-compiled binaries. I've also reworded the 'create cluster' description in overview.md to be more generic. See 0c3d8658 (asset/cluster: clean up logging messages, 2018-12-07, openshift#840) for similar changes to another location.
wking
force-pushed
the
drop-get-terraform
branch
from
f9666a3 to
aff2e98
Compare
openshift-ci-robot
added
size/M
Member
Author
openshift-ci-robot
removed
the
do-not-merge/hold
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
Hive was pulling the installer image, copying out openshift-install, and terraform, should we adjust hive now to just copy out openshift-install and terraform is no longer needed? |
Contributor
|
Disregard, in testing I can see this is the case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we're vendoring Terraform, we no longer need a script to pull down pre-compiled binaries.
I've also reworded the
create clusterdescription inoverview.mdto be more generic. See 0c3d8658 (#840) for similar changes to another location.Builds on #822. I dunno how well Prow handles this sort of thing with both PRs actively in the merge queue, so:
/hold
CC @crawford