OCPBUGS-33793: Make Ingress capability required for standalone OpenShift #8502
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@alebedev87: This pull request references Jira Issue OCPBUGS-33793, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@alebedev87: This pull request references Jira Issue OCPBUGS-33793, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
There was a problem hiding this comment.
Ingress capability should be always enabled in standalone ocp, not only on IPI, UPI should also be considered.
perhaps this check should be added into installconfig validation, https://github.com/openshift/installer/blob/master/pkg/types/validation/installconfig.go#L195?
There was a problem hiding this comment.
Right, that may be more appropriate place for the validation.
There was a problem hiding this comment.
In UPI, users can provide their own ingress and not use the ingress operator: https://docs.openshift.com/container-platform/4.15/installing/installing_aws/installing-aws-user-infra.html#installation-user-infra-generate-k8s-manifest-ignition_installing-aws-user-infra
I think it makes sense to only enforce this check for IPI
There was a problem hiding this comment.
From what I can see the users can set up the network load balancer and the dns records. Both of them are required to send the network traffic to the ingresscontroller (router). The latter is still deployed (we can see this in the commands oc -n openshift-ingress get service router-default). The router is a part of the ingress capability. So if it would be disabled I don't understand where the setup NLB and DNS would send the traffic to.
There was a problem hiding this comment.
Makes sense, only the DNS records can be user provisioned. Thanks!
alebedev87
force-pushed
the
OCPBUGS-33793
branch
2 times, most recently
from
9db8d23 to
3b16fa0
Compare
alebedev87
changed the title
alebedev87
changed the title
|
/cherry-pick release-4.16 |
|
@pawanpinjarkar: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@alebedev87: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@alebedev87: Jira Issue OCPBUGS-33793: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-33793 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@pawanpinjarkar: new pull request created: #8519 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-installer-altinfra-container-v4.17.0-202406010114.p0.g3ee2719.assembly.stream.el9 for distgit ose-installer-altinfra. |
7 participants
This PR aims at bringing an early warning about the fact that the ingress capability should be enabled. This PR is additional to openshift/cluster-version-operator#946 which always enables the ingress capability on any cluster managed by CVO.
Initial EP: https://github.com/openshift/enhancements/blob/master/enhancements/ingress/optional-ingress-hypershift.md.