Skip to content

OCPBUGS-33496: ensure ipv6 bootstrap VM client-id is predictable #8480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mkowalski wants to merge 1 commit into from
Closed

OCPBUGS-33496: ensure ipv6 bootstrap VM client-id is predictable #8480

mkowalski wants to merge 1 commit into from

Conversation

@mkowalski
Copy link
Contributor

@mkowalski mkowalski commented May 27, 2024

In #5110 we hade sure that for Baremetal IPI the IPv6 bootstrap VM client-id is predictable. This however did not cover UPI deployments.

With this change deployments with platform none will also use predictable client-id.

Fixes: OCPBUGS-33496

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 27, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 27, 2024

@mkowalski: This pull request references Jira Issue OCPBUGS-33496, which is invalid:

  • expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

In #5110 we hade sure that for Baremetal IPI the IPv6 bootstrap VM client-id is predictable. This however did not cover UPI deployments.

With this change deployments with platform none will also use predictable client-id.

Fixes: OCPBUGS-33496

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mkowalski
Copy link
Contributor Author

mkowalski commented May 27, 2024

/cc @cybertron

@openshift-ci openshift-ci bot requested review from cybertron, rna-afk and rwsu May 27, 2024 15:53
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign patrickdillon for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mkowalski
Copy link
Contributor Author

mkowalski commented May 27, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 27, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 27, 2024

@mkowalski: This pull request references Jira Issue OCPBUGS-33496, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 27, 2024
@openshift-ci openshift-ci bot requested a review from gpei May 27, 2024 15:55
cybertron
cybertron reviewed May 28, 2024
View reviewed changes
data/data/bootstrap/none/files/etc/NetworkManager/conf.d/99-ipv6.conf Outdated
Copy link
Member

@cybertron cybertron May 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want this. It will break any platform that doesn't use resolv-prepender.

Copy link
Contributor Author

@mkowalski mkowalski May 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, removing. I was partially blind as why we have it so just copy-pasted

@mkowalski
OCPBUGS-33496: ensure ipv6 bootstrap VM client-id is predictable
058619d 
In openshift#5110 we hade sure that
for Baremetal IPI the IPv6 bootstrap VM client-id is predictable. This
however did not cover UPI deployments.

With this change deployments with platform `none` will also use
predictable client-id.

Fixes: OCPBUGS-33496
@cybertron
Copy link
Member

cybertron commented Jun 4, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2024
@mkowalski
Copy link
Contributor Author

mkowalski commented Aug 5, 2024

/retest-required

@mkowalski
Copy link
Contributor Author

mkowalski commented Jan 10, 2025

/retest

1 similar comment
@sadasu
Copy link
Contributor

sadasu commented Jan 31, 2025

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2025

@mkowalski: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-ovn-upgrade 058619d link false /test okd-e2e-aws-ovn-upgrade
ci/prow/okd-images 058619d link true /test okd-images
ci/prow/e2e-vsphere-host-groups-ovn-custom-no-upgrade 058619d link false /test e2e-vsphere-host-groups-ovn-custom-no-upgrade
ci/prow/e2e-azure-ovn-upi 058619d link false /test e2e-azure-ovn-upi
ci/prow/e2e-vsphere-externallb-ovn 058619d link false /test e2e-vsphere-externallb-ovn
ci/prow/artifacts-images 058619d link true /test artifacts-images
ci/prow/okd-scos-images 058619d link true /test okd-scos-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 6, 2025

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 6, 2025
@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 6, 2025

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 6, 2025
@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 6, 2025

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Oct 6, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2025

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 6, 2025

@mkowalski: This pull request references Jira Issue OCPBUGS-33496. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

In #5110 we hade sure that for Baremetal IPI the IPv6 bootstrap VM client-id is predictable. This however did not cover UPI deployments.

With this change deployments with platform none will also use predictable client-id.

Fixes: OCPBUGS-33496

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rna-afk rna-afk Awaiting requested review from rna-afk

@rwsu rwsu Awaiting requested review from rwsu

@gpei gpei Awaiting requested review from gpei

1 more reviewer

@cybertron cybertron cybertron left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@cybertron cybertron

Labels

jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mkowalski @openshift-ci-robot @cybertron @sadasu @openshift-bot