OCPBUGS-33024: agent: escape '%' in proxy settings

[r4f4]

The 'DefaultEnvironment' config from systemd accepts some % specifiers for expansion [1]. Because of that, proxy configurations that make use of that character need to be escaped with another '%'.

[1] https://man7.org/linux/man-pages/man5/systemd-system.conf.5.html

[openshift-ci-robot]

@r4f4: This pull request references Jira Issue OCPBUGS-33024, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The 'DefaultEnvironment' config from systemd accepts some % specifiers for expansion [1]. Because of that, proxy configurations that make use of that character need to be escaped with another '%'.

[1] https://man7.org/linux/man-pages/man5/systemd-system.conf.5.html

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@r4f4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-e2e-agent-compact-ipv4	c2bd15f	link	false	/test okd-e2e-agent-compact-ipv4
ci/prow/e2e-agent-compact-ipv4-appliance-diskimage	c2bd15f	link	false	/test e2e-agent-compact-ipv4-appliance-diskimage

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[zaneb]

/approve
Thanks!

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• data/data/agent/OWNERS [zaneb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[barbacbd]

/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 1a3d6c2 and 2 for PR HEAD c2bd15f in total

[openshift-ci-robot]

@r4f4: Jira Issue OCPBUGS-33024: All pull requests linked via external trackers have merged:

• openshift/installer#8320

Jira Issue OCPBUGS-33024 has been moved to the MODIFIED state.

Details

In response to this:

The 'DefaultEnvironment' config from systemd accepts some % specifiers for expansion [1]. Because of that, proxy configurations that make use of that character need to be escaped with another '%'.

[1] https://man7.org/linux/man-pages/man5/systemd-system.conf.5.html

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.16.0-202404292211.p0.g55f8072.assembly.stream.el9 for distgit ose-installer-altinfra.
All builds following this will include this PR.

[openshift-merge-robot]

Fix included in accepted release 4.16.0-0.nightly-2024-04-30-053518