Skip to content

OCPBUGS-33006: baremetal: set bootstrap domain arch#8317

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
honza:bootstrap-arch
Apr 30, 2024
Merged

OCPBUGS-33006: baremetal: set bootstrap domain arch#8317
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
honza:bootstrap-arch

Conversation

@honza
Copy link
Member

@honza honza commented Apr 25, 2024

No description provided.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Apr 25, 2024
@openshift-ci-robot
Copy link
Contributor

@honza: This pull request references Jira Issue OCPBUGS-33006, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jadhaj

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 25, 2024

@honza: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-virtualmedia 7857de6 link false /test e2e-metal-ipi-ovn-virtualmedia
ci/prow/e2e-metal-assisted 7857de6 link false /test e2e-metal-assisted
ci/prow/e2e-metal-single-node-live-iso 7857de6 link false /test e2e-metal-single-node-live-iso
ci/prow/e2e-metal-ipi-ovn-swapped-hosts 7857de6 link false /test e2e-metal-ipi-ovn-swapped-hosts
ci/prow/e2e-metal-ipi-ovn-dualstack 7857de6 link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-metal-ipi-ovn 7857de6 link false /test e2e-metal-ipi-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@zaneb zaneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

return fmt.Errorf("failed to get libvirt capabilities: %w", err)
}

bootstrapDom.OS.Type.Arch = capabilities.Host.CPU.Arch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it would be less confusing to pass the hypervisor capabilities to newDomain()

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2024
@elfosardo
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 0e60215 into openshift:master Apr 30, 2024
@openshift-ci-robot
Copy link
Contributor

@honza: An error was encountered updating to the MODIFIED state for bug OCPBUGS-33006 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message. It seems that you have tried to perform a workflow operation (MODIFIED) that is not valid for the current state of this issue (OCPBUGS-33006). The likely cause is that somebody has changed the issue recently, please look at the issue history for details.: request failed. Please analyze the request body for more details. Status code: 400:

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants