CORS-2893: capi-aws: implement preserveBootstrapIgnition

[r4f4]

This feature is needed for customers running installs under systems with policies that prevent S3 objects from being deleted.

The way this was implemented in CAPA, the provider will try to delete the objects but ignore the errors if BestEffortDeleteObjects is set in the AWSCluster bucket spec.

[openshift-ci-robot]

@r4f4: This pull request references CORS-2893 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

This feature is needed for customers running installs under systems with policies that prevent S3 objects from being deleted.

The way this was implemented in CAPA, the provider will try to delete the objects but ignore the errors if BestEffortDeleteObjectsis set in theAWSCluster` bucket spec.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[r4f4]

In my local testing, I see:

DEBUG I0424 14:33:51.363347     133 s3.go:219] "Deleting S3 object" controller="awsmachine" controllerGroup="infrastructure.cluster.x-k8s.io" controllerKind="AWSMachine" AWSMachine="openshift-cluster-api-guests/rafa1-2dzr7-master-2" namespace="openshift-cluster-api-guests" name="rafa1-2dzr7-master-2" reconcileID="c130b49a-c9cd-419b-a5fd-b702e075223d" machine="openshift-cluster-api-guests/rafa1-2dzr7-master-2" cluster="openshift-cluster-api-guests/rafa1-2dzr7" bucket="openshift-bootstrap-data-rafa1-2dzr7" key="control-plane/rafa1-2dzr7-master-2"
[...]
DEBUG I0424 14:33:51.700633     133 s3.go:233] "Ignoring deletion error" controller="awsmachine" controllerGroup="infrastructure.cluster.x-k8s.io" controllerKind="AWSMachine" AWSMachine="openshift-cluster-api-guests/rafa1-2dzr7-master-2" namespace="openshift-cluster-api-guests" name="rafa1-2dzr7-master-2" reconcileID="c130b49a-c9cd-419b-a5fd-b702e075223d" machine="openshift-cluster-api-guests/rafa1-2dzr7-master-2" cluster="openshift-cluster-api-guests/rafa1-2dzr7" bucket="openshift-bootstrap-data-rafa1-2dzr7" key="control-plane/rafa1-2dzr7-master-2" error="Access Denied"

[r4f4]

/uncc @pawanpinjarkar @rna-afk
/hold

[r4f4]

Will rebase once #8223 merges with the capa bump.

[r4f4]

/hold cancel
/cc @patrickdillon @mtulio

[mtulio]

/lgtm

[openshift-ci]

@r4f4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-single-node	6b68a44	link	false	/test e2e-aws-ovn-single-node
ci/prow/okd-e2e-aws-ovn-upgrade	fede4d7dba871da67af875ec1416139ccf34ff80	link	false	/test okd-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[r4f4]

/assign @patrickdillon

[patrickdillon]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment