AGENT-861: Monitor add nodes command (single node) by rwsu · Pull Request #8171 · openshift/installer

rwsu · 2024-03-15T22:22:49Z

Implements the monitor-add-nodes command for a single node.

The command ends when node is in Ready state.

openshift-ci-robot · 2024-03-15T22:22:54Z

@rwsu: This pull request references AGENT-861 which is a valid jira issue.

Details

In response to this:

Implements the monitor-add-nodes command for a single node.

The command ends when node is in Ready state and the cluster has no Pending CSRs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2024-03-15T22:22:57Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-bot · 2024-04-11T03:39:42Z

@rwsu: This pull request references AGENT-861 which is a valid jira issue.

Details

In response to this:

Implements the monitor-add-nodes command for a single node.

The command ends when node is in Ready state.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pkg/nodejoiner/monitoraddnodes.go

pkg/agent/cluster.go

cmd/openshift-install/agent/waitfor.go

pkg/agent/kube.go

pkg/agent/monitoraddnodes.go

The function now requires kubeconfig file path, rendezvousIP, and sshKey as parameters. Previously it had a single parameter, assetStore, and it searched the asset store to determine the three parameters above.

Adds the ability to monitor a node being added during day2. The command is: node-joiner monitor-add-nodes --kubeconfig <kubeconfig-file-path> <IP-address-of-node-to-monitor> Both the kubeconfig file and IP address are required. Multi node monitoring will be added in a future PR.

NewCluster needs both assetDir for install workflow and kubeconfigPath for addnodes workflow. Cluster.assetDir should only be initialized for the install workflow.

pkg/agent/cluster.go

pkg/agent/kube.go

pkg/agent/monitoraddnodes.go

checks.

using feedback from Andrea Fasano.

openshift-ci-robot · 2024-05-11T08:25:48Z

/retest-required

Remaining retests: 0 against base HEAD 7d51e80 and 0 for PR HEAD 39c5c6b in total

openshift-ci-robot · 2024-05-11T09:25:50Z

/hold

Revision 39c5c6b was retested 3 times: holding

andfasano · 2024-05-13T09:03:03Z

/hold cancel

andfasano · 2024-05-13T09:03:41Z

/retest-required

openshift-ci-robot · 2024-05-13T09:23:38Z

/retest-required

Remaining retests: 0 against base HEAD 7d51e80 and 2 for PR HEAD 39c5c6b in total

openshift-ci-robot · 2024-05-13T13:01:34Z

/retest-required

Remaining retests: 0 against base HEAD 7f7c54c and 1 for PR HEAD 39c5c6b in total

openshift-ci-robot · 2024-05-13T17:01:43Z

/retest-required

Remaining retests: 0 against base HEAD 412a878 and 0 for PR HEAD 39c5c6b in total

openshift-ci-robot · 2024-05-13T18:01:34Z

/hold

Revision 39c5c6b was retested 3 times: holding

rwsu · 2024-05-13T19:12:48Z

/unhold
/retest-required

openshift-ci-robot · 2024-05-13T21:01:35Z

/retest-required

Remaining retests: 0 against base HEAD 0621961 and 2 for PR HEAD 39c5c6b in total

openshift-ci-robot · 2024-05-14T01:01:40Z

/retest-required

Remaining retests: 0 against base HEAD 7a7745f and 1 for PR HEAD 39c5c6b in total

openshift-ci-robot · 2024-05-14T05:01:42Z

/retest-required

Remaining retests: 0 against base HEAD 662d011 and 0 for PR HEAD 39c5c6b in total

openshift-ci-robot · 2024-05-14T09:01:51Z

/hold

Revision 39c5c6b was retested 3 times: holding

andfasano · 2024-05-14T09:52:09Z

/hold cancel

andfasano · 2024-05-14T09:52:51Z

/retest-required

openshift-ci-robot · 2024-05-14T14:01:44Z

/retest-required

Remaining retests: 0 against base HEAD 662d011 and 2 for PR HEAD 39c5c6b in total

rwsu · 2024-05-14T19:47:48Z

/retest-required

rwsu · 2024-05-15T02:36:16Z

/retest-required

andfasano · 2024-05-15T08:19:11Z

/test e2e-agent-compact-ipv4

andfasano · 2024-05-15T09:28:20Z

pkg/agent/monitoraddnodes.go

+				logrus.Warnf("Node %s: %s", nodeIPAddress, err)
+			}
+		}
+	}, 5*time.Second, waitContext.Done())


Not a blocking point for this PR, but a couple of notes that could be addressed separetely in future:

I'd find more intuitive to have the cluster.MonitorStatusFromAssistedService directly within the cluster.API.Rest.IsRestAPILive() block.

Without the burden of using a complete fsm, it could be worth reversing the order of the various states checks and return immediately if satisfied. It could probably also helps in simplifying a little bit the code

openshift-ci · 2024-05-15T11:31:51Z

@rwsu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-e2e-aws-ovn-upgrade	`39c5c6b`	link	false	`/test okd-e2e-aws-ovn-upgrade`
ci/prow/e2e-agent-compact-ipv4-appliance-diskimage	`39c5c6b`	link	false	`/test e2e-agent-compact-ipv4-appliance-diskimage`
ci/prow/okd-e2e-agent-compact-ipv4	`39c5c6b`	link	false	`/test okd-e2e-agent-compact-ipv4`
ci/prow/e2e-agent-compact-ipv4-appliance	`39c5c6b`	link	false	`/test e2e-agent-compact-ipv4-appliance`
ci/prow/e2e-agent-compact-ipv4	`39c5c6b`	link	true	`/test e2e-agent-compact-ipv4`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

pawanpinjarkar · 2024-05-16T15:07:58Z

/acknowledge-critical-fixes-only

rwsu · 2024-05-17T02:07:16Z

Merged as part of #8376

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 15, 2024

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 15, 2024

rwsu force-pushed the AGENT-861 branch from 075024d to 86e07d6 Compare March 15, 2024 22:27

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2024

rwsu force-pushed the AGENT-861 branch from 86e07d6 to 94f49c5 Compare April 11, 2024 03:13

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 11, 2024

rwsu force-pushed the AGENT-861 branch from 94f49c5 to 1f2156d Compare April 11, 2024 03:37

rwsu marked this pull request as ready for review April 11, 2024 03:39

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2024

openshift-ci bot requested review from andfasano and patrickdillon April 11, 2024 03:40

rwsu force-pushed the AGENT-861 branch from 1f2156d to 99a8074 Compare April 11, 2024 03:48

andfasano reviewed Apr 12, 2024

View reviewed changes

andfasano mentioned this pull request Apr 15, 2024

AGENT-863: node-joiner cluster script #8242

Merged

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 15, 2024

rwsu added 5 commits April 16, 2024 00:00

Refactor agent.NewCluster for reuse

f5ca935

The function now requires kubeconfig file path, rendezvousIP, and sshKey as parameters. Previously it had a single parameter, assetStore, and it searched the asset store to determine the three parameters above.

Refactor into addNodeMonitor

7feb327

Add assisted-service validations and events to monitor-add-nodes

786c716

Add assetDir and kubeconfigPath parameters to NewCluster

7a4002e

NewCluster needs both assetDir for install workflow and kubeconfigPath for addnodes workflow. Cluster.assetDir should only be initialized for the install workflow.

rwsu force-pushed the AGENT-861 branch from 787b623 to 496275a Compare April 16, 2024 04:10

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 16, 2024

Fix linting issues

40e8d0b

rwsu force-pushed the AGENT-861 branch from 496275a to 40e8d0b Compare April 16, 2024 04:37

andfasano reviewed Apr 17, 2024

View reviewed changes

rwsu added 2 commits April 18, 2024 23:32

Remove checks requiring ssh. Add kubelet check. Refactor CSR

4d318e1

checks.

Refactor NewCluster and LogAssistedServiceStatus functions

1f1111c

using feedback from Andrea Fasano.

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 11, 2024

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2024

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2024

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2024

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2024

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2024

andfasano reviewed May 15, 2024

View reviewed changes

rwsu closed this May 17, 2024

Conversation

rwsu commented Mar 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 15, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Mar 15, 2024

Uh oh!

openshift-bot commented Apr 11, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

openshift-ci-robot commented May 11, 2024

Uh oh!

openshift-ci-robot commented May 11, 2024

Uh oh!

andfasano commented May 13, 2024

Uh oh!

andfasano commented May 13, 2024

Uh oh!

openshift-ci-robot commented May 13, 2024

Uh oh!

openshift-ci-robot commented May 13, 2024

Uh oh!

openshift-ci-robot commented May 13, 2024

Uh oh!

openshift-ci-robot commented May 13, 2024

Uh oh!

rwsu commented May 13, 2024

Uh oh!

openshift-ci-robot commented May 13, 2024

Uh oh!

openshift-ci-robot commented May 14, 2024

Uh oh!

openshift-ci-robot commented May 14, 2024

Uh oh!

openshift-ci-robot commented May 14, 2024

Uh oh!

andfasano commented May 14, 2024

Uh oh!

andfasano commented May 14, 2024

Uh oh!

openshift-ci-robot commented May 14, 2024

Uh oh!

rwsu commented May 14, 2024

Uh oh!

rwsu commented May 15, 2024

Uh oh!

andfasano commented May 15, 2024

Uh oh!

andfasano May 15, 2024

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented May 15, 2024

Uh oh!

pawanpinjarkar commented May 16, 2024

Uh oh!

rwsu commented May 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rwsu commented Mar 15, 2024 •

edited

Loading

openshift-ci-robot commented Mar 15, 2024 •

edited by openshift-ci bot

Loading

openshift-bot commented Apr 11, 2024 •

edited by openshift-ci bot

Loading