Skip to content

AGENT-874: use AddNodesConfig asset#8080

Merged
openshift-merge-bot[bot] merged 4 commits intoopenshift:masterfrom
andfasano:agent-day2-addnodesconfig
Mar 29, 2024
Merged

AGENT-874: use AddNodesConfig asset#8080
openshift-merge-bot[bot] merged 4 commits intoopenshift:masterfrom
andfasano:agent-day2-addnodesconfig

Conversation

@andfasano
Copy link
Contributor

@andfasano andfasano commented Feb 28, 2024

This patch is based on PR #8009.

The nodes-config.yaml is managed by the AddNodesConfig asset, and used in the asset graph.
First injection of ClusterInfo and AddNodesConfig assets into the Ignition asset.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 28, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 28, 2024 •
edited by openshift-ci bot
Loading

@andfasano: This pull request references AGENT-874 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.16.0" version, but no target version was set.

Details

In response to this:

This patch is based on PR #8009.

The nodes-config.yaml is managed by the AddNodesConfig asset, and used in the asset graph.
First injection of ClusterInfo and AddNodesConfig assets into the Ignition asset.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@andfasano andfasano mentioned this pull request Mar 1, 2024
Merged
@andfasano andfasano force-pushed the agent-day2-addnodesconfig branch from 5ab1527 to eb19831 Compare March 1, 2024 18:04
rwsu
rwsu reviewed Mar 7, 2024
View reviewed changes
bfournie
bfournie reviewed Mar 8, 2024
View reviewed changes
bfournie
bfournie reviewed Mar 8, 2024
View reviewed changes
bfournie
bfournie reviewed Mar 8, 2024
View reviewed changes
rwsu
rwsu reviewed Mar 12, 2024
View reviewed changes
Copy link
Contributor

@rwsu rwsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 12, 2024
@andfasano andfasano mentioned this pull request Mar 14, 2024
Merged
@andfasano andfasano force-pushed the agent-day2-addnodesconfig branch from eb19831 to 7181f71 Compare March 27, 2024 17:53
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
@andfasano andfasano force-pushed the agent-day2-addnodesconfig branch 2 times, most recently from 7f2e317 to 708bfe4 Compare March 27, 2024 19:01
@andfasano andfasano force-pushed the agent-day2-addnodesconfig branch from 708bfe4 to 7b84d3c Compare March 28, 2024 08:34
@andfasano
Copy link
Contributor Author

andfasano commented Mar 28, 2024

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 28, 2024

@andfasano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-ovn-upgrade 708bfe4f3c12574c10aa41935c8664730e519549 link false /test okd-e2e-aws-ovn-upgrade
ci/prow/okd-e2e-agent-compact-ipv4 7b84d3c link false /test okd-e2e-agent-compact-ipv4
ci/prow/e2e-agent-sno-ipv4-pxe 7b84d3c link false /test e2e-agent-sno-ipv4-pxe
ci/prow/e2e-agent-sno-ipv6 7b84d3c link false /test e2e-agent-sno-ipv6

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

rwsu
rwsu reviewed Mar 28, 2024
View reviewed changes
Copy link
Contributor

@rwsu rwsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2024
@bfournie
Copy link
Contributor

bfournie commented Mar 29, 2024

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 3f030bd into openshift:master Mar 29, 2024
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 29, 2024

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.16.0-202403291645.p0.g3f030bd.assembly.stream.el8 for distgit ose-installer-altinfra.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@pawanpinjarkar pawanpinjarkar Awaiting requested review from pawanpinjarkar

2 more reviewers

@rwsu rwsu rwsu left review comments

@bfournie bfournie bfournie left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@rwsu rwsu

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@andfasano @openshift-ci-robot @bfournie @openshift-bot @rwsu