Skip to content

OCPBUGS-29968: Generate ZTP manifests with correct Group/Version/Kind metadata#8068

Merged
openshift-merge-bot[bot] merged 3 commits intoopenshift:masterfrom
zaneb:cluster-manifests-gvk
Apr 29, 2024
Merged

OCPBUGS-29968: Generate ZTP manifests with correct Group/Version/Kind metadata#8068
openshift-merge-bot[bot] merged 3 commits intoopenshift:masterfrom
zaneb:cluster-manifests-gvk

Conversation

@zaneb
Copy link
Member

@zaneb zaneb commented Feb 27, 2024

No description provided.

@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Feb 27, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 27, 2024

@zaneb: This pull request references Jira Issue OCPBUGS-29968, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 27, 2024
@zaneb
Copy link
Member Author

zaneb commented Feb 27, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 27, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 27, 2024

@zaneb: This pull request references Jira Issue OCPBUGS-29968, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mhanss

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from bfournie, mhanss and rwsu February 27, 2024 10:14
@bfournie
Copy link
Contributor

bfournie commented Feb 27, 2024

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2024
rwsu
rwsu reviewed Feb 27, 2024
View reviewed changes
Copy link
Contributor

@rwsu rwsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2024
rwsu
rwsu suggested changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@rwsu rwsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh it looks like the integration tests failed. The expected ZTP manifests in the integration tests are missing the GVK. Example: https://github.com/openshift/installer/blob/ac363faade398190adb15e0da42cd42bc82c5714/cmd/openshift-install/testdata/agent/configimage/manifests/default_manifests.txt#L45

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 27, 2024

/retest-required

Remaining retests: 0 against base HEAD 6e9d05c and 2 for PR HEAD ac363faade398190adb15e0da42cd42bc82c5714 in total

@zaneb zaneb force-pushed the cluster-manifests-gvk branch from ac363fa to f685fd6 Compare February 27, 2024 22:48
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zaneb
Copy link
Member Author

zaneb commented Mar 13, 2024

/retest-required

1 similar comment
@zaneb
Copy link
Member Author

zaneb commented Mar 27, 2024

/retest-required

@zaneb zaneb force-pushed the cluster-manifests-gvk branch from f685fd6 to 82fb667 Compare April 5, 2024 00:54
@zaneb zaneb force-pushed the cluster-manifests-gvk branch from 82fb667 to 5e5982d Compare April 7, 2024 23:10
@zaneb
Copy link
Member Author

zaneb commented Apr 22, 2024

/retest-required

@rwsu
Copy link
Contributor

rwsu commented Apr 24, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 24, 2024

/retest-required

Remaining retests: 0 against base HEAD c94bdb3 and 2 for PR HEAD 5e5982d in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 24, 2024

/retest-required

Remaining retests: 0 against base HEAD 5d5fe31 and 1 for PR HEAD 5e5982d in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 24, 2024

/retest-required

Remaining retests: 0 against base HEAD f255868 and 0 for PR HEAD 5e5982d in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 24, 2024

/hold

Revision 5e5982d was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2024
@zaneb
Copy link
Member Author

zaneb commented Apr 29, 2024

/test e2e-agent-compact-ipv4-appliance-diskimage
/test e2e-agent-ha-dualstack
/test e2e-vsphere-ovn
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 29, 2024

@zaneb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-dualstack 5e5982d link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-metal-ipi-ovn 5e5982d link false /test e2e-metal-ipi-ovn
ci/prow/okd-e2e-agent-compact-ipv4 5e5982d link false /test okd-e2e-agent-compact-ipv4
ci/prow/okd-e2e-aws-ovn-upgrade 5e5982d link false /test okd-e2e-aws-ovn-upgrade
ci/prow/e2e-agent-compact-ipv4-appliance-diskimage 5e5982d link false /test e2e-agent-compact-ipv4-appliance-diskimage

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit c2fa2bf into openshift:master Apr 29, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 29, 2024

@zaneb: Jira Issue OCPBUGS-29968: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29968 has been moved to the MODIFIED state.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 29, 2024

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.16.0-202404291547.p0.gc2fa2bf.assembly.stream.el9 for distgit ose-installer-altinfra.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Apr 30, 2024

Fix included in accepted release 4.16.0-0.nightly-2024-04-29-222758

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhanss mhanss Awaiting requested review from mhanss

@bfournie bfournie Awaiting requested review from bfournie

1 more reviewer

@rwsu rwsu rwsu requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rwsu rwsu

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zaneb @openshift-ci-robot @bfournie @rwsu @openshift-bot @openshift-merge-robot