-
Notifications
You must be signed in to change notification settings - Fork 1.5k
CORS-3071: Create DNS entries for CAPZ implementation #8045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,196 @@ | ||
| package azure | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
|
|
||
| "github.com/Azure/azure-sdk-for-go/sdk/azidentity" | ||
| "github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/dns/armdns" | ||
| "github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/privatedns/armprivatedns" | ||
| "k8s.io/utils/ptr" | ||
| capz "sigs.k8s.io/cluster-api-provider-azure/api/v1beta1" | ||
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
|
|
||
| "github.com/openshift/installer/pkg/asset/manifests/capiutils" | ||
| "github.com/openshift/installer/pkg/infrastructure/clusterapi" | ||
| "github.com/openshift/installer/pkg/types" | ||
| ) | ||
|
|
||
| type recordListType string | ||
|
|
||
| const ( | ||
| cname recordListType = "Cname" | ||
| arecord recordListType = "ARecord" | ||
| aaaarecord recordListType = "AaaaRecord" | ||
| ) | ||
|
|
||
| type recordList struct { | ||
| Name string | ||
| RecordType armdns.RecordType | ||
| RecordSet armdns.RecordSet | ||
| } | ||
|
|
||
| type recordPrivateList struct { | ||
| Name string | ||
| RecordType armprivatedns.RecordType | ||
| RecordSet armprivatedns.RecordSet | ||
| } | ||
|
|
||
| // Create DNS entries for azure. | ||
| func createDNSEntries(ctx context.Context, in clusterapi.InfraReadyInput) error { | ||
| private := in.InstallConfig.Config.Publish == types.InternalPublishingStrategy | ||
| baseDomainResourceGroup := in.InstallConfig.Config.Azure.BaseDomainResourceGroupName | ||
| zone := in.InstallConfig.Config.BaseDomain | ||
| privatezone := in.InstallConfig.Config.ClusterDomain() | ||
| apiExternalName := fmt.Sprintf("api.%s", in.InstallConfig.Config.ObjectMeta.Name) | ||
|
|
||
| resourceGroup := fmt.Sprintf("%s-rg", in.InfraID) | ||
| if in.InstallConfig.Config.Azure.ResourceGroupName != "" { | ||
| resourceGroup = in.InstallConfig.Config.Azure.ResourceGroupName | ||
| } | ||
| azureTags := make(map[string]*string) | ||
| for k, v := range in.InstallConfig.Config.Azure.UserTags { | ||
| azureTags[k] = ptr.To(v) | ||
| } | ||
| azureCluster := &capz.AzureCluster{} | ||
| key := client.ObjectKey{ | ||
| Name: in.InfraID, | ||
| Namespace: capiutils.Namespace, | ||
| } | ||
| if err := in.Client.Get(ctx, key, azureCluster); err != nil && azureCluster != nil { | ||
| return fmt.Errorf("failed to get Azure cluster: %w", err) | ||
| } | ||
|
|
||
| if len(azureCluster.Spec.NetworkSpec.APIServerLB.FrontendIPs) == 0 { | ||
| return fmt.Errorf("failed to get Azure cluster LB frontend IPs") | ||
| } | ||
| ipIlb := azureCluster.Spec.NetworkSpec.APIServerLB.FrontendIPs[0].PrivateIPAddress | ||
rna-afk marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| // useIPv6 := false | ||
| // for _, network := range in.InstallConfig.Config.Networking.ServiceNetwork { | ||
| // if network.IP.To4() == nil { | ||
| // useIPv6 = true | ||
| // } | ||
| // } | ||
|
|
||
| privateRecords := []recordPrivateList{} | ||
| ttl := int64(300) | ||
| recordType := arecord | ||
| // if useIPv6 { | ||
| // recordType = aaaarecord | ||
| // } | ||
| privateRecords = append(privateRecords, createPrivateRecordSet("api-int", azureTags, ttl, recordType, ipIlb, "")) | ||
| privateRecords = append(privateRecords, createPrivateRecordSet("api", azureTags, ttl, recordType, ipIlb, "")) | ||
|
|
||
| session, err := in.InstallConfig.Azure.Session() | ||
| if err != nil { | ||
| return fmt.Errorf("failed to create session: %w", err) | ||
| } | ||
| subscriptionID := session.Credentials.SubscriptionID | ||
| tokenCreds, err := azidentity.NewClientSecretCredential(session.Credentials.TenantID, session.Credentials.ClientID, session.Credentials.ClientSecret, nil) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to create identity: %w", err) | ||
| } | ||
| recordSetClient, err := armdns.NewRecordSetsClient(subscriptionID, tokenCreds, nil) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to create public record client: %w", err) | ||
| } | ||
| privateRecordSetClient, err := armprivatedns.NewRecordSetsClient(subscriptionID, tokenCreds, nil) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to create private record client: %w", err) | ||
| } | ||
|
|
||
| // Create the records for api and api-int in the private zone and api.<clustername> for public zone. | ||
| // CAPI currently creates a record called "apiserver" instead of "api" so creating "api" for the installer in the private zone. | ||
| if !private { | ||
| cnameRecordName := apiExternalName | ||
| // apiExternalNameV6 := fmt.Sprintf("v6-api.%s", infraID) | ||
| // if useIPv6 { | ||
| // cnameRecordName = apiExternalNameV6 | ||
| // } | ||
| // TODO: Populate with public LB FQDN. Placeholder text as value. | ||
| publicRecords := createRecordSet(cnameRecordName, azureTags, ttl, cname, "", in.InstallConfig.Config.ClusterDomain()) | ||
| _, err = recordSetClient.CreateOrUpdate(ctx, baseDomainResourceGroup, zone, publicRecords.Name, publicRecords.RecordType, publicRecords.RecordSet, nil) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to create public record set: %w", err) | ||
| } | ||
| } | ||
|
|
||
| for _, record := range privateRecords { | ||
| _, err = privateRecordSetClient.CreateOrUpdate(ctx, resourceGroup, privatezone, record.RecordType, record.Name, record.RecordSet, nil) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to create private record set: %w", err) | ||
| } | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| func createPrivateRecordSet(lbType string, azureTags map[string]*string, ttl int64, rType recordListType, ipAddress string, recordName string) (record recordPrivateList) { | ||
| record = recordPrivateList{ | ||
| Name: lbType, | ||
| RecordSet: armprivatedns.RecordSet{ | ||
| Properties: &armprivatedns.RecordSetProperties{ | ||
| TTL: &ttl, | ||
| Metadata: azureTags, | ||
| }, | ||
| }, | ||
| } | ||
|
|
||
| switch rType { | ||
| case cname: | ||
| record.RecordType = armprivatedns.RecordTypeCNAME | ||
| record.RecordSet.Properties.CnameRecord = &armprivatedns.CnameRecord{ | ||
| Cname: &recordName, | ||
| } | ||
| case arecord: | ||
| record.RecordType = armprivatedns.RecordTypeA | ||
| record.RecordSet.Properties.ARecords = []*armprivatedns.ARecord{ | ||
| { | ||
| IPv4Address: &ipAddress, | ||
| }, | ||
| } | ||
| case aaaarecord: | ||
| record.RecordType = armprivatedns.RecordTypeAAAA | ||
| record.RecordSet.Properties.AaaaRecords = []*armprivatedns.AaaaRecord{ | ||
| { | ||
| IPv6Address: &ipAddress, | ||
| }, | ||
| } | ||
| } | ||
| return record | ||
| } | ||
|
|
||
| func createRecordSet(lbType string, azureTags map[string]*string, ttl int64, rType recordListType, ipAddress string, recordName string) (record recordList) { | ||
| record = recordList{ | ||
| Name: lbType, | ||
| RecordSet: armdns.RecordSet{ | ||
| Properties: &armdns.RecordSetProperties{ | ||
| TTL: &ttl, | ||
| Metadata: azureTags, | ||
| }, | ||
| }, | ||
| } | ||
|
|
||
| switch rType { | ||
| case cname: | ||
| record.RecordType = armdns.RecordTypeCNAME | ||
| record.RecordSet.Properties.CnameRecord = &armdns.CnameRecord{ | ||
| Cname: &recordName, | ||
| } | ||
| case arecord: | ||
| record.RecordType = armdns.RecordTypeA | ||
| record.RecordSet.Properties.ARecords = []*armdns.ARecord{ | ||
| { | ||
| IPv4Address: &ipAddress, | ||
| }, | ||
| } | ||
| case aaaarecord: | ||
| record.RecordType = armdns.RecordTypeAAAA | ||
| record.RecordSet.Properties.AaaaRecords = []*armdns.AaaaRecord{ | ||
| { | ||
| IPv6Address: &ipAddress, | ||
| }, | ||
| } | ||
| } | ||
| return record | ||
| } | ||
23 changes: 23 additions & 0 deletions
23
vendor/github.com/Azure/azure-sdk-for-go/sdk/azcore/CHANGELOG.md
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
16 changes: 5 additions & 11 deletions
16
vendor/github.com/Azure/azure-sdk-for-go/sdk/azcore/arm/client.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
5 changes: 3 additions & 2 deletions
5
vendor/github.com/Azure/azure-sdk-for-go/sdk/azcore/arm/runtime/policy_register_rp.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
4 changes: 2 additions & 2 deletions
4
vendor/github.com/Azure/azure-sdk-for-go/sdk/azcore/arm/runtime/policy_trace_namespace.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.