-
Notifications
You must be signed in to change notification settings - Fork 1.5k
OSASINFRA-3434: Use cluster-api-provider-openstack v0.10 and CAPO v1beta1 manifests #8021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
openshift-merge-bot
merged 10 commits into
openshift:master
from
shiftstack:capo-master
Apr 26, 2024
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c2f06a6
openstack: Apply FeatureSet in manifest-test
pierreprinetti 6d16c1a
openstack: Small refactor of PreProvision
pierreprinetti 1be8970
openstack: Upgrade the vendored CAPO to v0.10
pierreprinetti 5c107e3
openstack: Upgrade manifests to CAPO v1beta1
pierreprinetti 25c0a61
openstack: Create server groups in the CAPI flow
pierreprinetti 58ba126
openstack: Remove the bootstrap server group
pierreprinetti f1a5073
OpenStack: fetch VIPs Ports when using dualstack
MaysaMacedo 9f18453
OpenStack: Avoid creation of FIP when no external Network exists
MaysaMacedo f49c919
OpenStack: Skip API/Ingress management when using external LB
MaysaMacedo ff07510
OpenStack: fix enforcement of Masters Schedulable
MaysaMacedo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
The diff you're trying to view is too large. We only load the first 3000 changed files.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the Installer folks seems to have a guideline on splitting vendoring commits.
One commit with
go.modandgo.sumchange and another for the vendor update, like we did in this PR https://github.com/openshift/installer/pull/7939/commitscontext #7939 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it helps with reviewing specially when looking commit by commit in large PRs.