Skip to content

Comments

AGENT-853: Add ClusterInfo asset#7997

Merged
openshift-merge-bot[bot] merged 3 commits intoopenshift:masterfrom
andfasano:agent-day2-clusterinfo-asset
Mar 1, 2024
Merged

AGENT-853: Add ClusterInfo asset#7997
openshift-merge-bot[bot] merged 3 commits intoopenshift:masterfrom
andfasano:agent-day2-clusterinfo-asset

Conversation

@andfasano
Copy link
Contributor

@andfasano andfasano commented Feb 8, 2024

This patch introduces the ClusterInfo asset and the AgentWorkflow asset.

The ClusterInfo asset retrieves the required initial parameters to add a node from an existing cluster.
The AgentWorkflow asset is used to define the current workflow, and it will be consumed by other assets.

Note: this patch covers only a portion of the larger story https://issues.redhat.com/browse/AGENT-850, and other PRs will follow based on the current code

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 8, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 8, 2024 •
edited by openshift-ci bot
Loading

@andfasano: This pull request references AGENT-853 which is a valid jira issue.

Details

In response to this:

This patch introduces the ClusterInfo asset and the AgentWorkflow asset.

The ClusterInfo asset retrieves the required initial parameters to add a node from an existing cluster.
The AgentWorkflow asset is used to define the current workflow, and it will be consumed by other assets.

Note: this patch covers only a portion of the larger story https://issues.redhat.com/browse/AGENT-850, and other PRs will follow based on the current code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@andfasano
Copy link
Contributor Author

andfasano commented Feb 8, 2024

cc @rwsu

@openshift-ci openshift-ci bot requested review from barbacbd and zaneb February 8, 2024 16:20
@andfasano andfasano force-pushed the agent-day2-clusterinfo-asset branch from 0e225be to e771099 Compare February 8, 2024 18:59
@andfasano
Copy link
Contributor Author

andfasano commented Feb 9, 2024

/test e2e-agent-compact-ipv4

1 similar comment
@andfasano
Copy link
Contributor Author

andfasano commented Feb 9, 2024

/test e2e-agent-compact-ipv4

@andfasano
Copy link
Contributor Author

andfasano commented Feb 12, 2024

/retest

rwsu
rwsu suggested changes Feb 13, 2024
View reviewed changes
@andfasano andfasano force-pushed the agent-day2-clusterinfo-asset branch 3 times, most recently from 0e6b505 to 6e1223f Compare February 14, 2024 18:02
rwsu
rwsu approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@rwsu rwsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rwsu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2024
@andfasano andfasano force-pushed the agent-day2-clusterinfo-asset branch from 6e1223f to 35c7f83 Compare February 15, 2024 14:39
patrickdillon
patrickdillon reviewed Feb 16, 2024
View reviewed changes
Copy link
Contributor

@patrickdillon patrickdillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this LGTM except some small changes needed

@andfasano andfasano force-pushed the agent-day2-clusterinfo-asset branch from 35c7f83 to b501481 Compare February 16, 2024 09:32
patrickdillon
patrickdillon reviewed Feb 16, 2024
View reviewed changes
Copy link
Contributor

@patrickdillon patrickdillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linter is complaining because errors package is still imported but not used. also one errors.wrap got left behind

@andfasano andfasano force-pushed the agent-day2-clusterinfo-asset branch from b501481 to dc98386 Compare February 16, 2024 18:05
@andfasano andfasano force-pushed the agent-day2-clusterinfo-asset branch from dc98386 to d56bab4 Compare February 16, 2024 19:56
@andfasano andfasano mentioned this pull request Feb 20, 2024
Merged
@rwsu
Copy link
Contributor

rwsu commented Feb 26, 2024

/retest-required

@andfasano
Copy link
Contributor Author

andfasano commented Feb 27, 2024

/override e2e-agent-compact-ipv4
(since it's currently failing due an ovn issue, there's a pending fix ovn-kubernetes/ovn-kubernetes#4168)

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 27, 2024

@andfasano: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • e2e-agent-compact-ipv4

Only the following failed contexts/checkruns were expected:

  • ci/prow/agent-integration-tests
  • ci/prow/altinfra-images
  • ci/prow/aro-unit
  • ci/prow/e2e-agent-compact-ipv4
  • ci/prow/e2e-agent-compact-ipv4-appliance
  • ci/prow/e2e-agent-compact-ipv4-appliance-diskimage
  • ci/prow/e2e-agent-compact-ipv4-none-platform
  • ci/prow/e2e-agent-ha-dualstack
  • ci/prow/e2e-agent-sno-ipv4-pxe
  • ci/prow/e2e-agent-sno-ipv6
  • ci/prow/e2e-aws-ovn
  • ci/prow/e2e-aws-ovn-edge-zones-manifest-validation
  • ci/prow/gofmt
  • ci/prow/golint
  • ci/prow/govet
  • ci/prow/images
  • ci/prow/okd-e2e-agent-compact-ipv4
  • ci/prow/okd-e2e-agent-ha-dualstack
  • ci/prow/okd-e2e-agent-sno-ipv6
  • ci/prow/okd-e2e-aws-ovn-upgrade
  • ci/prow/okd-images
  • ci/prow/okd-scos-images
  • ci/prow/okd-scos-unit
  • ci/prow/okd-scos-verify-codegen
  • ci/prow/okd-unit
  • ci/prow/okd-verify-codegen
  • ci/prow/shellcheck
  • ci/prow/tf-fmt
  • ci/prow/tf-lint
  • ci/prow/unit
  • ci/prow/verify-codegen
  • ci/prow/verify-vendor
  • ci/prow/yaml-lint
  • pull-ci-openshift-installer-fcos-gofmt
  • pull-ci-openshift-installer-fcos-golint
  • pull-ci-openshift-installer-fcos-govet
  • pull-ci-openshift-installer-fcos-images
  • pull-ci-openshift-installer-fcos-unit
  • pull-ci-openshift-installer-fcos-verify-codegen
  • pull-ci-openshift-installer-fcos-verify-vendor
  • pull-ci-openshift-installer-master-agent-integration-tests
  • pull-ci-openshift-installer-master-altinfra-images
  • pull-ci-openshift-installer-master-aro-unit
  • pull-ci-openshift-installer-master-e2e-agent-compact-ipv4
  • pull-ci-openshift-installer-master-e2e-agent-compact-ipv4-appliance
  • pull-ci-openshift-installer-master-e2e-agent-compact-ipv4-appliance-diskimage
  • pull-ci-openshift-installer-master-e2e-agent-compact-ipv4-none-platform
  • pull-ci-openshift-installer-master-e2e-agent-ha-dualstack
  • pull-ci-openshift-installer-master-e2e-agent-sno-ipv4-pxe
  • pull-ci-openshift-installer-master-e2e-agent-sno-ipv6
  • pull-ci-openshift-installer-master-e2e-aws-ovn
  • pull-ci-openshift-installer-master-e2e-aws-ovn-edge-zones-manifest-validation
  • pull-ci-openshift-installer-master-okd-e2e-agent-compact-ipv4
  • pull-ci-openshift-installer-master-okd-e2e-agent-ha-dualstack
  • pull-ci-openshift-installer-master-okd-e2e-agent-sno-ipv6
  • pull-ci-openshift-installer-master-okd-e2e-aws-ovn-upgrade
  • pull-ci-openshift-installer-master-okd-images
  • pull-ci-openshift-installer-master-okd-scos-images
  • pull-ci-openshift-installer-master-okd-scos-unit
  • pull-ci-openshift-installer-master-okd-scos-verify-codegen
  • pull-ci-openshift-installer-master-okd-unit
  • pull-ci-openshift-installer-master-okd-verify-codegen
  • pull-ci-openshift-installer-master-shellcheck
  • pull-ci-openshift-installer-master-tf-fmt
  • pull-ci-openshift-installer-master-tf-lint
  • pull-ci-openshift-installer-master-yaml-lint
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override e2e-agent-compact-ipv4
(since it's currently failing due an ovn issue, there's a pending fix ovn-kubernetes/ovn-kubernetes#4168)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andfasano
Copy link
Contributor Author

andfasano commented Feb 27, 2024

/override ci/prow/e2e-agent-compact-ipv4

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 27, 2024

@andfasano: Overrode contexts on behalf of andfasano: ci/prow/e2e-agent-compact-ipv4

Details

In response to this:

/override ci/prow/e2e-agent-compact-ipv4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@patrickdillon
Copy link
Contributor

patrickdillon commented Feb 27, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 27, 2024

/retest-required

Remaining retests: 0 against base HEAD 6e9d05c and 2 for PR HEAD d56bab4 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 27, 2024

/retest-required

Remaining retests: 0 against base HEAD 34c5c96 and 1 for PR HEAD d56bab4 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 28, 2024

/retest-required

Remaining retests: 0 against base HEAD b8d5671 and 0 for PR HEAD d56bab4 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 28, 2024

/hold

Revision d56bab4 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2024
@andfasano
Copy link
Contributor Author

andfasano commented Feb 28, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2024
@andfasano
Copy link
Contributor Author

andfasano commented Feb 28, 2024

/test e2e-aws-ovn

@patrickdillon
Copy link
Contributor

patrickdillon commented Feb 29, 2024

/skip

@patrickdillon
Copy link
Contributor

patrickdillon commented Feb 29, 2024

/override ci/prow/e2e-aws-ovn

failing due to known issue and this test has previously passed

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 29, 2024

@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/e2e-aws-ovn

Details

In response to this:

/override ci/prow/e2e-aws-ovn

failing due to known issue and this test has previously passed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 29, 2024

/retest-required

Remaining retests: 0 against base HEAD 62209ca and 2 for PR HEAD d56bab4 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 1, 2024 •
edited
Loading

@andfasano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-agent-compact-ipv4 d56bab4 link false /test okd-e2e-agent-compact-ipv4
ci/prow/e2e-agent-compact-ipv4-appliance d56bab4 link false /test e2e-agent-compact-ipv4-appliance
ci/prow/okd-e2e-aws-ovn-upgrade d56bab4 link false /test okd-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andfasano
Copy link
Contributor Author

andfasano commented Mar 1, 2024

/override ci/prow/e2e-agent-compact-ipv4

(still waiting the fix openshift/ovn-kubernetes#2089 for the compact job to land)

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 1, 2024

@andfasano: Overrode contexts on behalf of andfasano: ci/prow/e2e-agent-compact-ipv4

Details

In response to this:

/override ci/prow/e2e-agent-compact-ipv4

(still waiting the fix openshift/ovn-kubernetes#2089 for the compact job to land)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 9552fc8 into openshift:master Mar 1, 2024
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 1, 2024

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.16.0-202403011138.p0.g9552fc8.assembly.stream.el8 for distgit ose-installer-altinfra.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrickdillon patrickdillon patrickdillon left review comments

@barbacbd barbacbd Awaiting requested review from barbacbd

@zaneb zaneb Awaiting requested review from zaneb

+1 more reviewer

@rwsu rwsu rwsu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@patrickdillon patrickdillon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@andfasano @openshift-ci-robot @rwsu @patrickdillon @openshift-bot