OCPBUGS-23399: Check if PER is enabled in the target PowerVS workspace by miyamotoh · Pull Request #7736 · openshift/installer

miyamotoh · 2023-11-16T21:26:11Z

This is essentially a backport of #7683, but with additional code to check the customer-prepared Workspace is good, which 4.15 changes and stops allowing BYO Workspace for GA. Due to more cases to support in 4.14, a little more logic & tests are included in this PR.

Signed-off-by: Hiro Miyamoto <miyamotoh@us.ibm.com>

openshift-ci-robot · 2023-11-17T15:33:54Z

@miyamotoh: This pull request references Jira Issue OCPBUGS-23399, which is invalid:

expected Jira Issue OCPBUGS-23399 to depend on a bug targeting a version in 4.15.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is essentially a backport of #7683, but with additional code to check the customer-prepared Workspace is good, which 4.15 changes and stops allowing BYO Workspace for GA. Due to more cases to support in 4.14, a little more logic & tests are included in this PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

miyamotoh · 2023-11-17T16:19:48Z

/jira refresh

openshift-ci-robot · 2023-11-17T16:19:53Z

@miyamotoh: This pull request references Jira Issue OCPBUGS-23399, which is invalid:

expected Jira Issue OCPBUGS-23399 to depend on a bug targeting a version in 4.15.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mjturek · 2023-11-17T17:41:27Z

/jira refresh

openshift-ci-robot · 2023-11-17T17:41:32Z

@mjturek: This pull request references Jira Issue OCPBUGS-23399, which is invalid:

expected Jira Issue OCPBUGS-23399 to depend on a bug targeting a version in 4.15.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mjturek · 2023-11-17T17:45:06Z

/jira refresh

openshift-ci-robot · 2023-11-17T17:45:09Z

@mjturek: This pull request references Jira Issue OCPBUGS-23399, which is invalid:

expected Jira Issue OCPBUGS-23399 to depend on a bug targeting a version in 4.15.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mjturek · 2023-11-17T17:47:07Z

/jira refresh

openshift-ci-robot · 2023-11-17T17:47:11Z

@mjturek: This pull request references Jira Issue OCPBUGS-23399, which is invalid:

bug is open, matching expected state (open)
bug target version (4.14.z) matches configured target version for branch (4.14.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
bug has dependents
dependent bug MULTIARCH-3965 is not in the required OCPBUGS project

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mkumatag · 2023-11-28T06:10:43Z

pkg/asset/installconfig/powervs/validation.go

here it says zone but the param name in the package definition says region, good have same name everywhere.

weird! PER enablement is zone specific so I'm a bit surprised at that. For example, dal12 does not currently support PER but dal10 does!

Yeah, the API says it's a region, but when I passed in dal, it didn't work, and I was told by the PowerVS team that I should pass in dal10 (which is a zone), instead. So, there's nothing we can do on our end.

mjturek · 2023-11-28T17:11:06Z

/jira refresh

openshift-ci-robot · 2023-11-28T17:11:10Z

@mjturek: This pull request references Jira Issue OCPBUGS-23399, which is invalid:

expected dependent Jira Issue OCPBUGS-24032 to target a version in 4.15.0, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mjturek · 2023-11-28T17:11:51Z

/jira refresh

openshift-ci-robot · 2023-11-28T17:11:55Z

@mjturek: This pull request references Jira Issue OCPBUGS-23399, which is invalid:

expected dependent Jira Issue OCPBUGS-24032 to target a version in 4.15.0, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mjturek · 2023-11-28T17:13:08Z

/jira refresh

openshift-ci-robot · 2023-11-28T17:13:15Z

@mjturek: This pull request references Jira Issue OCPBUGS-23399, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.z) matches configured target version for branch (4.14.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-24032 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-24032 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
bug has dependents

Requesting review from QA contact:
/cc @gpei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mjturek · 2023-11-28T17:28:16Z

/lgtm

mkumatag · 2023-11-28T17:52:52Z

pkg/asset/installconfig/powervs/client.go

you can do this change to avoid confusion

Suggested change

func (c *Client) GetDatacenterCapabilities(ctx context.Context, region string) (map[string]bool, error) {

func (c *Client) GetDatacenterCapabilities(ctx context.Context, zone string) (map[string]bool, error) {

mjturek · 2023-11-28T20:32:39Z

/remove-lgtm

pkg/asset/installconfig/powervs/client.go

mjturek · 2023-11-28T20:35:05Z

pkg/asset/installconfig/powervs/validation_test.go

This is 4.14 so serviceInstanceID is required.

Good catch, addressed in the latest force-push, though go test doesn't fail either way.

mjturek · 2023-12-01T17:11:03Z

Small change requested but otherwise LGTM

Signed-off-by: Hiro Miyamoto <miyamotoh@us.ibm.com>

openshift-ci · 2023-12-01T23:50:38Z

@miyamotoh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-gcp-ovn-upgrade	`9c7980b`	link	false	`/test okd-scos-e2e-gcp-ovn-upgrade`
ci/prow/okd-scos-e2e-vsphere	`9c7980b`	link	false	`/test okd-scos-e2e-vsphere`
ci/prow/e2e-openstack-nfv-intel	`9c7980b`	link	false	`/test e2e-openstack-nfv-intel`
ci/prow/okd-scos-e2e-gcp	`9c7980b`	link	false	`/test okd-scos-e2e-gcp`
ci/prow/okd-scos-e2e-aws-ovn	`9c7980b`	link	false	`/test okd-scos-e2e-aws-ovn`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

mjturek · 2023-12-02T00:52:24Z

/lgtm

mjturek · 2023-12-02T00:52:42Z

/retest-required

miyamotoh · 2023-12-04T21:47:58Z

@sadasu PTAL and approve.

sadasu · 2023-12-05T19:45:50Z

/approve

sadasu · 2023-12-05T19:46:02Z

/label backport-risk-assessed

sadasu · 2023-12-05T19:46:58Z

@gpei Could you PTAL? This also needs the cherry-pick-approved label.

openshift-ci · 2023-12-05T19:54:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [sadasu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

gpei · 2023-12-06T00:35:31Z

/label cherry-pick-approved

openshift-ci-robot · 2023-12-06T00:39:12Z

@miyamotoh: Jira Issue OCPBUGS-23399: All pull requests linked via external trackers have merged:

openshift/installer#7736

Jira Issue OCPBUGS-23399 has been moved to the MODIFIED state.

Details

In response to this:

This is essentially a backport of #7683, but with additional code to check the customer-prepared Workspace is good, which 4.15 changes and stops allowing BYO Workspace for GA. Due to more cases to support in 4.14, a little more logic & tests are included in this PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2023-12-06T03:15:49Z

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-container-v4.14.0-202312060110.p0.g143dda3.assembly.stream for distgit ose-installer.
All builds following this will include this PR.

openshift-merge-robot · 2023-12-06T14:37:53Z

Fix included in accepted release 4.14.0-0.nightly-2023-12-06-070113

Vendor modules bump to support ValidatePERAvailability

906b87b

Signed-off-by: Hiro Miyamoto <miyamotoh@us.ibm.com>

openshift-ci bot requested review from bfournie and rna-afk November 16, 2023 21:27

miyamotoh force-pushed the check-if-per-enabled-414 branch from da9892f to 0d8e0e6 Compare November 16, 2023 22:18

miyamotoh changed the title ~~Check if PER is enabled in the target PowerVS workspace~~ OCPBUGS-23399: Check if PER is enabled in the target PowerVS workspace Nov 17, 2023

mkumatag suggested changes Nov 28, 2023

View reviewed changes

Karthik-K-N mentioned this pull request Nov 28, 2023

Add command to list regions/zones in account which supports PER ppc64le-cloud/pvsadm#519

Closed

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 28, 2023

openshift-ci bot requested a review from gpei November 28, 2023 17:13

openshift-ci bot assigned mjturek Nov 28, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2023

mkumatag suggested changes Nov 28, 2023

View reviewed changes

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2023

miyamotoh force-pushed the check-if-per-enabled-414 branch from 0d8e0e6 to 8bb86c0 Compare November 29, 2023 02:20

mkumatag suggested changes Nov 29, 2023

View reviewed changes

pkg/asset/installconfig/powervs/client.go Outdated Show resolved Hide resolved

miyamotoh force-pushed the check-if-per-enabled-414 branch from 8bb86c0 to e91465d Compare November 29, 2023 13:30

mjturek reviewed Dec 1, 2023

View reviewed changes

Add ValidatePERAvailability & support logic/test

9c7980b

Signed-off-by: Hiro Miyamoto <miyamotoh@us.ibm.com>

miyamotoh force-pushed the check-if-per-enabled-414 branch from e91465d to 9c7980b Compare December 1, 2023 18:50

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2023

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Dec 5, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2023

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 6, 2023

openshift-merge-bot bot merged commit 143dda3 into openshift:release-4.14 Dec 6, 2023

Karthik-K-N mentioned this pull request May 20, 2024

Refactor IsPowerVSZoneSupportsPER() code to use interface kubernetes-sigs/cluster-api-provider-ibmcloud#1775

Merged

	func (c *Client) GetDatacenterCapabilities(ctx context.Context, region string) (map[string]bool, error) {
	func (c *Client) GetDatacenterCapabilities(ctx context.Context, zone string) (map[string]bool, error) {

Comments

Conversation

miyamotoh commented Nov 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 17, 2023

Uh oh!

miyamotoh commented Nov 17, 2023

Uh oh!

openshift-ci-robot commented Nov 17, 2023

Uh oh!

mjturek commented Nov 17, 2023

Uh oh!

openshift-ci-robot commented Nov 17, 2023

Uh oh!

mjturek commented Nov 17, 2023

Uh oh!

openshift-ci-robot commented Nov 17, 2023

Uh oh!

mjturek commented Nov 17, 2023

Uh oh!

openshift-ci-robot commented Nov 17, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkumatag Nov 28, 2023

Choose a reason for hiding this comment

Uh oh!

mjturek Nov 28, 2023

Choose a reason for hiding this comment

Uh oh!

miyamotoh Nov 28, 2023

Choose a reason for hiding this comment

Uh oh!

mjturek commented Nov 28, 2023

Uh oh!

openshift-ci-robot commented Nov 28, 2023

Uh oh!

mjturek commented Nov 28, 2023

Uh oh!

openshift-ci-robot commented Nov 28, 2023

Uh oh!

mjturek commented Nov 28, 2023

Uh oh!

openshift-ci-robot commented Nov 28, 2023

Uh oh!

mjturek commented Nov 28, 2023

Uh oh!

mkumatag Nov 28, 2023

Choose a reason for hiding this comment

Uh oh!

mjturek commented Nov 28, 2023

Uh oh!

Uh oh!

mjturek Nov 28, 2023

Choose a reason for hiding this comment

Uh oh!

miyamotoh Dec 1, 2023

Choose a reason for hiding this comment

Uh oh!

mjturek commented Dec 1, 2023

Uh oh!

openshift-ci bot commented Dec 1, 2023

Uh oh!

mjturek commented Dec 2, 2023

Uh oh!

mjturek commented Dec 2, 2023

Uh oh!

miyamotoh commented Dec 4, 2023

Uh oh!

sadasu commented Dec 5, 2023

Uh oh!

sadasu commented Dec 5, 2023

Uh oh!

sadasu commented Dec 5, 2023

Uh oh!

openshift-ci bot commented Dec 5, 2023

Uh oh!

gpei commented Dec 6, 2023

Uh oh!

openshift-ci-robot commented Dec 6, 2023

miyamotoh commented Nov 16, 2023 •

edited

Loading

openshift-ci-robot commented Nov 17, 2023 •

edited by openshift-ci bot

Loading