Skip to content

Comments

NO-JIRA: destroy/aws: replaced deprecated sets syntax#7680

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
r4f4:aws-destroy-sets-deprec
Nov 6, 2023
Merged

NO-JIRA: destroy/aws: replaced deprecated sets syntax#7680
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
r4f4:aws-destroy-sets-deprec

Conversation

@r4f4
Copy link
Contributor

@r4f4 r4f4 commented Nov 4, 2023

The new syntax uses Golang generics.

The new syntax uses Golang generics.
@r4f4
Copy link
Contributor Author

r4f4 commented Nov 4, 2023

/cc @barbacbd

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 4, 2023

@r4f4: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-shared-vpc-localzones a7c7cdb link false /test e2e-aws-ovn-shared-vpc-localzones

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@barbacbd barbacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2023
@patrickdillon
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2023
@patrickdillon patrickdillon changed the title destroy/aws: replaced deprecated sets syntax NO-JIRA: destroy/aws: replaced deprecated sets syntax Nov 6, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 6, 2023
@openshift-ci-robot
Copy link
Contributor

@r4f4: This pull request explicitly references no jira issue.

Details

In response to this:

The new syntax uses Golang generics.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@patrickdillon
Copy link
Contributor

/skip

@openshift-merge-bot openshift-merge-bot bot merged commit 9ff8208 into openshift:master Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants