Skip to content

[release-4.14] bootkube.sh: drop final mention of machine-os-content #7669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
openshift-cherrypick-robot wants to merge 1 commit into from
Closed

[release-4.14] bootkube.sh: drop final mention of machine-os-content #7669

openshift-cherrypick-robot wants to merge 1 commit into from

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Nov 2, 2023

This is an automated cherry-pick of #7636

/assign LorbusChris

@jlebon
bootkube.sh: drop final mention of machine-os-content
bd0f35d 
That variable isn't used anywhere. The last reference was removed as
part of 33a74c7 ("bootkube: Drop cruft in MCO bootstrap") a while
ago.

Part of trying to get rid of `machine-os-content`:

https://issues.redhat.com/browse/MCO-392
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 2, 2023
Merged
@openshift-ci openshift-ci bot requested review from patrickdillon and r4f4 November 2, 2023 18:22
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2023

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-ovn-upgrade bd0f35d link false /test okd-e2e-aws-ovn-upgrade
ci/prow/okd-scos-e2e-gcp-ovn-upgrade bd0f35d link false /test okd-scos-e2e-gcp-ovn-upgrade
ci/prow/okd-scos-e2e-gcp bd0f35d link false /test okd-scos-e2e-gcp
ci/prow/e2e-aws-ovn bd0f35d link true /test e2e-aws-ovn
ci/prow/okd-scos-e2e-aws-upgrade bd0f35d link false /test okd-scos-e2e-aws-upgrade
ci/prow/okd-e2e-aws-ovn bd0f35d link false /test okd-e2e-aws-ovn
ci/prow/okd-scos-e2e-vsphere bd0f35d link false /test okd-scos-e2e-vsphere
ci/prow/e2e-aws-ovn-workers-rhel8 bd0f35d link false /test e2e-aws-ovn-workers-rhel8

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

barbacbd
barbacbd reviewed Nov 9, 2023
View reviewed changes
Copy link
Contributor

@barbacbd barbacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2023
@LorbusChris
Copy link
Contributor

LorbusChris commented Nov 13, 2023

/assign @pawanpinjarkar
for approval

@patrickdillon
Copy link
Contributor

patrickdillon commented Nov 13, 2023

/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2023
@gpei
Copy link
Contributor

gpei commented Nov 14, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 14, 2023
@pawanpinjarkar
Copy link
Contributor

pawanpinjarkar commented Nov 20, 2023

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 20, 2023

@pawanpinjarkar: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@r4f4
Copy link
Contributor

r4f4 commented Nov 20, 2023

This will need a Jira ticket on OCPBUGS.

@pawanpinjarkar
Copy link
Contributor

pawanpinjarkar commented Nov 27, 2023

This will need a Jira ticket on OCPBUGS.

@jlebon ☝️

@pawanpinjarkar pawanpinjarkar removed their assignment Nov 27, 2023
@jlebon
Copy link
Member

jlebon commented Nov 27, 2023

@LorbusChris Why did you want to backport this to 4.14?

@LorbusChris
Copy link
Contributor

LorbusChris commented Nov 28, 2023

It looks like this wasn't the last reference to machine-os-content after all, so backporting to 4.14 seems less desirable to me now.
/close

@openshift-ci openshift-ci bot closed this Nov 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 28, 2023

@LorbusChris: Closed this PR.

Details

In response to this:

It looks like this wasn't the last reference to machine-os-content after all, so backporting to 4.14 seems less desirable to me now.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@r4f4 r4f4 Awaiting requested review from r4f4

1 more reviewer

@barbacbd barbacbd barbacbd left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@LorbusChris LorbusChris

@barbacbd barbacbd

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@openshift-cherrypick-robot @LorbusChris @patrickdillon @gpei @pawanpinjarkar @openshift-ci-robot @r4f4 @jlebon @barbacbd