Skip to content

SPLAT-1213: vSphere implement infra provision via sdk#7626

Closed
jcpowermac wants to merge 2 commits intoopenshift:masterfrom
jcpowermac:vsphere-infrastructure
Closed

SPLAT-1213: vSphere implement infra provision via sdk#7626
jcpowermac wants to merge 2 commits intoopenshift:masterfrom
jcpowermac:vsphere-infrastructure

Conversation

@jcpowermac
Copy link
Contributor

@jcpowermac jcpowermac commented Oct 23, 2023

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 23, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign pawanpinjarkar for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

r4f4
r4f4 reviewed Oct 23, 2023
View reviewed changes
@jcpowermac
Copy link
Contributor Author

jcpowermac commented Oct 23, 2023

/test e2e-vsphere-ovn

@jcpowermac
Copy link
Contributor Author

jcpowermac commented Oct 23, 2023

this is currently a mess in a single file, I plan on splitting things out as appropriate

@jcpowermac jcpowermac changed the title vSphere: implement infra provision via sdk SPLAT-1213: vSphere implement infra provision via sdk Oct 23, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 23, 2023 •
edited by openshift-ci bot
Loading

@jcpowermac: This pull request references SPLAT-1213 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 23, 2023
@jcpowermac
Copy link
Contributor Author

jcpowermac commented Oct 23, 2023

/jira-refresh

@jcpowermac
Copy link
Contributor Author

jcpowermac commented Oct 23, 2023

/test e2e-vsphere-ovn

@jcpowermac
Copy link
Contributor Author

jcpowermac commented Oct 24, 2023

now this should install

/test e2e-vsphere-ovn

@rvanderp3 rvanderp3 mentioned this pull request Oct 31, 2023
Closed
3 tasks
@jcpowermac jcpowermac force-pushed the vsphere-infrastructure branch from f783e31 to 76fb661 Compare November 1, 2023 11:30
@jcpowermac
Copy link
Contributor Author

jcpowermac commented Nov 1, 2023

/test e2e-vsphere-ovn

1 similar comment
@jcpowermac
Copy link
Contributor Author

jcpowermac commented Nov 1, 2023

/test e2e-vsphere-ovn

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 2, 2023
@jcpowermac jcpowermac force-pushed the vsphere-infrastructure branch from 9f6d74f to 0709186 Compare November 2, 2023 22:36
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 2, 2023
@jcpowermac
Copy link
Contributor Author

jcpowermac commented Nov 2, 2023

Still need to deal with static ip but major functions are created

/test e2e-vsphere-ovn

@jcpowermac
Copy link
Contributor Author

jcpowermac commented Nov 3, 2023

I think everything is implemented if you want to take an initial look
@vr4manta @rvanderp3

@jcpowermac
Copy link
Contributor Author

jcpowermac commented Nov 3, 2023

/test e2e-vsphere-ovn

2 similar comments
@jcpowermac
Copy link
Contributor Author

jcpowermac commented Nov 3, 2023

/test e2e-vsphere-ovn

@jcpowermac
Copy link
Contributor Author

jcpowermac commented Nov 3, 2023

/test e2e-vsphere-ovn

@jcpowermac
Copy link
Contributor Author

jcpowermac commented Nov 3, 2023

/test ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2023

@jcpowermac: The following commands are available to trigger required jobs:

  • /test agent-integration-tests
  • /test altinfra-images
  • /test aro-unit
  • /test e2e-agent-compact-ipv4
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-upi
  • /test e2e-azure-ovn
  • /test e2e-azure-ovn-upi
  • /test e2e-gcp-ovn
  • /test e2e-gcp-ovn-upi
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-openstack-ovn
  • /test e2e-vsphere-ovn
  • /test e2e-vsphere-upi
  • /test gofmt
  • /test golint
  • /test govet
  • /test images
  • /test okd-images
  • /test okd-scos-images
  • /test okd-unit
  • /test okd-verify-codegen
  • /test openstack-manifests
  • /test shellcheck
  • /test tf-lint
  • /test unit
  • /test verify-codegen
  • /test verify-vendor
  • /test yaml-lint

The following commands are available to trigger optional jobs:

  • /test altinfra-e2e-aws-ovn
  • /test altinfra-e2e-aws-ovn-imdsv2
  • /test altinfra-e2e-aws-ovn-localzones
  • /test altinfra-e2e-aws-ovn-shared-vpc
  • /test altinfra-e2e-aws-ovn-shared-vpc-localzones
  • /test altinfra-e2e-azure-ovn
  • /test altinfra-e2e-azure-ovn-resourcegroup
  • /test altinfra-e2e-azure-ovn-shared-vpc
  • /test e2e-agent-compact-ipv4-appliance
  • /test e2e-agent-compact-ipv4-none-platform
  • /test e2e-agent-ha-dualstack
  • /test e2e-agent-sno-ipv4-pxe
  • /test e2e-agent-sno-ipv6
  • /test e2e-alibaba
  • /test e2e-aws-custom-security-groups
  • /test e2e-aws-ovn-fips
  • /test e2e-aws-ovn-imdsv2
  • /test e2e-aws-ovn-localzones
  • /test e2e-aws-ovn-proxy
  • /test e2e-aws-ovn-public-subnets
  • /test e2e-aws-ovn-shared-vpc
  • /test e2e-aws-ovn-shared-vpc-localzones
  • /test e2e-aws-ovn-single-node
  • /test e2e-aws-ovn-upgrade
  • /test e2e-aws-ovn-workers-rhel8
  • /test e2e-aws-upi-proxy
  • /test e2e-azure-ovn-resourcegroup
  • /test e2e-azure-ovn-shared-vpc
  • /test e2e-azurestack
  • /test e2e-azurestack-upi
  • /test e2e-crc
  • /test e2e-gcp-ovn-shared-vpc
  • /test e2e-gcp-ovn-xpn
  • /test e2e-gcp-secureboot
  • /test e2e-gcp-upgrade
  • /test e2e-gcp-upi-xpn
  • /test e2e-ibmcloud-ovn
  • /test e2e-libvirt
  • /test e2e-metal-assisted
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-sdn
  • /test e2e-metal-ipi-sdn-swapped-hosts
  • /test e2e-metal-ipi-sdn-virtualmedia
  • /test e2e-metal-single-node-live-iso
  • /test e2e-nutanix-ovn
  • /test e2e-nutanix-sdn
  • /test e2e-openstack-ccpmso
  • /test e2e-openstack-ccpmso-zone
  • /test e2e-openstack-dualstack-techpreview
  • /test e2e-openstack-externallb
  • /test e2e-openstack-nfv-intel
  • /test e2e-openstack-proxy
  • /test e2e-openstack-sdn-parallel
  • /test e2e-openstack-upi
  • /test e2e-vsphere-static-ovn
  • /test e2e-vsphere-upi-zones
  • /test e2e-vsphere-zones
  • /test e2e-vsphere-zones-techpreview
  • /test okd-e2e-agent-compact-ipv4
  • /test okd-e2e-agent-ha-dualstack
  • /test okd-e2e-agent-sno-ipv6
  • /test okd-e2e-aws-ovn
  • /test okd-e2e-aws-ovn-upgrade
  • /test okd-e2e-gcp
  • /test okd-e2e-gcp-ovn-upgrade
  • /test okd-e2e-vsphere
  • /test okd-scos-e2e-agent-compact-ipv4
  • /test okd-scos-e2e-agent-sno-ipv6
  • /test okd-scos-e2e-aws-ovn
  • /test okd-scos-e2e-aws-upgrade
  • /test okd-scos-e2e-gcp
  • /test okd-scos-e2e-gcp-ovn-upgrade
  • /test okd-scos-e2e-vsphere
  • /test okd-scos-unit
  • /test okd-scos-verify-codegen
  • /test tf-fmt

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-installer-master-altinfra-images
  • pull-ci-openshift-installer-master-aro-unit
  • pull-ci-openshift-installer-master-e2e-aws-ovn
  • pull-ci-openshift-installer-master-e2e-vsphere-ovn
  • pull-ci-openshift-installer-master-e2e-vsphere-zones
  • pull-ci-openshift-installer-master-e2e-vsphere-zones-techpreview
  • pull-ci-openshift-installer-master-gofmt
  • pull-ci-openshift-installer-master-golint
  • pull-ci-openshift-installer-master-govet
  • pull-ci-openshift-installer-master-images
  • pull-ci-openshift-installer-master-okd-e2e-aws-ovn-upgrade
  • pull-ci-openshift-installer-master-okd-images
  • pull-ci-openshift-installer-master-okd-scos-images
  • pull-ci-openshift-installer-master-okd-scos-unit
  • pull-ci-openshift-installer-master-okd-scos-verify-codegen
  • pull-ci-openshift-installer-master-okd-unit
  • pull-ci-openshift-installer-master-okd-verify-codegen
  • pull-ci-openshift-installer-master-shellcheck
  • pull-ci-openshift-installer-master-tf-fmt
  • pull-ci-openshift-installer-master-tf-lint
  • pull-ci-openshift-installer-master-unit
  • pull-ci-openshift-installer-master-verify-codegen
  • pull-ci-openshift-installer-master-verify-vendor
  • pull-ci-openshift-installer-master-yaml-lint
Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcpowermac
Copy link
Contributor Author

jcpowermac commented Nov 3, 2023

/test e2e-vsphere-static-ovn e2e-vsphere-zones e2e-vsphere-ovn

@rvanderp3
Copy link
Contributor

rvanderp3 commented Nov 3, 2023

I think everything is implemented if you want to take an initial look @vr4manta @rvanderp3

overall LGTM

@jcpowermac
Copy link
Contributor Author

jcpowermac commented Nov 3, 2023

Issue with a vlan in boskos and zones it broke on destroy (can't find the datacenter)

jcpowermac
jcpowermac commented Nov 3, 2023
View reviewed changes
@jcpowermac
Copy link
Contributor Author

jcpowermac commented Nov 10, 2023

/test altinfra-e2e-vsphere-static-ovn
/test altinfra-e2e-vsphere-zones

@jcpowermac jcpowermac force-pushed the vsphere-infrastructure branch from d6084fc to ad723fa Compare November 10, 2023 20:20
@jcpowermac
Copy link
Contributor Author

jcpowermac commented Nov 10, 2023

/test altinfra-e2e-vsphere-ovn

@jcpowermac jcpowermac force-pushed the vsphere-infrastructure branch from ad723fa to 0484c90 Compare November 10, 2023 20:45
@jcpowermac
Copy link
Contributor Author

jcpowermac commented Nov 10, 2023

/test altinfra-e2e-vsphere-ovn

@jcpowermac
Copy link
Contributor Author

jcpowermac commented Nov 10, 2023

/test golint

@jcpowermac
Copy link
Contributor Author

jcpowermac commented Nov 10, 2023

/test images

@jcpowermac
Copy link
Contributor Author

jcpowermac commented Nov 13, 2023

/test altinfra-e2e-vsphere-ovn

@jcpowermac
Copy link
Contributor Author

jcpowermac commented Nov 13, 2023

/test golint

@jcpowermac
Copy link
Contributor Author

jcpowermac commented Nov 13, 2023

/test altinfra-e2e-vsphere-static-ovn
/test altinfra-e2e-vsphere-zones

@jcpowermac
Copy link
Contributor Author

jcpowermac commented Nov 13, 2023

Monitoring is not rolling out - that looks to be causing the cluster not to complete

@jcpowermac
Copy link
Contributor Author

jcpowermac commented Nov 13, 2023

/test altinfra-e2e-vsphere-ovn

@jcpowermac jcpowermac force-pushed the vsphere-infrastructure branch from 0484c90 to a1072f2 Compare November 14, 2023 17:12
@jcpowermac
Copy link
Contributor Author

jcpowermac commented Nov 14, 2023

/test altinfra-e2e-vsphere-ovn

1 similar comment
@jcpowermac
Copy link
Contributor Author

jcpowermac commented Nov 14, 2023

/test altinfra-e2e-vsphere-ovn

@jcpowermac
Copy link
Contributor Author

jcpowermac commented Nov 14, 2023

/test altinfra-e2e-vsphere-static-ovn
/test altinfra-e2e-vsphere-zones

@jcpowermac
Copy link
Contributor Author

jcpowermac commented Nov 15, 2023

/test altinfra-e2e-vsphere-ovn

@jcpowermac
Copy link
Contributor Author

jcpowermac commented Nov 15, 2023

to compare tests
/test e2e-vsphere-ovn

@jcpowermac
Copy link
Contributor Author

jcpowermac commented Nov 15, 2023

using zones to avoid vsan
/test altinfra-e2e-vsphere-zones

@jcpowermac
Copy link
Contributor Author

jcpowermac commented Nov 15, 2023 •
edited
Loading

vSphere vSAN performance in CI environments is causing failures. Manually running e2e is passing

@jcpowermac jcpowermac force-pushed the vsphere-infrastructure branch from f99848f to 3120a38 Compare November 15, 2023 19:05
@jcpowermac
Copy link
Contributor Author

jcpowermac commented Nov 15, 2023

/test altinfra-e2e-vsphere-ovn

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 21, 2023
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Nov 21, 2023

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 14, 2023

@jcpowermac: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/altinfra-e2e-vsphere-static-ovn f99848f611b58dbe02cb3d1f744343cf61841105 link false /test altinfra-e2e-vsphere-static-ovn
ci/prow/okd-images 3120a38 link true /test okd-images
ci/prow/golint 3120a38 link true /test golint
ci/prow/gofmt 3120a38 link true /test gofmt
ci/prow/terraform-verify-vendor 3120a38 link true /test terraform-verify-vendor
ci/prow/terraform-images 3120a38 link true /test terraform-images
ci/prow/e2e-aws-ovn 3120a38 link true /test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jcpowermac
Copy link
Contributor Author

jcpowermac commented Feb 14, 2024

/close

@openshift-ci openshift-ci bot closed this Feb 14, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 14, 2024

@jcpowermac: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@sadasu sadasu Awaiting requested review from sadasu

1 more reviewer

@r4f4 r4f4 r4f4 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jcpowermac @openshift-ci-robot @rvanderp3 @r4f4 @openshift-merge-robot

Comments