Skip to content

Comments

CORS-2831: WIP: PoC: alternate AWS infrastructure provider#7573

Closed
r4f4 wants to merge 31 commits intoopenshift:masterfrom
r4f4:patrick-alt-infra-aws
Closed

CORS-2831: WIP: PoC: alternate AWS infrastructure provider#7573
r4f4 wants to merge 31 commits intoopenshift:masterfrom
r4f4:patrick-alt-infra-aws

Conversation

@r4f4
Copy link
Contributor

@r4f4 r4f4 commented Oct 11, 2023

PR created to test in CI. Not to merge.

patrickdillon and others added 18 commits October 11, 2023 10:07
Introduces an infrastructure package with a stages interface to
allow various infrastructure providers. The stages interface is
based on the existing pkg/terraform/stages interface, but allows
each stage to have its own Provision (and Destroy) function which
can call any infrastructure provider in addition to Terraform.

Currently, the input to the provider is still expecting TFVars,
which the underlying stage provision logic can translate.
Use the existing terraform providers with the infrastructure stages
interface.
Adapts the terraform package to implement the infrastructure/stages
interface. Encapsulates terraform-specific implementation details
in pkg/terraform.
Replaces asset usage of terraform with infrastructure interface.
Implements a build tag strategy to allow producing installer binaries
using an alternate (to terraform) infrastructure provider.

Using build tags we can select different
ProviderForPlatform implementations. Because the altinfra implementation
of that function does not depend on any terraform dependencies, none are
included in the binary.
Co-authored-by: Enxebre <alberto.garcial@hotmail.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@r4f4
Copy link
Contributor Author

r4f4 commented Oct 11, 2023

/test ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2023

@r4f4: The following commands are available to trigger required jobs:

  • /test agent-integration-tests
  • /test altinfra-images
  • /test aro-unit
  • /test e2e-agent-compact-ipv4
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-upi
  • /test e2e-azure-ovn
  • /test e2e-azure-ovn-upi
  • /test e2e-gcp-ovn
  • /test e2e-gcp-ovn-upi
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-openstack-ovn
  • /test e2e-vsphere-ovn
  • /test e2e-vsphere-upi
  • /test gofmt
  • /test golint
  • /test govet
  • /test images
  • /test okd-images
  • /test okd-scos-images
  • /test okd-unit
  • /test okd-verify-codegen
  • /test openstack-manifests
  • /test shellcheck
  • /test tf-lint
  • /test unit
  • /test verify-codegen
  • /test verify-vendor
  • /test yaml-lint

The following commands are available to trigger optional jobs:

  • /test altinfra-e2e-aws-ovn
  • /test altinfra-e2e-aws-ovn-imdsv2
  • /test altinfra-e2e-aws-ovn-localzones
  • /test altinfra-e2e-aws-ovn-shared-vpc
  • /test altinfra-e2e-aws-ovn-shared-vpc-localzones
  • /test altinfra-e2e-azure-ovn
  • /test altinfra-e2e-azure-ovn-resourcegroup
  • /test altinfra-e2e-azure-ovn-shared-vpc
  • /test e2e-agent-compact-ipv4-appliance
  • /test e2e-agent-compact-ipv4-none-platform
  • /test e2e-agent-ha-dualstack
  • /test e2e-agent-sno-ipv4-pxe
  • /test e2e-agent-sno-ipv6
  • /test e2e-alibaba
  • /test e2e-aws-custom-security-groups
  • /test e2e-aws-ovn-disruptive
  • /test e2e-aws-ovn-fips
  • /test e2e-aws-ovn-imdsv2
  • /test e2e-aws-ovn-localzones
  • /test e2e-aws-ovn-proxy
  • /test e2e-aws-ovn-public-subnets
  • /test e2e-aws-ovn-shared-vpc
  • /test e2e-aws-ovn-shared-vpc-localzones
  • /test e2e-aws-ovn-single-node
  • /test e2e-aws-ovn-upgrade
  • /test e2e-aws-ovn-workers-rhel8
  • /test e2e-aws-upi-proxy
  • /test e2e-azure-ovn-resourcegroup
  • /test e2e-azure-ovn-shared-vpc
  • /test e2e-azurestack
  • /test e2e-azurestack-upi
  • /test e2e-crc
  • /test e2e-gcp-ovn-shared-vpc
  • /test e2e-gcp-ovn-xpn
  • /test e2e-gcp-secureboot
  • /test e2e-gcp-upgrade
  • /test e2e-gcp-upi-xpn
  • /test e2e-ibmcloud-ovn
  • /test e2e-libvirt
  • /test e2e-metal-assisted
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-sdn
  • /test e2e-metal-ipi-sdn-swapped-hosts
  • /test e2e-metal-ipi-sdn-virtualmedia
  • /test e2e-metal-single-node-live-iso
  • /test e2e-nutanix-ovn
  • /test e2e-nutanix-sdn
  • /test e2e-openstack-ccpmso
  • /test e2e-openstack-ccpmso-zone
  • /test e2e-openstack-dualstack-techpreview
  • /test e2e-openstack-externallb
  • /test e2e-openstack-nfv-intel
  • /test e2e-openstack-proxy
  • /test e2e-openstack-sdn-parallel
  • /test e2e-openstack-upi
  • /test e2e-vsphere-static-ovn
  • /test e2e-vsphere-upi-zones
  • /test e2e-vsphere-zones
  • /test okd-e2e-agent-compact-ipv4
  • /test okd-e2e-agent-sno-ipv6
  • /test okd-e2e-aws-ovn
  • /test okd-e2e-aws-ovn-upgrade
  • /test okd-e2e-gcp
  • /test okd-e2e-gcp-ovn-upgrade
  • /test okd-e2e-vsphere
  • /test okd-scos-e2e-agent-compact-ipv4
  • /test okd-scos-e2e-agent-sno-ipv6
  • /test okd-scos-e2e-aws-ovn
  • /test okd-scos-e2e-aws-upgrade
  • /test okd-scos-e2e-gcp
  • /test okd-scos-e2e-gcp-ovn-upgrade
  • /test okd-scos-e2e-vsphere
  • /test okd-scos-unit
  • /test okd-scos-verify-codegen
  • /test tf-fmt

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-installer-master-altinfra-images
  • pull-ci-openshift-installer-master-aro-unit
  • pull-ci-openshift-installer-master-e2e-alibaba
  • pull-ci-openshift-installer-master-e2e-aws-custom-security-groups
  • pull-ci-openshift-installer-master-e2e-aws-ovn
  • pull-ci-openshift-installer-master-e2e-aws-ovn-fips
  • pull-ci-openshift-installer-master-e2e-aws-ovn-imdsv2
  • pull-ci-openshift-installer-master-e2e-aws-ovn-localzones
  • pull-ci-openshift-installer-master-e2e-aws-ovn-shared-vpc
  • pull-ci-openshift-installer-master-e2e-aws-ovn-shared-vpc-localzones
  • pull-ci-openshift-installer-master-e2e-aws-ovn-single-node
  • pull-ci-openshift-installer-master-e2e-azure-ovn
  • pull-ci-openshift-installer-master-e2e-azure-ovn-shared-vpc
  • pull-ci-openshift-installer-master-e2e-azurestack
  • pull-ci-openshift-installer-master-e2e-gcp-ovn
  • pull-ci-openshift-installer-master-e2e-gcp-ovn-shared-vpc
  • pull-ci-openshift-installer-master-e2e-gcp-ovn-xpn
  • pull-ci-openshift-installer-master-e2e-gcp-secureboot
  • pull-ci-openshift-installer-master-e2e-ibmcloud-ovn
  • pull-ci-openshift-installer-master-e2e-libvirt
  • pull-ci-openshift-installer-master-e2e-metal-assisted
  • pull-ci-openshift-installer-master-e2e-metal-ipi-ovn-dualstack
  • pull-ci-openshift-installer-master-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-installer-master-e2e-metal-ipi-sdn
  • pull-ci-openshift-installer-master-e2e-metal-ipi-sdn-swapped-hosts
  • pull-ci-openshift-installer-master-e2e-metal-ipi-sdn-virtualmedia
  • pull-ci-openshift-installer-master-e2e-metal-single-node-live-iso
  • pull-ci-openshift-installer-master-e2e-nutanix-ovn
  • pull-ci-openshift-installer-master-e2e-nutanix-sdn
  • pull-ci-openshift-installer-master-e2e-openstack-nfv-intel
  • pull-ci-openshift-installer-master-e2e-openstack-ovn
  • pull-ci-openshift-installer-master-e2e-openstack-proxy
  • pull-ci-openshift-installer-master-e2e-openstack-sdn-parallel
  • pull-ci-openshift-installer-master-e2e-vsphere-ovn
  • pull-ci-openshift-installer-master-e2e-vsphere-zones
  • pull-ci-openshift-installer-master-gofmt
  • pull-ci-openshift-installer-master-golint
  • pull-ci-openshift-installer-master-govet
  • pull-ci-openshift-installer-master-images
  • pull-ci-openshift-installer-master-okd-e2e-aws-ovn
  • pull-ci-openshift-installer-master-okd-e2e-aws-ovn-upgrade
  • pull-ci-openshift-installer-master-okd-images
  • pull-ci-openshift-installer-master-okd-scos-e2e-aws-ovn
  • pull-ci-openshift-installer-master-okd-scos-images
  • pull-ci-openshift-installer-master-okd-scos-unit
  • pull-ci-openshift-installer-master-okd-scos-verify-codegen
  • pull-ci-openshift-installer-master-okd-unit
  • pull-ci-openshift-installer-master-okd-verify-codegen
  • pull-ci-openshift-installer-master-openstack-manifests
  • pull-ci-openshift-installer-master-shellcheck
  • pull-ci-openshift-installer-master-tf-fmt
  • pull-ci-openshift-installer-master-tf-lint
  • pull-ci-openshift-installer-master-unit
  • pull-ci-openshift-installer-master-verify-codegen
  • pull-ci-openshift-installer-master-verify-vendor
  • pull-ci-openshift-installer-master-yaml-lint
Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@r4f4
Copy link
Contributor Author

r4f4 commented Oct 11, 2023

/test altinfra-e2e-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from r4f4. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@r4f4 r4f4 force-pushed the patrick-alt-infra-aws branch from 49dfbe5 to b2dd8d7 Compare October 11, 2023 10:13
@r4f4
Copy link
Contributor Author

r4f4 commented Oct 11, 2023

/test altinfra-e2e-aws-ovn

The altinfra tag does not use the Terraform binaries, so we can skip
building them.
@r4f4
Copy link
Contributor Author

r4f4 commented Oct 11, 2023

/test altinfra-e2e-aws-ovn

@r4f4
Copy link
Contributor Author

r4f4 commented Oct 12, 2023

/test altinfra-e2e-aws-ovn
/test altinfra-e2e-aws-ovn-shared-vpc

@r4f4 r4f4 force-pushed the patrick-alt-infra-aws branch from 6f14032 to 73b1bdc Compare October 15, 2023 15:58
@r4f4
Copy link
Contributor Author

r4f4 commented Oct 15, 2023

/test altinfra-e2e-aws-ovn-shared-vpc

@r4f4
Copy link
Contributor Author

r4f4 commented Oct 15, 2023

/test altinfra-e2e-aws-ovn-shared-vpc

@r4f4 r4f4 force-pushed the patrick-alt-infra-aws branch from c45313e to 9d6e722 Compare October 16, 2023 07:38
@r4f4
Copy link
Contributor Author

r4f4 commented Oct 16, 2023

/test altinfra-e2e-aws-ovn-shared-vpc

@r4f4
Copy link
Contributor Author

r4f4 commented Oct 16, 2023

/test altinfra-e2e-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 16, 2023

@r4f4: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@r4f4
Copy link
Contributor Author

r4f4 commented Oct 18, 2023

/retitle CORS-2831: WIP: PoC: alternate AWS infrastructure provider

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 18, 2023
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title WIP: PoC: alternate AWS infrastructure provider CORS-2831: WIP: PoC: alternate AWS infrastructure provider Oct 18, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 18, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 18, 2023

@r4f4: This pull request references CORS-2831 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.15.0" version, but no target version was set.

Details

In response to this:

PR created to test in CI. Not to merge.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@r4f4
Copy link
Contributor Author

r4f4 commented Nov 3, 2023

/close
in favour of #7676

@openshift-ci openshift-ci bot closed this Nov 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2023

@r4f4: Closed this PR.

Details

In response to this:

/close
in favour of #7676

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants