Skip to content

OSASINFRA-3237: move controlPlanePort API to GA#7570

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
shiftstack:move-controlplaneport-ga
Nov 8, 2023
Merged

OSASINFRA-3237: move controlPlanePort API to GA#7570
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
shiftstack:move-controlplaneport-ga

Conversation

@MaysaMacedo
Copy link
Contributor

@MaysaMacedo MaysaMacedo commented Oct 10, 2023

This API has not moved and there is no plan to make any changes that would be backward incompatible in the future.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 10, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 10, 2023 •
edited by openshift-ci bot
Loading

@MaysaMacedo: This pull request references OSASINFRA-3237 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

Details

In response to this:

This API has not moved and there is no plan to make any changes that would be backward incompatible in the future.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MaysaMacedo
Copy link
Contributor Author

MaysaMacedo commented Oct 10, 2023

/hold
waiting for some initial ack from QE

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2023
@openshift-ci openshift-ci bot requested review from EmilienM and barbacbd October 10, 2023 20:09
@MaysaMacedo
Copy link
Contributor Author

MaysaMacedo commented Oct 16, 2023

/retest

@MaysaMacedo MaysaMacedo force-pushed the move-controlplaneport-ga branch from 362d275 to 2662429 Compare October 16, 2023 17:48
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 16, 2023 •
edited
Loading

@MaysaMacedo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-ovn 266242928d910a4a961e3bec24f760f2d88ff4e9 link false /test okd-e2e-aws-ovn
ci/prow/okd-scos-e2e-aws-ovn 266242928d910a4a961e3bec24f760f2d88ff4e9 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MaysaMacedo
Copy link
Contributor Author

MaysaMacedo commented Oct 17, 2023

/cc @rlobillo @itzikb-redhat
hey guys, when you see we can mark the API related to dual-stack as GA, can you ack on this PR?

@EmilienM
Copy link
Member

EmilienM commented Oct 23, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2023
barbacbd
barbacbd reviewed Oct 27, 2023
View reviewed changes
Copy link
Contributor

@barbacbd barbacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barbacbd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2023
@patrickdillon patrickdillon mentioned this pull request Oct 30, 2023
Merged
@rlobillo
Copy link

rlobillo commented Nov 2, 2023 •
edited
Loading

/lgtm

We will soon be adding 4.15 to our testing and should avoid using the TechPreview flag.

@MaysaMacedo
OSASINFRA-3237: move controlPlanePort API to GA
0d91813 
This API has not moved and there is no plan to make any changes that
would be backward incompatible in the future.
@MaysaMacedo MaysaMacedo force-pushed the move-controlplaneport-ga branch from 2662429 to 0d91813 Compare November 7, 2023 20:19
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2023
@MaysaMacedo
Copy link
Contributor Author

MaysaMacedo commented Nov 7, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2023
@EmilienM
Copy link
Member

EmilienM commented Nov 7, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2023
@MaysaMacedo
Copy link
Contributor Author

MaysaMacedo commented Nov 7, 2023

/retest

@MaysaMacedo
Copy link
Contributor Author

MaysaMacedo commented Nov 7, 2023

/test okd-scos-verify-codegen

@openshift-merge-bot openshift-merge-bot bot merged commit 074baf5 into openshift:master Nov 8, 2023
@MaysaMacedo MaysaMacedo deleted the move-controlplaneport-ga branch November 17, 2023 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EmilienM EmilienM Awaiting requested review from EmilienM

@itzikb-redhat itzikb-redhat Awaiting requested review from itzikb-redhat

@rlobillo rlobillo Awaiting requested review from rlobillo

1 more reviewer

@barbacbd barbacbd barbacbd left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@EmilienM EmilienM

@rlobillo rlobillo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MaysaMacedo @openshift-ci-robot @EmilienM @rlobillo @barbacbd

Comments