Wait for all operators #7525

deads2k · 2023-09-22T20:00:48Z

Bringing back #7289 with a new commit correcting the problem observed in #7318

This reverts commit 017b4f0.

openshift-ci · 2023-09-22T20:01:43Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zaneb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

deads2k · 2023-09-25T17:38:23Z

/payload release-4.15 nightly informing

deads2k · 2023-09-25T17:45:05Z

/payload 4.15 nightly informing

openshift-ci · 2023-09-25T17:47:13Z

@deads2k: trigger 61 job(s) of type informing for the nightly release of OCP 4.15

periodic-ci-openshift-release-master-nightly-4.15-e2e-agent-compact-ipv4
periodic-ci-openshift-release-master-nightly-4.15-e2e-agent-ha-dualstack
periodic-ci-openshift-release-master-nightly-4.15-e2e-agent-sno-ipv6
periodic-ci-openshift-release-master-nightly-4.15-console-aws
periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.15-periodics-e2e-aws
periodic-ci-openshift-release-master-nightly-4.15-e2e-aws-csi
periodic-ci-openshift-release-master-ci-4.15-e2e-aws-ovn
periodic-ci-openshift-release-master-nightly-4.15-e2e-aws-ovn-fips
periodic-ci-openshift-release-master-nightly-4.15-e2e-aws-ovn-single-node
periodic-ci-openshift-release-master-nightly-4.15-e2e-aws-ovn-single-node-serial
periodic-ci-openshift-release-master-nightly-4.15-e2e-aws-sdn
periodic-ci-openshift-release-master-nightly-4.15-e2e-aws-sdn-cgroupsv2
periodic-ci-openshift-release-master-ci-4.15-e2e-aws-sdn-techpreview
periodic-ci-openshift-release-master-ci-4.15-e2e-aws-sdn-techpreview-serial
periodic-ci-openshift-release-master-nightly-4.15-e2e-aws-ovn-upi
periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.15-periodics-e2e-azure
periodic-ci-openshift-release-master-nightly-4.15-e2e-azure-csi
periodic-ci-openshift-release-master-ci-4.15-e2e-azure-ovn
periodic-ci-openshift-release-master-nightly-4.15-e2e-azure-sdn
periodic-ci-openshift-release-master-ci-4.15-e2e-azure-sdn-techpreview
periodic-ci-openshift-release-master-ci-4.15-e2e-azure-sdn-techpreview-serial
periodic-ci-openshift-release-master-ci-4.15-e2e-azure-sdn-upgrade
periodic-ci-openshift-release-master-nightly-4.15-e2e-azure-deploy-cnv
periodic-ci-openshift-release-master-nightly-4.15-e2e-azure-upgrade-cnv
periodic-ci-openshift-release-master-nightly-4.15-e2e-aws-driver-toolkit
periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.15-periodics-e2e-gcp
periodic-ci-openshift-release-master-ci-4.15-e2e-gcp-ovn
periodic-ci-openshift-release-master-nightly-4.15-e2e-gcp-ovn-csi
periodic-ci-openshift-release-master-nightly-4.15-e2e-gcp-ovn-rt
periodic-ci-openshift-release-master-ci-4.15-upgrade-from-stable-4.14-e2e-gcp-ovn-upgrade
periodic-ci-openshift-release-master-nightly-4.15-e2e-gcp-sdn
periodic-ci-openshift-release-master-nightly-4.15-e2e-gcp-sdn-serial
periodic-ci-openshift-release-master-ci-4.15-e2e-gcp-sdn-techpreview
periodic-ci-openshift-release-master-ci-4.15-e2e-gcp-sdn-techpreview-serial
periodic-ci-openshift-release-master-nightly-4.15-e2e-gcp-sdn-upgrade
periodic-ci-openshift-release-master-ci-4.15-upgrade-from-stable-4.14-e2e-gcp-sdn-upgrade
periodic-ci-openshift-release-master-nightly-4.15-e2e-metal-ipi-ovn-dualstack
periodic-ci-openshift-release-master-nightly-4.15-e2e-metal-ipi-sdn-bm-upgrade
periodic-ci-openshift-release-master-nightly-4.15-upgrade-from-stable-4.14-e2e-metal-ipi-sdn-bm-upgrade
periodic-ci-openshift-release-master-nightly-4.15-e2e-metal-ipi-sdn-serial-ipv4
periodic-ci-openshift-release-master-nightly-4.15-e2e-metal-ipi-sdn-serial-virtualmedia-bond
periodic-ci-openshift-release-master-nightly-4.15-e2e-metal-ipi-serial-ovn-ipv6
periodic-ci-openshift-release-master-nightly-4.15-e2e-metal-ipi-serial-ovn-dualstack
periodic-ci-openshift-release-master-nightly-4.15-e2e-metal-ipi-upgrade-ovn-ipv6
periodic-ci-openshift-release-master-nightly-4.15-upgrade-from-stable-4.14-e2e-metal-ipi-upgrade-ovn-ipv6
periodic-ci-openshift-release-master-nightly-4.15-e2e-metal-ovn-assisted
periodic-ci-openshift-osde2e-main-nightly-4.15-osd-aws
periodic-ci-openshift-osde2e-main-nightly-4.15-osd-gcp
periodic-ci-openshift-release-master-nightly-4.15-e2e-aws-ovn-proxy
periodic-ci-openshift-release-master-nightly-4.15-e2e-metal-ovn-single-node-live-iso
periodic-ci-openshift-osde2e-main-nightly-4.15-rosa-classic-sts
periodic-ci-openshift-release-master-nightly-4.15-e2e-aws-sdn-upgrade
periodic-ci-openshift-release-master-nightly-4.15-e2e-telco5g
periodic-ci-openshift-release-master-nightly-4.15-upgrade-from-stable-4.14-e2e-aws-sdn-upgrade
periodic-ci-openshift-release-master-nightly-4.15-e2e-vsphere-ovn-csi
periodic-ci-openshift-release-master-nightly-4.15-e2e-vsphere-ovn-serial
periodic-ci-openshift-release-master-nightly-4.15-e2e-vsphere-ovn-techpreview
periodic-ci-openshift-release-master-nightly-4.15-e2e-vsphere-ovn-techpreview-serial
periodic-ci-openshift-release-master-nightly-4.15-e2e-vsphere-ovn-upi
periodic-ci-openshift-release-master-nightly-4.15-e2e-vsphere-ovn-upi-serial
periodic-ci-openshift-release-master-nightly-4.15-e2e-vsphere-sdn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/43036a10-5bcb-11ee-83f1-8c9021868917-0

deads2k · 2023-09-26T12:18:41Z

cmd/openshift-install/create.go

@r4f4 this part, plus the usage when initializing the replay wrapper should resolve the list, then no updates, problem.

deads2k · 2023-09-26T12:21:16Z

many of the payload runs failed with messages like

{  configuration has 2 errors:

  * images[2]: duplicate image name 'libvirt-installer' (previously defined by field 'base_images[libvirt-installer]')
  * images[3]: duplicate image name 'upi-installer' (previously defined by field 'base_images[upi-installer]')
}

is that normal?

r4f4 · 2023-09-26T12:23:45Z

many of the payload runs failed with messages like

{  configuration has 2 errors:

  * images[2]: duplicate image name 'libvirt-installer' (previously defined by field 'base_images[libvirt-installer]')
  * images[3]: duplicate image name 'upi-installer' (previously defined by field 'base_images[upi-installer]')
}

is that normal?

It seems the payload job is trying to import installer images but the namespace for this PR already has its own built images. Or something like that. Same thing happened last time when I tried to run payload jobs. I'll report to the testplatform team.

deads2k · 2023-09-26T12:47:18Z

It seems the payload job is trying to import installer images but the namespace for this PR already has its own built images. Or something like that. Same thing happened last time when I tried to run payload jobs. I'll report to the testplatform team.

Thanks. That's worth fixing in general, but means we may have to merge based on the data we are able to collect.

r4f4 · 2023-09-26T13:05:09Z

/test e2e-vsphere-ovn
/test e2e-vsphere-zones
/test e2e-gcp-ovn
/test e2e-azure-ovn

r4f4 · 2023-09-27T21:51:15Z

/test e2e-vsphere-ovn
/test e2e-vsphere-zones
/test e2e-gcp-ovn
/test e2e-azure-ovn

openshift-ci · 2023-09-28T02:04:00Z

@deads2k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure-ovn	`a39c931`	link	true	`/test e2e-azure-ovn`
ci/prow/golint	`a39c931`	link	true	`/test golint`
ci/prow/okd-scos-e2e-aws-ovn	`a39c931`	link	false	`/test okd-scos-e2e-aws-ovn`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

deads2k · 2023-09-28T13:57:42Z

closing in favor of #7535

Restore operator stability check from openshift#7289

b809977

This reverts commit 017b4f0.

openshift-ci bot requested review from barbacbd and pawanpinjarkar September 22, 2023 20:01

deads2k commented Sep 26, 2023

View reviewed changes

add lock on top of the result channel to prevent closed channel panic

5d7a118

deads2k force-pushed the wait-for-all-operators branch from 82f3181 to 5d7a118 Compare September 26, 2023 12:54

deads2k added 2 commits September 27, 2023 14:01

add copious logging we should probably remove

bd8f8e0

add bookmark handling to avoid zeroing out our object

a39c931

deads2k mentioned this pull request Sep 27, 2023

Inefficient wait for all clusteroperators #7535

Merged

deads2k closed this Sep 28, 2023

Wait for all operators #7525

Wait for all operators #7525

Uh oh!

Conversation

deads2k commented Sep 22, 2023

Uh oh!

openshift-ci bot commented Sep 22, 2023

Uh oh!

deads2k commented Sep 25, 2023

Uh oh!

deads2k commented Sep 25, 2023

Uh oh!

openshift-ci bot commented Sep 25, 2023

Uh oh!

deads2k Sep 26, 2023

Choose a reason for hiding this comment

Uh oh!

deads2k commented Sep 26, 2023

Uh oh!

r4f4 commented Sep 26, 2023

Uh oh!

deads2k commented Sep 26, 2023

Uh oh!

r4f4 commented Sep 26, 2023

Uh oh!

r4f4 commented Sep 27, 2023

Uh oh!

openshift-ci bot commented Sep 28, 2023

Uh oh!

deads2k commented Sep 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants