Drop legacy cvo overrides

[abhinavdahiya]

No description provided.

[wking]

c422a24 looks good to me. I'm fine landing this PR as it stands if you'd rather sort out the graph issues in follow-up work.

[abhinavdahiya]

Do we want to use asset.Name() here? If not, do we want to drop asset.Name entirely?

asset.Name is human-friendly name for the asset. the graph needs a unique enough name for the node.

[wking]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [abhinavdahiya,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[wking]

/retest

[wking]

e2e-aws:

W1130 07:42:18.873990    9061 metrics_grabber.go:81] Master node is not registered. Grabbing metrics from Scheduler, ControllerManager and ClusterAutoscaler is disabled.
Nov 30 07:42:18.985: INFO: 
Latency metrics for node ip-10-0-43-214.ec2.internal
STEP: Deleting namespaces
Nov 30 07:42:19.024: INFO: namespace : e2e-test-jenkins-pipeline-zqzmw api call to delete is complete 
STEP: Waiting for namespaces to vanish
[AfterEach] [Top Level]
  /tmp/openshift/build-rpms/rpm/BUILD/origin-4.0.0/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/framework/framework.go:142
STEP: Dumping a list of prepulled images on each node...
Nov 30 07:42:27.074: INFO: Waiting up to 3m0s for all (but 100) nodes to be ready
Nov 30 07:42:27.107: INFO: Running AfterSuite actions on all node
Nov 30 07:42:27.107: INFO: Running AfterSuite actions on node 1
fail [github.com/openshift/origin/test/extended/deployments/deployments.go:541]: Expected error:
    <*errors.errorString | 0xc420091570>: {
        s: "timed out waiting for the condition",
    }
    timed out waiting for the condition
not to have occurred

failed: (6m14s) "[Feature:DeploymentConfig] deploymentconfigs with multiple image change triggers [Conformance] should run a successful deployment with a trigger used by different containers [Suite:openshift/conformance/parallel/minimal] [Suite:openshift/smoke-4]"

/retest

[abhinavdahiya]

/retest

[wking]

e2e-aws was bit by the race fixed by #769. I'll kick this again after that lands.

[wking]

#769 landed.

/retest

[wking]

/retest

[openshift-ci-robot]

@abhinavdahiya: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-libvirt	aa1971a	link	/test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.