Skip to content

Fix the deployment on OpenStack for worker pools with no replicas. #7356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 2 commits into from
Jul 23, 2023
Merged

Fix the deployment on OpenStack for worker pools with no replicas. #7356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a574dc
OpenStack: Document rootVolume.type as deprecated
mandre Jul 21, 2023
ff13ec5
OpenStack: Provide default value for openstack_worker_server_group_names
mandre Jul 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions data/data/openstack/variables-openstack.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,7 @@ variable "openstack_master_root_volume_types" {

variable "openstack_worker_server_group_names" {
type = set(string)
default = [""]
description = "Names of the server groups for the worker nodes."
}

Expand Down
2 changes: 1 addition & 1 deletion docs/user/openstack/customization.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ Beyond the [platform-agnostic `install-config.yaml` properties](../customization
* `type` (optional string): The OpenStack flavor name for machines in the pool.
* `rootVolume` (optional object): Defines the root volume for instances in the machine pool. The instances use ephemeral disks if not set.
* `size` (required integer): Size of the root volume in GB. Must be set to at least 25.
* `type` (optional string): The volume pool to create the volume from. It was replaced by `types`.
* `type` (deprectated string): The volume pool to create the volume from. It was replaced by `types`.
* `types` (required list of strings): The volume pool to create the volume from. If compute `zones` are defined with more than one type, the number of zones must match the number of types.
* `zones` (optional list of strings): The names of the availability zones you want to install your root volumes on. If unset, the installer will use your default volume zone.
If compute `zones` contains at least one value, `rootVolume.zones` must also contain at least one value.
Expand Down