images/tectonic-builder/Dockerfile: Drop license-bill-of-materials #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last code consuming this executable was removed in 7296010 (frontend: Remove frontend code and backend API code, 2018-03-06, coreos/tectonic-installer#3067).
openshift-ci-robot
added
size/XS
Member
Author
|
It looks like #69 is removing this directory completely, in which case there's no need to polish its contents ;). |
Member
Author
#69 was closed, and the tectonic-builder images seem to be used in a number of places (e.g. for Travis), so I'm going to re-open this PR. |
openshift-ci-robot
removed
the
needs-ok-to-test
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wking, yifan-gu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
stbenjam
pushed a commit
to stbenjam/installer
that referenced
this pull request
Feb 10, 2021
Use hostIP for ironic containers when provisionig network disabled
clnperez
pushed a commit
to clnperez/installer
that referenced
this pull request
Nov 15, 2021
Signed-off-by: Hiro Miyamoto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last code consuming this executable was removed in 7296010 (coreos/tectonic-installer#3067).