images/tectonic-builder/Dockerfile: Drop stale installer 'rm -rf' #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1a49fbb (Move structure-check tools from Jenkinsfile to builder image, 2017-09-12, coreos/tectonic-installer#1889), added a: RUN go get github.com/s-urbaniak/terraform-examples to this Dockerfile. That package moved into the installer repository, but all we need for generation/testing is the terraform-examples binary, so a68555d (tests/ci: fix dockerfile and remove some layers, 2017-12-19, coreos/tectonic-installer#2600) removed the associated source with: RUN go get github.com/coreos/tectonic-installer/contrib/terraform-examples && \ rm -rf /go/src/github.com/coreos/tectonic-installer/ (i.e. "download github.com/coreos/tectonic-installer/contrib/terraform-examples, build terraform-examples, install it into $GOBIN, and remove the source"). d61abd4 (*: cleanup bazel rules, 2018-03-26, coreos/tectonic-installer#3137) removed the Makefile which had been calling terraform-examples, and 7c73c34 (remove terraform-examples from the tectonic-builder image, 2018-05-18, coreos/tectonic-installer#3239) removed the terraform-examples install from this Dockerfile. With the terraform-examples install removed, Go will no longer be downloading that source, so there's no longer any reason to remove it. This commit removes the unnecessary removal, which should make Dockerfile builds a bit faster and save an empty layer in the resulting images. More importantly, it avoids distracting future devs reading the Dockerfile source ;).
openshift-ci-robot
added
size/XS
wking
force-pushed
the
tectonic-builder-drop-installer-remove
branch
from
09baaa5 to
315bd67
Compare
Member
Author
|
It looks like #69 is removing this directory completely, in which case there's no need to polish its contents ;). |
Member
Author
#69 was closed, and the tectonic-builder images seem to be used in a number of places (e.g. for Travis), so I'm going to re-open this PR. |
openshift-ci-robot
removed
the
needs-ok-to-test
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wking, yifan-gu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
stbenjam
pushed a commit
to stbenjam/installer
that referenced
this pull request
Feb 10, 2021
Enable Deployment updates
miyamotoh
pushed a commit
to miyamotoh/installer
that referenced
this pull request
Nov 12, 2021
manual upstream merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1a49fbb (coreos/tectonic-installer#1889), added a:
RUN go get github.com/s-urbaniak/terraform-examplesto this
Dockerfile. That package moved into the installer repository, but all we need for generation/testing is theterraform-examplesbinary, so a68555d (coreos/tectonic-installer#2600) removed the associated source with:RUN go get github.com/coreos/tectonic-installer/contrib/terraform-examples && \ rm -rf /go/src/github.com/coreos/tectonic-installer/(i.e. "download github.com/coreos/tectonic-installer/contrib/terraform-examples, build
terraform-examples, install it into$GOBIN, and remove the source").d61abd4 (coreos/tectonic-installer#3137) removed the
Makefilewhich had been callingterraform-examples, and 7c73c34 (coreos/tectonic-installer#3239) removed theterraform-examplesinstall from thisDockerfile. With theterraform-examplesinstall removed, Go will no longer be downloading that source, so there's no longer any reason to remove it. This commit removes the unnecessary removal, which should makeDockerfilebuilds a bit faster and save an empty layer in the resulting images. More importantly, it avoids distracting future devs reading theDockerfilesource ;).