OSASINFRA-3155 - OpenStack: Create ControlPlaneMachineSet CRDs by EmilienM · Pull Request #7136 · openshift/installer

EmilienM · 2023-04-26T18:48:49Z

vendoring
OSASINFRA-3155 - OpenStack: Create ControlPlaneMachineSet CRDs

EmilienM · 2023-04-26T18:49:43Z

/assign pierreprinetti
/cc damdo mdbooth

EmilienM · 2023-04-26T19:01:16Z

/hold we need the API patch to merge first

pkg/asset/machines/openstack/machines.go

Co-Authored-By: Emilien Macchi <emilien@redhat.com> Co-Authored-By: Pierre Prinetti <pprinett@redhat.com>

pierreprinetti · 2023-06-07T09:34:24Z

/uncc pierreprinetti JoelSpeed damdo mdbooth AnnaZivkovic mandre

JoelSpeed · 2023-06-07T10:45:07Z

It would be useful to post a generated CPMS into the conversation here to review

openshift-ci · 2023-06-23T14:12:55Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jhixson74 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-merge-robot · 2023-06-23T14:20:37Z

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-06-23T14:24:12Z

@EmilienM: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-ovn	b2bc0c3debf45ef790c839bba5a3f4e22b40823e	link	true	`/test e2e-gcp-ovn`
ci/prow/e2e-gcp-secureboot	b2bc0c3debf45ef790c839bba5a3f4e22b40823e	link	false	`/test e2e-gcp-secureboot`
ci/prow/e2e-gcp-ovn-shared-vpc	b2bc0c3debf45ef790c839bba5a3f4e22b40823e	link	false	`/test e2e-gcp-ovn-shared-vpc`
ci/prow/e2e-gcp-ovn-xpn	b2bc0c3debf45ef790c839bba5a3f4e22b40823e	link	false	`/test e2e-gcp-ovn-xpn`
ci/prow/e2e-openstack-ovn	`ac9fcaa`	link	true	`/test e2e-openstack-ovn`
ci/prow/yaml-lint	`ac9fcaa`	link	true	`/test yaml-lint`
ci/prow/aro-unit	`ac9fcaa`	link	true	`/test aro-unit`
ci/prow/e2e-openstack-kuryr	`ac9fcaa`	link	false	`/test e2e-openstack-kuryr`
ci/prow/unit	`ac9fcaa`	link	true	`/test unit`
ci/prow/tf-lint	`ac9fcaa`	link	true	`/test tf-lint`
ci/prow/okd-e2e-aws-ovn	`ac9fcaa`	link	false	`/test okd-e2e-aws-ovn`
ci/prow/govet	`ac9fcaa`	link	true	`/test govet`
ci/prow/okd-scos-verify-codegen	`ac9fcaa`	link	false	`/test okd-scos-verify-codegen`
ci/prow/images	`ac9fcaa`	link	true	`/test images`
ci/prow/golint	`ac9fcaa`	link	true	`/test golint`
ci/prow/gofmt	`ac9fcaa`	link	true	`/test gofmt`
ci/prow/tf-fmt	`ac9fcaa`	link	false	`/test tf-fmt`
ci/prow/e2e-agent-ha-dualstack	`ac9fcaa`	link	false	`/test e2e-agent-ha-dualstack`
ci/prow/e2e-openstack-proxy	`ac9fcaa`	link	false	`/test e2e-openstack-proxy`
ci/prow/okd-verify-codegen	`ac9fcaa`	link	true	`/test okd-verify-codegen`
ci/prow/okd-images	`ac9fcaa`	link	true	`/test okd-images`
ci/prow/okd-unit	`ac9fcaa`	link	true	`/test okd-unit`
ci/prow/okd-e2e-aws-ovn-upgrade	`ac9fcaa`	link	false	`/test okd-e2e-aws-ovn-upgrade`
ci/prow/okd-scos-e2e-aws-ovn	`ac9fcaa`	link	false	`/test okd-scos-e2e-aws-ovn`
ci/prow/e2e-openstack-sdn-parallel	`ac9fcaa`	link	false	`/test e2e-openstack-sdn-parallel`
ci/prow/verify-vendor	`ac9fcaa`	link	true	`/test verify-vendor`
ci/prow/e2e-aws-ovn	`ac9fcaa`	link	true	`/test e2e-aws-ovn`
ci/prow/openstack-manifests	`ac9fcaa`	link	true	`/test openstack-manifests`
ci/prow/shellcheck	`ac9fcaa`	link	true	`/test shellcheck`
ci/prow/okd-scos-unit	`ac9fcaa`	link	false	`/test okd-scos-unit`
ci/prow/verify-codegen	`ac9fcaa`	link	true	`/test verify-codegen`
ci/prow/okd-scos-images	`ac9fcaa`	link	true	`/test okd-scos-images`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

pierreprinetti · 2023-06-23T15:06:49Z

I have rebased onto master in a separate branch to make comparing easier: #7280

pierreprinetti · 2023-06-26T13:03:52Z

/close
in favour of #7280

openshift-ci · 2023-06-26T13:14:43Z

@pierreprinetti: Closed this PR.

Details

In response to this:

/close
in favour of #7280

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from AnnaZivkovic, damdo, mandre and mdbooth April 26, 2023 18:49

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2023

EmilienM commented Apr 26, 2023

View reviewed changes

pkg/asset/machines/openstack/machines.go Outdated Show resolved Hide resolved

EmilienM force-pushed the ccpmso_osp branch from 8cb521a to ecdc4d2 Compare April 26, 2023 19:29

EmilienM force-pushed the ccpmso_osp branch from ecdc4d2 to 9845541 Compare May 8, 2023 12:50

pierreprinetti reviewed May 8, 2023

View reviewed changes

pkg/asset/machines/openstack/machines.go Outdated Show resolved Hide resolved

EmilienM force-pushed the ccpmso_osp branch from 5abf8a9 to 7180965 Compare May 8, 2023 14:48

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 8, 2023

EmilienM force-pushed the ccpmso_osp branch from 2ddc021 to 4012c83 Compare May 8, 2023 19:23

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 8, 2023

EmilienM force-pushed the ccpmso_osp branch from 4012c83 to b2bc0c3 Compare May 9, 2023 19:24

EmilienM mentioned this pull request May 31, 2023

OSASINFRA-3133 - OpenStack support openshift/cluster-control-plane-machine-set-operator#195

Merged

EmilienM and others added 3 commits June 7, 2023 11:32

vendoring

fb7339e

OSASINFRA-3155 - OpenStack: Create ControlPlaneMachineSet CRDs

e085072

Co-Authored-By: Emilien Macchi <emilien@redhat.com> Co-Authored-By: Pierre Prinetti <pprinett@redhat.com>

Activate CPMS by default on new installs

ac9fcaa

pierreprinetti force-pushed the ccpmso_osp branch from b2bc0c3 to ac9fcaa Compare June 7, 2023 09:33

openshift-ci bot removed request for AnnaZivkovic, damdo, mandre and mdbooth June 7, 2023 09:34

pierreprinetti force-pushed the ccpmso_osp branch from ac9fcaa to 16bfd94 Compare June 23, 2023 14:06

pierreprinetti force-pushed the ccpmso_osp branch from 16bfd94 to ac9fcaa Compare June 23, 2023 14:20

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 23, 2023

openshift-ci bot closed this Jun 26, 2023

pierreprinetti deleted the ccpmso_osp branch June 26, 2023 14:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OSASINFRA-3155 - OpenStack: Create ControlPlaneMachineSet CRDs#7136

OSASINFRA-3155 - OpenStack: Create ControlPlaneMachineSet CRDs#7136
EmilienM wants to merge 3 commits intoopenshift:masterfrom
shiftstack:ccpmso_osp

EmilienM commented Apr 26, 2023 •

edited by openshift-ci bot

Loading

Uh oh!

EmilienM commented Apr 26, 2023 •

edited

Loading

Uh oh!

EmilienM commented Apr 26, 2023

Uh oh!

Uh oh!

Uh oh!

pierreprinetti commented Jun 7, 2023

Uh oh!

JoelSpeed commented Jun 7, 2023

Uh oh!

openshift-ci bot commented Jun 23, 2023

Uh oh!

openshift-merge-robot commented Jun 23, 2023

Uh oh!

openshift-ci bot commented Jun 23, 2023

Uh oh!

pierreprinetti commented Jun 23, 2023 •

edited

Loading

Uh oh!

pierreprinetti commented Jun 26, 2023

Uh oh!

openshift-ci bot commented Jun 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

EmilienM commented Apr 26, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

EmilienM commented Apr 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

EmilienM commented Apr 26, 2023

Uh oh!

Uh oh!

Uh oh!

pierreprinetti commented Jun 7, 2023

Uh oh!

JoelSpeed commented Jun 7, 2023

Uh oh!

openshift-ci bot commented Jun 23, 2023

Uh oh!

openshift-merge-robot commented Jun 23, 2023

Uh oh!

openshift-ci bot commented Jun 23, 2023

Uh oh!

pierreprinetti commented Jun 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pierreprinetti commented Jun 26, 2023

Uh oh!

openshift-ci bot commented Jun 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

EmilienM commented Apr 26, 2023 •

edited by openshift-ci bot

Loading

EmilienM commented Apr 26, 2023 •

edited

Loading

pierreprinetti commented Jun 23, 2023 •

edited

Loading