Skip to content

Conversation

@vrutkovs
Copy link
Contributor

@vrutkovs vrutkovs commented Feb 27, 2023

If TAGS env var contains "fcos" (its an alias to OKD) CoreOS manifest script should use
FCOS json. This is necessary for OKD clusters to be installable via
Hypershift

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Feb 27, 2023
@openshift-ci-robot
Copy link
Contributor

@vrutkovs: This pull request references Jira Issue OCPBUGS-7993, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

If TAGS env var contains "okd" CoreOS manifest script should use
FCOS json. This is necessary for OKD clusters to be installable via
Hypershift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@vrutkovs: This pull request references Jira Issue OCPBUGS-7993, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

Details

In response to this:

If TAGS env var contains "fcos" (its an alias to OKD) CoreOS manifest script should use
FCOS json. This is necessary for OKD clusters to be installable via
Hypershift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

If TAGS env var contains "okd" CoreOS manifest script should use
FCOS json. This is necessary for OKD clusters to be installable via
Hypershift
Copy link
Contributor

@LorbusChris LorbusChris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2023
@LorbusChris
Copy link
Contributor

/assign @sadasu

@vrutkovs
Copy link
Contributor Author

/retest

1 similar comment
@LorbusChris
Copy link
Contributor

/retest

@patrickdillon
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LorbusChris, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

@vrutkovs: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 580f030 into openshift:master Feb 28, 2023
@openshift-ci-robot
Copy link
Contributor

@vrutkovs: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-7993 has been moved to the MODIFIED state.

Details

In response to this:

If TAGS env var contains "fcos" (its an alias to OKD) CoreOS manifest script should use
FCOS json. This is necessary for OKD clusters to be installable via
Hypershift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs
Copy link
Contributor Author

/cherrypick release-4.12

@openshift-cherrypick-robot

@vrutkovs: #6906 failed to apply on top of branch "release-4.12":

Applying: hack/build-coreos-manifest: support OKD
Using index info to reconstruct a base tree...
M	hack/build-coreos-manifest.go
Falling back to patching base and 3-way merge...
Auto-merging hack/build-coreos-manifest.go
CONFLICT (content): Merge conflict in hack/build-coreos-manifest.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 hack/build-coreos-manifest: support OKD
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs
Copy link
Contributor Author

/jira cherrypick OCPBUGS-7993

@openshift-ci-robot
Copy link
Contributor

@vrutkovs: Jira Issue OCPBUGS-7993 has been cloned as Jira Issue OCPBUGS-8018. Retitling PR to link against new bug.
/retitle OCPBUGS-8018: OCPBUGS-7993: hack/build-coreos-manifest: support OKD

Details

In response to this:

/jira cherrypick OCPBUGS-7993

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title OCPBUGS-7993: hack/build-coreos-manifest: support OKD OCPBUGS-8018: OCPBUGS-7993: hack/build-coreos-manifest: support OKD Feb 28, 2023
@openshift-ci-robot
Copy link
Contributor

@vrutkovs: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-8018 has been moved to the MODIFIED state.

Details

In response to this:

If TAGS env var contains "fcos" (its an alias to OKD) CoreOS manifest script should use
FCOS json. This is necessary for OKD clusters to be installable via
Hypershift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs vrutkovs changed the title OCPBUGS-8018: OCPBUGS-7993: hack/build-coreos-manifest: support OKD OCPBUGS-7993: hack/build-coreos-manifest: support OKD Feb 28, 2023
@openshift-ci-robot
Copy link
Contributor

@vrutkovs: Jira Issue OCPBUGS-7993 is in an unrecognized state (Closed) and will not be moved to the MODIFIED state.

Details

In response to this:

If TAGS env var contains "fcos" (its an alias to OKD) CoreOS manifest script should use
FCOS json. This is necessary for OKD clusters to be installable via
Hypershift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants