-
Notifications
You must be signed in to change notification settings - Fork 1.5k
OCPBUGS-7993: hack/build-coreos-manifest: support OKD #6906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-7993: hack/build-coreos-manifest: support OKD #6906
Conversation
|
@vrutkovs: This pull request references Jira Issue OCPBUGS-7993, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1d8f7ed to
e82aa4b
Compare
|
@vrutkovs: This pull request references Jira Issue OCPBUGS-7993, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
If TAGS env var contains "okd" CoreOS manifest script should use FCOS json. This is necessary for OKD clusters to be installable via Hypershift
e82aa4b to
8db73f5
Compare
LorbusChris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/assign @sadasu |
|
/retest |
1 similar comment
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LorbusChris, patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@vrutkovs: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@vrutkovs: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-7993 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-4.12 |
|
@vrutkovs: #6906 failed to apply on top of branch "release-4.12": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira cherrypick OCPBUGS-7993 |
|
@vrutkovs: Jira Issue OCPBUGS-7993 has been cloned as Jira Issue OCPBUGS-8018. Retitling PR to link against new bug. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@vrutkovs: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-8018 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@vrutkovs: Jira Issue OCPBUGS-7993 is in an unrecognized state (Closed) and will not be moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
If TAGS env var contains "fcos" (its an alias to OKD) CoreOS manifest script should use
FCOS json. This is necessary for OKD clusters to be installable via
Hypershift