linter: enable reporting about exported names lacking comments #6880
Conversation
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
pkg/validate/method.go
Outdated
There was a problem hiding this comment.
This will conflict with my PR that deletes this code altogether, but if that's the price of stopping the bleeding I am ok with it :)
There was a problem hiding this comment.
I can also rebase this if you prefer that your PR gets merged first.
r4f4
force-pushed
the
golint-enable-godoc-exported
branch
3 times, most recently
from
3fd54cb to
afcf24e
Compare
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
barbacbd
left a comment
barbacbd
left a comment
There was a problem hiding this comment.
/lgtm
Have we decided what to do with Zane's comments?
|
Go ahead, I can rebase |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sadasu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required Remaining retests: 0 against base HEAD bb7e59b and 2 for PR HEAD afcf24e8664f4aa6c5514dcf197a484399ac7d9f in total |
|
/retest-required Remaining retests: 0 against base HEAD ed246d2 and 1 for PR HEAD afcf24e8664f4aa6c5514dcf197a484399ac7d9f in total |
|
/retest-required Remaining retests: 0 against base HEAD 0a0721d and 0 for PR HEAD afcf24e8664f4aa6c5514dcf197a484399ac7d9f in total |
|
/hold Revision afcf24e8664f4aa6c5514dcf197a484399ac7d9f was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
This type of reporting is disabled by default in golangci-lint. However, we used to enforce it when using golang/lint and I think it's useful to have.
r4f4
force-pushed
the
golint-enable-godoc-exported
branch
from
afcf24e to
bac8413
Compare
|
Rebased to fix newly introduced pkg/types/vsphere/conversion/installconfig.go:15:1: exported: exported function ConvertInstallConfig should have comment or be unexported (revive)
func ConvertInstallConfig(config *types.InstallConfig) error {
^ |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/override ci/prow/e2e-vsphere-ovn |
|
@r4f4: Overrode contexts on behalf of r4f4: ci/prow/e2e-vsphere-ovn DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@r4f4: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
6 participants
This type of reporting is disabled by default in golangci-lint. However, we used to enforce it when using golang/lint and I think it's useful to have.