Skip to content

[release-4.12] OCPBUGS-7400: Check for AWS STS installation before trying to get all IAM Roles #6847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
openshift-cherrypick-robot wants to merge 1 commit into from
Closed

[release-4.12] OCPBUGS-7400: Check for AWS STS installation before trying to get all IAM Roles #6847

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions pkg/destroy/aws/iamhelpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ import (
"k8s.io/apimachinery/pkg/util/sets"
)

const (
ErrCodeAccessDeniedException = "AccessDeniedException"
)

type iamRoleSearch struct {
client *iam.IAM
filters []Filter
Expand All @@ -39,13 +43,21 @@ func (search *iamRoleSearch) find(ctx context.Context) (arns []string, names []s
// Unfortunately role.Tags is empty from ListRoles, so we need to query each one
response, err := search.client.GetRoleWithContext(ctx, &iam.GetRoleInput{RoleName: role.RoleName})
if err != nil {
if err.(awserr.Error).Code() == iam.ErrCodeNoSuchEntityException {
search.unmatched[*role.Arn] = exists
} else {
if lastError != nil {
search.logger.Debug(lastError)
var awsErr awserr.Error
if errors.As(err, &awsErr) {
switch awsErr.Code() {
case ErrCodeAccessDeniedException, iam.ErrCodeNoSuchEntityException:
// Installer does not have access to this IAM role or the
// the role does not exist.
// Ignore this IAM Role and donot report this error via
// lastError
search.unmatched[*role.Arn] = exists
default:
if lastError != nil {
search.logger.Debug(lastError)
}
lastError = errors.Wrapf(err, "get tags for %s", *role.Arn)
}
lastError = errors.Wrapf(err, "get tags for %s", *role.Arn)
}
} else {
role = response.Role
Expand Down