OCPBUGS-6270: Don't require vSphere details for agent installer #6793
Conversation
Don't compare pointers, as they will never be equal. Check for non-nil pointers and then compare values.
openshift-ci-robot
added
jira/valid-reference
|
@zaneb: This pull request references Jira Issue OCPBUGS-6270, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
rwsu
left a comment
rwsu
left a comment
There was a problem hiding this comment.
I verified that it does fix the issue where vSphere details are not provided.
It stuck me that we should add an integration test for this particular vsphere scenario. Here's an example of one we have for the base baremetal compact cluster case: 55d450a#diff-400e139b300a043192bc206f891ccf2742aa78301b9a31147fd62bfc519981b3
What do you think?
Copy the same fix as for the baremetal platform (OCPBUGS-3278) to vSphere to prevent validation of the presence of fields in the install-config that are, in fact, ignored by the agent installer.
zaneb
force-pushed
the
skip-vsphere-platform-validations
branch
from
7fb1fbe to
e3bd70c
Compare
|
/cherry-pick release-4.12 |
|
@zaneb: once the present PR merges, I will cherry-pick it on top of release-4.12 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
/assign @jhixson74 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhixson74 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@zaneb: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@zaneb: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-6270 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@zaneb: new pull request created: #6826 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8 participants
Copy the same fix as for the baremetal platform (OCPBUGS-3278) to
vSphere to prevent validation of the presence of fields in the
install-config that are, in fact, ignored by the agent installer.