Skip to content

OCPBUGS-5770: CVE-2021-4238: goutils: update for randomness fix #6763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 9 commits into from
Jan 13, 2023
Merged

OCPBUGS-5770: CVE-2021-4238: goutils: update for randomness fix #6763

openshift-merge-robot merged 9 commits into from
Jan 13, 2023

Conversation

@r4f4
Copy link
Contributor

@r4f4 r4f4 commented Jan 11, 2023

A flaw was found in goutils where randomly generated alphanumeric
strings contain significantly less entropy than expected. Both the
RandomAlphaNumeric and CryptoRandomAlphaNumeric functions always
return strings containing at least one digit from 0 to 9. This issue
significantly reduces the amount of entropy generated in short strings
by these functions.

@openshift-ci openshift-ci bot requested review from bostrt and jcpowermac January 11, 2023 18:42
@r4f4
Copy link
Contributor Author

r4f4 commented Jan 12, 2023

/retitle OCPBUGS-5770: CVE-2021-4238: goutils: update for randomness fix

@openshift-ci openshift-ci bot changed the title CVE-2021-4238: goutils: update for randomness fix OCPBUGS-5770: CVE-2021-4238: goutils: update for randomness fix Jan 12, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 12, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 12, 2023

@r4f4: This pull request references Jira Issue OCPBUGS-5770, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

A flaw was found in goutils where randomly generated alphanumeric
strings contain significantly less entropy than expected. Both the
RandomAlphaNumeric and CryptoRandomAlphaNumeric functions always
return strings containing at least one digit from 0 to 9. This issue
significantly reduces the amount of entropy generated in short strings
by these functions.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gpei January 12, 2023 09:06
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 12, 2023
r4f4 added 9 commits January 12, 2023 14:58
@r4f4
CVE-2021-4238: goutils: update for randomness fix
005048f 
A flaw was found in goutils where randomly generated alphanumeric
strings contain significantly less entropy than expected. Both the
`RandomAlphaNumeric` and `CryptoRandomAlphaNumeric` functions always
return strings containing at least one digit from 0 to 9. This issue
significantly reduces the amount of entropy generated in short strings
by these functions.
@r4f4
terraform: bump goutils for CVE fix
96ca171
@r4f4
terraform: alicloud: bump goutils for CVE fix
c118a2c
@r4f4
terraform: google: bump goutils for CVE fix
89b0081
@r4f4
terraform: nutanix: bump goutils for CVE fix
aacbc1e
@r4f4
terraform: openstack: bump goutils for CVE fix
3c70ac6
@r4f4
terraform: time: bump goutils for CVE fix
d38ca3e
@r4f4
terraform: vsphere: bump goutils for CVE fix
fad9285
@r4f4
terraform: vsphereprivate: bump goutils for CVE fix
99e9851
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 12, 2023
@r4f4
Copy link
Contributor Author

r4f4 commented Jan 12, 2023

Rebased to fix merge conflicts.

@r4f4 r4f4 mentioned this pull request Jan 12, 2023
Merged
@patrickdillon
Copy link
Contributor

patrickdillon commented Jan 12, 2023

/approve
/lgtm
/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 13, 2023

/retest-required

Remaining retests: 0 against base HEAD 8c83507 and 2 for PR HEAD 99e9851 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 13, 2023

/retest-required

Remaining retests: 0 against base HEAD 960ebcf and 1 for PR HEAD 99e9851 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 13, 2023

@r4f4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-ovn-upgrade 99e9851 link false /test okd-e2e-aws-ovn-upgrade
ci/prow/okd-e2e-aws-ovn 99e9851 link false /test okd-e2e-aws-ovn
ci/prow/e2e-openstack-sdn-parallel 99e9851 link false /test e2e-openstack-sdn-parallel
ci/prow/e2e-aws-ovn-disruptive 99e9851 link false /test e2e-aws-ovn-disruptive
ci/prow/e2e-openstack-proxy 99e9851 link false /test e2e-openstack-proxy
ci/prow/okd-scos-e2e-aws-ovn 99e9851 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-alibaba 99e9851 link false /test e2e-alibaba
ci/prow/okd-scos-e2e-aws-upgrade 99e9851 link false /test okd-scos-e2e-aws-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 26a3caa into openshift:master Jan 13, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 13, 2023

@r4f4: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-5770 has been moved to the MODIFIED state.

Details

In response to this:

A flaw was found in goutils where randomly generated alphanumeric
strings contain significantly less entropy than expected. Both the
RandomAlphaNumeric and CryptoRandomAlphaNumeric functions always
return strings containing at least one digit from 0 to 9. This issue
significantly reduces the amount of entropy generated in short strings
by these functions.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bostrt bostrt Awaiting requested review from bostrt

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

@gpei gpei Awaiting requested review from gpei

Assignees

@patrickdillon patrickdillon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@r4f4 @openshift-ci-robot @patrickdillon @openshift-merge-robot