[release-4.12] OCPBUGS-5764: Expose Azure useImageGallery parameter in the MachineSets() call #6753

openshift-cherrypick-robot · 2023-01-09T18:55:39Z

This is an automated cherry-pick of #6737

/assign patrickdillon

This allows end-users of the MachineSets() function to choose whether they want to use the image gallery or not (<=4.11 vs >=4.12). Additionally, the unused parameter rhcosVerison has been removed, and a variable has been shadowed to appease the golint CI check. See openshift#6694 for more details concerning why this change is necessary.

openshift-ci · 2023-01-10T02:45:46Z

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-upgrade	`b018f73`	link	false	`/test okd-scos-e2e-aws-upgrade`
ci/prow/e2e-crc	`b018f73`	link	false	`/test e2e-crc`
ci/prow/okd-e2e-aws-ovn-upgrade	`b018f73`	link	false	`/test okd-e2e-aws-ovn-upgrade`
ci/prow/okd-scos-e2e-aws-ovn	`b018f73`	link	false	`/test okd-scos-e2e-aws-ovn`
ci/prow/e2e-libvirt	`b018f73`	link	false	`/test e2e-libvirt`
ci/prow/e2e-aws-ovn-disruptive	`b018f73`	link	false	`/test e2e-aws-ovn-disruptive`
ci/prow/e2e-azurestack	`b018f73`	link	false	`/test e2e-azurestack`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

r4f4 · 2023-01-10T11:33:18Z

/lgtm

patrickdillon · 2023-01-10T16:36:07Z

/approve
/label backport-risk-assessed

openshift-ci · 2023-01-10T16:36:59Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

newtonheath · 2023-01-10T18:37:01Z

@patrickdillon what do we need to do to move this along?

r4f4 · 2023-01-10T18:40:51Z

@newtonheath it looks like it needs a bug linked to it and QE to stamp it with cherry-pick-approved.

dlom · 2023-01-11T20:46:31Z

/retitle [release-4.12] CORS-2473: Expose Azure useImageGallery parameter in the MachineSets() call

dlom · 2023-01-11T20:50:00Z

/bugzilla refresh

openshift-ci · 2023-01-11T20:50:17Z

@dlom: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

r4f4 · 2023-01-11T22:31:28Z

/retitle [release-4.12] OCPBUGS-5764: Expose Azure useImageGallery parameter in the MachineSets() call

r4f4 · 2023-01-11T22:32:48Z

/jira refresh

openshift-ci · 2023-01-11T22:32:51Z

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.12] OCPBUGS-5764: Expose Azure useImageGallery parameter in the MachineSets() call

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-01-11T22:33:21Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-5764, which is invalid:

expected Jira Issue OCPBUGS-5764 to depend on a bug targeting a version in 4.13.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #6737

/assign patrickdillon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-01-11T22:33:23Z

@r4f4: This pull request references Jira Issue OCPBUGS-5764, which is invalid:

expected Jira Issue OCPBUGS-5764 to depend on a bug targeting a version in 4.13.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

r4f4 · 2023-01-11T22:35:19Z

/jira refresh

openshift-ci-robot · 2023-01-11T22:35:26Z

@r4f4: This pull request references Jira Issue OCPBUGS-5764, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.12.0) matches configured target version for branch (4.12.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-5763 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-5763 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
bug has dependents

Requesting review from QA contact:
/cc @gpei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

r4f4 · 2023-01-11T22:36:19Z

@gpei This is an internal changed needed by the Hive team. No need for QE to test it but we still need the cherry-pick-approved label.

gpei · 2023-01-12T00:36:00Z

@r4f4 got it, thanks for the additional info.

/label cherry-pick-approved

openshift-ci-robot · 2023-01-12T00:44:14Z

/retest-required

Remaining retests: 0 against base HEAD a69bb77 and 2 for PR HEAD b018f73 in total

openshift-ci-robot · 2023-01-12T07:28:46Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

openshift/installer#6753

Jira Issue OCPBUGS-5764 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #6737

/assign patrickdillon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot assigned patrickdillon Jan 9, 2023

openshift-cherrypick-robot mentioned this pull request Jan 9, 2023

CORS-2472: Expose Azure useImageGallery parameter in the MachineSets() call #6737

Merged

openshift-ci bot requested review from mtulio and rna-afk January 9, 2023 18:56

openshift-ci bot assigned r4f4 Jan 10, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2023

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 10, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2023

openshift-ci bot changed the title ~~[release-4.12] Expose Azure useImageGallery parameter in the MachineSets() call~~ [release-4.12] OCPBUGS-5764: Expose Azure useImageGallery parameter in the MachineSets() call Jan 11, 2023

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 11, 2023

openshift-ci bot requested a review from gpei January 11, 2023 22:35

r4f4 removed their assignment Jan 11, 2023

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 12, 2023

openshift-merge-robot merged commit af02587 into openshift:release-4.12 Jan 12, 2023

[release-4.12] OCPBUGS-5764: Expose Azure useImageGallery parameter in the MachineSets() call #6753

[release-4.12] OCPBUGS-5764: Expose Azure useImageGallery parameter in the MachineSets() call #6753

Uh oh!

Conversation

openshift-cherrypick-robot commented Jan 9, 2023

Uh oh!

openshift-ci bot commented Jan 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

r4f4 commented Jan 10, 2023

Uh oh!

patrickdillon commented Jan 10, 2023

Uh oh!

openshift-ci bot commented Jan 10, 2023

Uh oh!

newtonheath commented Jan 10, 2023

Uh oh!

r4f4 commented Jan 10, 2023

Uh oh!

dlom commented Jan 11, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dlom commented Jan 11, 2023

Uh oh!

openshift-ci bot commented Jan 11, 2023

Uh oh!

r4f4 commented Jan 11, 2023

Uh oh!

r4f4 commented Jan 11, 2023

Uh oh!

openshift-ci bot commented Jan 11, 2023

Uh oh!

openshift-ci-robot commented Jan 11, 2023

Uh oh!

openshift-ci-robot commented Jan 11, 2023

Uh oh!

r4f4 commented Jan 11, 2023

Uh oh!

openshift-ci-robot commented Jan 11, 2023

Uh oh!

r4f4 commented Jan 11, 2023

Uh oh!

gpei commented Jan 12, 2023

Uh oh!

openshift-ci-robot commented Jan 12, 2023

Uh oh!

openshift-ci-robot commented Jan 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

openshift-ci bot commented Jan 10, 2023 •

edited

Loading

dlom commented Jan 11, 2023 •

edited by openshift-ci bot

Loading