Skip to content

Conversation

@rvanderp3
Copy link
Contributor

With the addition of failure_domains, some variables are deprecated and still may be used. Since these variables may validly be left empty when failure_domains is used, defaults are now being provided for those variables.

cc: @jcpowermac

@openshift-ci openshift-ci bot requested review from bostrt and jcpowermac January 9, 2023 16:40
@rvanderp3 rvanderp3 changed the title set default for variables that are deprecated by failure_domains SPLAT-901: set default for variables that are deprecated by failure_domains Jan 9, 2023
@jcpowermac
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD ed8b918 and 2 for PR HEAD 4215613 in total

@rvanderp3
Copy link
Contributor Author

/retest-required

@rvanderp3
Copy link
Contributor Author

/test e2e-vsphere-ovn
/test e2e-openstack-ovn

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 01ebce5 and 1 for PR HEAD 4215613 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 11, 2023

@rvanderp3: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-upgrade 4215613 link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-disruptive 4215613 link false /test e2e-aws-ovn-disruptive

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 14878f7 and 0 for PR HEAD 4215613 in total

@openshift-merge-robot openshift-merge-robot merged commit face870 into openshift:master Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants