AGENT-501: Make it easier to change node zero IP and SERVICE_BASE_URL #6747
Conversation
The node zero IP and ServiceBaseURL are hard-coded into scripts and systemd service definition files. This makes it difficult to change the node zero IP once the agent ISO has booted up. To faciliate changing these settings in the interactive network configuration use case, the hard-codings have been replaced with sourcing files containing environment variables. In the interactive network configuration scenario, the environment files will be updated by the network configuration utility. The agent services are blocked by the interactive console service. When the interactive console service finishes, the agent services start up and read in the environment files picking up any changes. In the non-interactive scenario, the environment files will be prepopulated with values for node zero IP and SERVICE_BASE_URL in the Agent ISO. This is how it works today. Signed-off-by: Richard Su <[email protected]>
The agent-installer manifests and host configuration files are already in /etc/assisted/. Having a node0 file under /etc/assisted-service/ feels out of place because it is the only file in that sub-directory. Added documentation explaining how /etc/assisted/node0 is used.
| # definitions: | ||
| # apply-host-config.service | ||
| # assisted-service-pod.service | ||
| # assisted-service.service |
There was a problem hiding this comment.
Nit - It doesn't look like there is a ConditionPathExists in assisted-service.service. Will need to either add it or change this comment.
There was a problem hiding this comment.
Other than that, looks good. I have not tested it yet but I will.
|
/retest-required |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bfournie The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@rwsu: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
5 participants
The node zero IP and ServiceBaseURL are hard-coded into scripts and
systemd service definition files. This makes it difficult to change
the node zero IP once the agent ISO has booted up. To facilitate
changing these settings in the interactive network configuration
use case, the hard-codings have been replaced with sourcing files
containing environment variables.
In the interactive network configuration scenario, the environment
files will be updated by the network configuration utility. The
agent services are blocked by the interactive console service. When
the interactive console service finishes, the agent services startup
and read in the environment files picking up any changes.
In the non-interactive scenario, the environment files will be
pre-populated with values for node zero IP and SERVICE_BASE_URL in
the Agent ISO. This is how it works today.