Skip to content

Conversation

@squeed
Copy link
Contributor

@squeed squeed commented Nov 14, 2018

Perhaps an unnecessary amount of debugging information. But networking is often the canary in the coal mine, issue-wise.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 14, 2018
@squeed squeed force-pushed the network-troubleshooting branch from 2b02314 to a933acd Compare November 14, 2018 16:58
@squeed squeed force-pushed the network-troubleshooting branch from a933acd to 65f4a57 Compare November 15, 2018 12:29
@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 15, 2018
@squeed squeed force-pushed the network-troubleshooting branch 2 times, most recently from 0ce0f8b to c221137 Compare November 15, 2018 12:36
@openshift-bot openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 15, 2018
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've dropped some minor copy-edits inline.

Stepping back, should this live in the network operator repo where we can link to it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: This block has a command with no output. Personally I like:

```console

with a prompt tfor those, but this project hsd an existing patter of:

```sh

with no prompt. More in #27.

@abhinavdahiya
Copy link
Contributor

Stepping back, should this live in the network operator repo where we can link to it?

I think we are going to answering questions on network readiness quite often and this might help us answer some easy questions for users. and then redirect them to SDN team.

@wking
Copy link
Member

wking commented Nov 15, 2018

Stepping back, should this live in the network operator repo where we can link to it?

I think we are going to answering questions on network readiness quite often and this might help us answer some easy questions for users. and then redirect them to SDN team.

But folks might use the network operators outside of OpenShift? Or, maybe more likely, have issues with networking in running OpenShift clusters and then not think to check the installer docs? Basically, if docs are specific to a single operator (like these? I dunno), then I think they should live with that operator, and we can link them from here. Having a link shouldn't make life too much harder for folks who do think of checking the installer docs first, should it?

@squeed squeed force-pushed the network-troubleshooting branch from c221137 to d0b5169 Compare November 15, 2018 18:05
@squeed
Copy link
Contributor Author

squeed commented Nov 15, 2018

Updated and repushed.

If the network fails, the installer generally fails (since we never leave the boostrap control plane). So I think its pretty reasonable to have some network troubleshooting tasks. In the future, we'll have to have separate diagnostic tasks for each network type (and that should live in Proper Documentation), but this is more to help people before we ship 4.1.

@wking
Copy link
Member

wking commented Nov 15, 2018

Updated and repushed.

You still need to change console -> sh and drop the $ from fenced blocks that contain just a shell command with no output.

If the network fails, the installer generally fails (since we never leave the boostrap control plane). So I think its pretty reasonable to have some network troubleshooting tasks.

I agree that we should have network troubleshooting docs. I'm just not sold (yet ;) on the installer being the right place for them. Does networking never get through installation but then fail later on? Is everyone with networking trouble at any point going to come looking in in the installer docs? And do installer maintainers understand this well enough to maintain these docs (I don't ;)? Perhaps as a middle ground we could put these in docs/user/troubleshoot-network.md with cross-links between that and the generic troubleshooting.md? Then they'd be easy to reposition if we decide to move them out of the installer later? Or maybe the other maintainers feel like this is a good fit for our troubleshooting.md, in which case I'm fine with it ;).

@squeed squeed force-pushed the network-troubleshooting branch from d0b5169 to 6d60f2e Compare November 19, 2018 10:47
@squeed
Copy link
Contributor Author

squeed commented Nov 19, 2018

Fixed the markdown fences.

I'm not gonna lie, I don't care where this goes. Someone asked me to write a troubleshooting doc, so I wrote it. Take it or leave it.

@squeed squeed force-pushed the network-troubleshooting branch from 6d60f2e to f8441fc Compare November 19, 2018 11:04
@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, squeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2018
@openshift-merge-robot openshift-merge-robot merged commit 2a5e0de into openshift:master Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants