OCPBUGS-4654: azure: upi: use Image Gallery in ARM templates #6684

r4f4 · 2022-12-08T21:47:11Z

When we moved to using Image Galleries in Azure/IPI, we also changed the
location that MAO uses for the rhcos bootimages. These changes update
our ARM templates so that the bootimages are picked from the right
location. It fixes the following error when scaling compute nodes:

Error Message: failed to reconcile machine "maxu-upi2-gc7n8-worker-eastus3-68gdx": failed to create vm maxu-upi2-gc7n8-worker-eastus3-68gdx: failure sending request for machine maxu-upi2-gc7n8-worker-eastus3-68gdx: cannot create vm: compute.VirtualMachinesClient#CreateOrUpdate: Failure sending request: StatusCode=404 -- Original Error: Code="GalleryImageNotFound" Message=""The gallery image /subscriptions/$sub_id/resourceGroups/$resource_group/providers/Microsoft.Compute/galleries/$gallery_name/images/maxu-upi2-gc7n8-gen2/versions/412.86.20220930 is not available in eastus region. Please contact image owner to replicate to this region, or change your requested region."" Target="imageReference"

It is also one step closer to getting Azure UPI for aarch64.

openshift-ci-robot · 2022-12-08T21:47:17Z

@r4f4: This pull request references Jira Issue OCPBUGS-4654, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.13.0) matches configured target version for branch (4.13.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

When we moved to using Image Galleries in Azure/IPI, we also changed the
location that MAO uses for the rhcos bootimages. These changes update
our ARM templates so that the bootimages are picked from the right
location. It fixes the following error when scaling compute nodes:
Error Message: failed to reconcile machine "maxu-upi2-gc7n8-worker-eastus3-68gdx": failed to create vm maxu-upi2-gc7n8-worker-eastus3-68gdx: failure sending request for machine maxu-upi2-gc7n8-worker-eastus3-68gdx: cannot create vm: compute.VirtualMachinesClient#CreateOrUpdate: Failure sending request: StatusCode=404 -- Original Error: Code="GalleryImageNotFound" Message=""The gallery image /subscriptions/$sub_id/resourceGroups/$resource_group/providers/Microsoft.Compute/galleries/$gallery_name/images/maxu-upi2-gc7n8-gen2/versions/412.86.20220930 is not available in eastus region. Please contact image owner to replicate to this region, or change your requested region."" Target="imageReference"
It is also one step closer to getting Azure UPI for aarch64.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

r4f4 · 2022-12-08T21:47:26Z

/cc @Prashanth684

docs/user/azure/install_upi.md

r4f4 · 2022-12-08T22:11:19Z

CI Azure UPI jobs are expected to fail until openshift/release#34678 is merged.

upi/azure/02_storage.json

gpei · 2022-12-09T03:16:18Z

/jira refresh

openshift-ci-robot · 2022-12-09T03:16:20Z

@gpei: This pull request references Jira Issue OCPBUGS-4654, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.13.0) matches configured target version for branch (4.13.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @MayXuQQ

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

r4f4 · 2022-12-12T12:21:17Z

/hold
We need openshift/release#34678 merged first so this can be tested in CI

MayXuQQ · 2022-12-14T08:49:43Z

upi/azure/02_storage.json

just use the market-place image?

Would that work for aarch64/Arm64?

$: az vm image list --all --offer rh-ocp-worker --publisher redhat | jq '.[] | .architecture' | sort | uniq "x64"

marketplace images are not available for arm64, only for x86

docs/user/azure/install_upi.md

upi/azure/02_storage.json

This change adds support to both Managed Images and Image Galleries for the UPI workflow. Image Galleries support was added to the openshift-installer to enable aarch64 IPI deployments and openshift/installer#6684 will soon eanble it for UPI as well.

MayXuQQ · 2022-12-16T09:37:58Z

upi/azure/05_masters.json

how about use the previous image name "[concat(parameters('baseName'), '-image')]" ?

We can but then we also need to update https://github.com/openshift/installer/blob/master/pkg/asset/machines/azure/machines.go#L120. I made it consistent with the terraform changes https://github.com/openshift/installer/blob/master/data/data/azure/vnet/main.tf#L101-L130 but have no strong feelings about it.

r4f4 · 2022-12-16T16:05:23Z

/test golint

This change adds support to both Managed Images and Image Galleries for the UPI workflow. Image Galleries support was added to the openshift-installer to enable aarch64 IPI deployments and openshift/installer#6684 will soon eanble it for UPI as well.

r4f4 · 2022-12-16T17:18:31Z

/test e2e-azure-ovn-upi

r4f4 · 2022-12-19T08:27:49Z

/hold cancel

openshift-ci-robot · 2023-01-13T18:50:41Z

/retest-required

Remaining retests: 0 against base HEAD 26a3caa and 2 for PR HEAD 12292f0 in total

openshift-ci-robot · 2023-01-13T23:50:39Z

/retest-required

Remaining retests: 0 against base HEAD 21d9012 and 1 for PR HEAD 12292f0 in total

openshift-ci-robot · 2023-01-14T04:50:37Z

/retest-required

Remaining retests: 0 against base HEAD c5bb817 and 0 for PR HEAD 12292f0 in total

openshift-ci-robot · 2023-01-14T09:50:37Z

/hold

Revision 12292f0 was retested 3 times: holding

r4f4 · 2023-01-16T13:32:57Z

/hold cancel

r4f4 · 2023-01-16T13:36:11Z

/skip

r4f4 · 2023-01-16T13:38:51Z

/retest-required

openshift-ci-robot · 2023-01-16T16:39:09Z

/retest-required

Remaining retests: 0 against base HEAD c5bb817 and 2 for PR HEAD 12292f0 in total

r4f4 · 2023-01-17T14:34:09Z

UPI job will fail until openshift/release#34984 merges.

openshift-ci-robot · 2023-01-17T19:40:19Z

/retest-required

Remaining retests: 0 against base HEAD ff68351 and 1 for PR HEAD 12292f0 in total

openshift-ci-robot · 2023-01-17T23:31:39Z

/retest-required

Remaining retests: 0 against base HEAD 68089b6 and 0 for PR HEAD 12292f0 in total

openshift-ci-robot · 2023-01-18T04:31:54Z

/hold

Revision 12292f0 was retested 3 times: holding

r4f4 · 2023-01-18T09:15:03Z

The same tests

Failing tests:
[sig-network-edge][Conformance][Area:Networking][Feature:Router] The HAProxy router should pass the gRPC interoperability tests [apigroup:config.openshift.io][apigroup:route.openshift.io][apigroup:operator.openshift.io] [Suite:openshift/conformance/parallel/minimal]
[sig-network-edge][Conformance][Area:Networking][Feature:Router][apigroup:route.openshift.io][apigroup:config.openshift.io] The HAProxy router should pass the http2 tests [apigroup:image.openshift.io][apigroup:operator.openshift.io] [Suite:openshift/conformance/parallel/minimal]

are also perma-failing in the periodic UPI job so not introduced in this PR. So there is no point in keeping retesting.

/override ci/prow/e2e-azure-ovn-upi
/hold cancel

openshift-ci · 2023-01-18T09:15:43Z

@r4f4: Overrode contexts on behalf of r4f4: ci/prow/e2e-azure-ovn-upi

Details

In response to this:

The same tests

Failing tests:
[sig-network-edge][Conformance][Area:Networking][Feature:Router] The HAProxy router should pass the gRPC interoperability tests [apigroup:config.openshift.io][apigroup:route.openshift.io][apigroup:operator.openshift.io] [Suite:openshift/conformance/parallel/minimal]
[sig-network-edge][Conformance][Area:Networking][Feature:Router][apigroup:route.openshift.io][apigroup:config.openshift.io] The HAProxy router should pass the http2 tests [apigroup:image.openshift.io][apigroup:operator.openshift.io] [Suite:openshift/conformance/parallel/minimal]

are also perma-failing in the periodic UPI job so not introduced in this PR. So there is no point in keeping retesting.

/override ci/prow/e2e-azure-ovn-upi
/hold cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-01-18T16:52:29Z

/retest-required

Remaining retests: 0 against base HEAD aa31e26 and 2 for PR HEAD 12292f0 in total

r4f4 · 2023-01-18T19:28:39Z

/override ci/prow/e2e-azure-ovn-upi
same 2 e2e tests failing

openshift-ci · 2023-01-18T19:29:44Z

@r4f4: Overrode contexts on behalf of r4f4: ci/prow/e2e-azure-ovn-upi

Details

In response to this:

/override ci/prow/e2e-azure-ovn-upi
same 2 e2e tests failing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-01-18T19:29:46Z

@r4f4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-upgrade	`12292f0`	link	false	`/test e2e-aws-ovn-upgrade`
ci/prow/e2e-aws-ovn-disruptive	`12292f0`	link	false	`/test e2e-aws-ovn-disruptive`
ci/prow/e2e-azure-ovn-shared-vpc	`12292f0`	link	false	`/test e2e-azure-ovn-shared-vpc`
ci/prow/e2e-azure-ovn-resourcegroup	`12292f0`	link	false	`/test e2e-azure-ovn-resourcegroup`
ci/prow/e2e-metal-assisted	`12292f0`	link	false	`/test e2e-metal-assisted`
ci/prow/e2e-aws-ovn-workers-rhel8	`12292f0`	link	false	`/test e2e-aws-ovn-workers-rhel8`
ci/prow/e2e-azurestack-upi	`12292f0`	link	false	`/test e2e-azurestack-upi`
ci/prow/e2e-azurestack	`12292f0`	link	false	`/test e2e-azurestack`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

r4f4 · 2023-01-18T21:36:36Z

/override ci/prow/e2e-azure-ovn
This change only touches the UPI ARM files for Azure, so IPI is not affected.

openshift-ci · 2023-01-18T21:37:11Z

@r4f4: Overrode contexts on behalf of r4f4: ci/prow/e2e-azure-ovn

Details

In response to this:

/override ci/prow/e2e-azure-ovn
This change only touches the UPI ARM files for Azure, so IPI is not affected.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-01-18T21:47:13Z

@r4f4: All pull requests linked via external trackers have merged:

openshift/installer#6684

Jira Issue OCPBUGS-4654 has been moved to the MODIFIED state.

Details

In response to this:

When we moved to using Image Galleries in Azure/IPI, we also changed the
location that MAO uses for the rhcos bootimages. These changes update
our ARM templates so that the bootimages are picked from the right
location. It fixes the following error when scaling compute nodes:
Error Message: failed to reconcile machine "maxu-upi2-gc7n8-worker-eastus3-68gdx": failed to create vm maxu-upi2-gc7n8-worker-eastus3-68gdx: failure sending request for machine maxu-upi2-gc7n8-worker-eastus3-68gdx: cannot create vm: compute.VirtualMachinesClient#CreateOrUpdate: Failure sending request: StatusCode=404 -- Original Error: Code="GalleryImageNotFound" Message=""The gallery image /subscriptions/$sub_id/resourceGroups/$resource_group/providers/Microsoft.Compute/galleries/$gallery_name/images/maxu-upi2-gc7n8-gen2/versions/412.86.20220930 is not available in eastus region. Please contact image owner to replicate to this region, or change your requested region."" Target="imageReference"
It is also one step closer to getting Azure UPI for aarch64.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jinyunma · 2023-03-31T09:23:30Z

/cherry-pick release-4.12

openshift-cherrypick-robot · 2023-03-31T09:24:23Z

@jinyunma: new pull request created: #7054

Details

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 8, 2022

openshift-ci bot requested review from Prashanth684, gpei, m1kola and mtulio December 8, 2022 21:47

Prashanth684 reviewed Dec 8, 2022

View reviewed changes

docs/user/azure/install_upi.md Outdated Show resolved Hide resolved

r4f4 mentioned this pull request Dec 8, 2022

azure: upi: sync install workflow with installer changes openshift/release#34678

Merged

Prashanth684 reviewed Dec 8, 2022

View reviewed changes

upi/azure/02_storage.json Outdated Show resolved Hide resolved

openshift-ci bot requested a review from MayXuQQ December 9, 2022 03:16

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2022

MayXuQQ reviewed Dec 14, 2022

View reviewed changes

docs/user/azure/install_upi.md Outdated Show resolved Hide resolved

MayXuQQ reviewed Dec 14, 2022

View reviewed changes

upi/azure/02_storage.json Outdated Show resolved Hide resolved

r4f4 force-pushed the azure-upi-img-gallery branch from 3c0dcb6 to 2b2b175 Compare December 14, 2022 17:34

MayXuQQ reviewed Dec 16, 2022

View reviewed changes

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2023

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2023

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2023

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2023

openshift-merge-robot merged commit 9aed759 into openshift:master Jan 18, 2023

aleskandro mentioned this pull request Jan 20, 2023

Enable arm64 Azure UPI tests and initial test config for QE e2e tests openshift/release#35520

Merged

openshift-cherrypick-robot mentioned this pull request Mar 31, 2023

[release-4.12] OCPBUGS-11199: azure: upi: use Image Gallery in ARM templates #7054

Merged

OCPBUGS-4654: azure: upi: use Image Gallery in ARM templates #6684

OCPBUGS-4654: azure: upi: use Image Gallery in ARM templates #6684

Uh oh!

Conversation

r4f4 commented Dec 8, 2022

Uh oh!

openshift-ci-robot commented Dec 8, 2022

Uh oh!

r4f4 commented Dec 8, 2022

Uh oh!

Uh oh!

r4f4 commented Dec 8, 2022

Uh oh!

Uh oh!

gpei commented Dec 9, 2022

Uh oh!

openshift-ci-robot commented Dec 9, 2022

Uh oh!

r4f4 commented Dec 12, 2022

Uh oh!

MayXuQQ Dec 14, 2022

Choose a reason for hiding this comment

Uh oh!

r4f4 Dec 14, 2022

Choose a reason for hiding this comment

Uh oh!

Prashanth684 Dec 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

MayXuQQ Dec 16, 2022

Choose a reason for hiding this comment

Uh oh!

r4f4 Dec 16, 2022

Choose a reason for hiding this comment

Uh oh!

r4f4 commented Dec 16, 2022

Uh oh!

r4f4 commented Dec 16, 2022

Uh oh!

r4f4 commented Dec 19, 2022

Uh oh!

openshift-ci-robot commented Jan 13, 2023

Uh oh!

openshift-ci-robot commented Jan 13, 2023

Uh oh!

openshift-ci-robot commented Jan 14, 2023

Uh oh!

openshift-ci-robot commented Jan 14, 2023

Uh oh!

r4f4 commented Jan 16, 2023

Uh oh!

r4f4 commented Jan 16, 2023

Uh oh!

r4f4 commented Jan 16, 2023

Uh oh!

openshift-ci-robot commented Jan 16, 2023

Uh oh!

r4f4 commented Jan 17, 2023

Uh oh!

openshift-ci-robot commented Jan 17, 2023

Uh oh!

openshift-ci-robot commented Jan 17, 2023

Uh oh!

openshift-ci-robot commented Jan 18, 2023

Uh oh!

r4f4 commented Jan 18, 2023

Uh oh!

openshift-ci bot commented Jan 18, 2023

Uh oh!

openshift-ci-robot commented Jan 18, 2023

Uh oh!

r4f4 commented Jan 18, 2023

Uh oh!

openshift-ci bot commented Jan 18, 2023

Uh oh!

openshift-ci bot commented Jan 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Prashanth684 Dec 14, 2022 •

edited

Loading

openshift-ci bot commented Jan 18, 2023 •

edited

Loading