pkg/asset/installconfig/platform: Drop *PlatformType for types.{platform}.Name

[wking]

The old *PlatformType are from cccbb37 (#120), but since 476be07 (#573), we've had variables for the name strings in the more central pkg/types. With this pull request, we drop the more peripheral forms.

I've added a unit test to enforce sorting in PlatformNames, because the order is required by sort.SearchStrings in queryUserForPlatform.

This will have trivial conflicts with #657, but I'm fine rebasing after one of these lands.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[wking]

e2e-aws:

error: watch closed before Until timeout
error openshift-ingress/ds/router-default did not come up
Waiting for daemon set "router-default" rollout to finish: 2 of 3 updated pods are available...
E1112 23:13:21.117169     713 streamwatcher.go:109] Unable to decode an event from the watch stream: net/http: request canceled (Client.Timeout exceeded while reading body)
error: watch closed before Until timeout
timeout waiting for openshift-ingress/ds/router-default to be available
2018/11/12 23:13:22 Container test in pod e2e-aws failed, exit code 1, reason Error

[abhinavdahiya]

I've added a unit test to enforce sorting in PlatformNames, because the order is required by sort.SearchStrings in queryUserForPlatform.

I would expect the consumers to sort however they want, i don't think it should be part of the var Platforms api.

[wking]

I've added a unit test to enforce sorting in PlatformNames, because the order is required by sort.SearchStrings in queryUserForPlatform.

I would expect the consumers to sort however they want, i don't think it should be part of the var Platforms api.

That's effectively "if you care about order, make a copy and sort it yourself", right? Why is that better than having an opinion here (e.g. alphabetical) and only require consumers to copy/sort when they need something else?

[abhinavdahiya]

I've added a unit test to enforce sorting in PlatformNames, because the order is required by sort.SearchStrings in queryUserForPlatform.

I would expect the consumers to sort however they want, i don't think it should be part of the var Platforms api.

That's effectively "if you care about order, make a copy and sort it yourself", right? Why is that better than having an opinion here (e.g. alphabetical) and only require consumers to copy/sort when they need something else?

It's just odd that order is part of the Platforms api, and we are enforcing it with a test. But if you think that's appropriate, sure lets keep it.

[wking]

Rebased around #657 and pushed the names down into the per-platform packages with 9bf2fe6 -> 1e129fe.

[abhinavdahiya]

/lgtm