OCPBUGS-2436: Fix ingress config with empty lbType on AWS by Miciah · Pull Request #6489 · openshift/installer

Miciah · 2022-10-16T18:38:59Z

When generating the ingresses.config.openshift.io/cluster manifest on AWS, don't set spec.loadBalancer unless the install-config lbType is nonempty.

Before this PR, if lbType was empty, the installer generated a manifest with the following:

  loadBalancer:
    platform:
      aws: {}
      type: AWS

Whereas loadBalancer, platform, and aws are optional fields, the type subfield of the aws field is required. As a consequence, the cluster bootstrap would fail with the following error:

    "cluster-ingress-02-config.yml": failed to create ingresses.v1.config.openshift.io/cluster -n : Ingress.config.openshift.io "cluster" is invalid: spec.loadBalancer.platform.aws.type: Required value

This PR ensures that the installer doesn't generate an invalid ingress manifest when lbType is empty.

Follow-up to #6478.

pkg/asset/manifests/ingress.go (generateClusterConfig): Don't set spec.loadBalancer unless we have a nonempty lbType value to put in spec.loadBalancer.platform.aws.type.

When generating the ingresses.config.openshift.io/cluster manifest on AWS, don't set spec.loadBalancer unless the install-config lbType is nonempty. Before this commit, if lbType was empty, the installer generated a manifest with the following: loadBalancer: platform: aws: {} type: AWS Whereas loadBalancer, platform, and aws are optional fields, the type subfield of the aws field is required. As a consequence, the cluster bootstrap would fail with the following error: "cluster-ingress-02-config.yml": failed to create ingresses.v1.config.openshift.io/cluster -n : Ingress.config.openshift.io "cluster" is invalid: spec.loadBalancer.platform.aws.type: Required value This commit ensures that the installer doesn't generate an invalid ingress manifest when lbType is empty. Follow-up to commit 5d12adc. This commit fixes bug OCPBUGS-2436. https://issues.redhat.com/browse/OCPBUGS-2436 * pkg/asset/manifests/ingress.go (generateClusterConfig): Don't set spec.loadBalancer unless we have a nonempty lbType value to put in spec.loadBalancer.platform.aws.type.

openshift-ci-robot · 2022-10-16T18:39:03Z

@Miciah: This pull request references Jira Issue OCPBUGS-2436, which is invalid:

expected the bug to target the "4.12.0" version, but it targets "4.12.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

When generating the ingresses.config.openshift.io/cluster manifest on AWS, don't set spec.loadBalancer unless the install-config lbType is nonempty.

Before this PR, if lbType was empty, the installer generated a manifest
with the following:
 loadBalancer:
   platform:
     aws: {}
     type: AWS
Whereas loadBalancer, platform, and aws are optional fields, the type subfield of the aws field is required. As a consequence, the cluster bootstrap would fail with the following error:
   "cluster-ingress-02-config.yml": failed to create ingresses.v1.config.openshift.io/cluster -n : Ingress.config.openshift.io "cluster" is invalid: spec.loadBalancer.platform.aws.type: Required value
This PR ensures that the installer doesn't generate an invalid ingress manifest when lbType is empty.

Follow-up to #6478.

pkg/asset/manifests/ingress.go (generateClusterConfig): Don't set spec.loadBalancer unless we have a nonempty lbType value to put in spec.loadBalancer.platform.aws.type.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2022-10-16T18:40:34Z

@Miciah: This pull request references Jira Issue OCPBUGS-2436, which is invalid:

expected the bug to target the "4.12.0" version, but it targets "4.12.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

When generating the ingresses.config.openshift.io/cluster manifest on AWS, don't set spec.loadBalancer unless the install-config lbType is nonempty.

Before this PR, if lbType was empty, the installer generated a manifest with the following:
 loadBalancer:
   platform:
     aws: {}
     type: AWS
Whereas loadBalancer, platform, and aws are optional fields, the type subfield of the aws field is required. As a consequence, the cluster bootstrap would fail with the following error:
   "cluster-ingress-02-config.yml": failed to create ingresses.v1.config.openshift.io/cluster -n : Ingress.config.openshift.io "cluster" is invalid: spec.loadBalancer.platform.aws.type: Required value
This PR ensures that the installer doesn't generate an invalid ingress manifest when lbType is empty.

Follow-up to #6478.

pkg/asset/manifests/ingress.go (generateClusterConfig): Don't set spec.loadBalancer unless we have a nonempty lbType value to put in spec.loadBalancer.platform.aws.type.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Miciah · 2022-10-16T18:40:51Z

/jira refresh

openshift-ci-robot · 2022-10-16T18:40:56Z

@Miciah: This pull request references Jira Issue OCPBUGS-2436, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.12.0) matches configured target version for branch (4.12.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (gpei@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

miheer · 2022-10-16T19:17:45Z

/lgtm

miheer · 2022-10-16T19:17:59Z

thanks @Miciah !

patrickdillon · 2022-10-16T20:27:24Z

/approve

openshift-ci · 2022-10-16T20:28:16Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

r4f4 · 2022-10-16T21:06:18Z

/test e2e-aws-ovn

openshift-ci-robot · 2022-10-16T22:16:06Z

/retest-required

Remaining retests: 0 against base HEAD 85c8d56 and 2 for PR HEAD b31c4ea in total

frobware · 2022-10-17T08:52:55Z

/skip
/retest

miheer · 2022-10-17T10:37:08Z

/retest-required

JoelSpeed · 2022-10-17T12:53:02Z

/retest-required

stbenjam · 2022-10-17T13:31:27Z

/hold

After the revert lands, can you build this fix on top of unreverting, and then make sure it passes the jobs that are currently broken on the payload? It looks like aws-sdn-serial is the clearest one. You can use /payload-job periodic-ci-openshift-release-master-nightly-4.12-e2e-aws-sdn-serial. 🙇🏻‍♂️

openshift-merge-robot · 2022-10-17T16:48:29Z

@Miciah: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-10-17T16:48:45Z

@Miciah: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-openstack	`b31c4ea`	link	false	`/test e2e-openstack`
ci/prow/okd-scos-e2e-aws-upgrade	`b31c4ea`	link	false	`/test okd-scos-e2e-aws-upgrade`
ci/prow/e2e-libvirt	`b31c4ea`	link	false	`/test e2e-libvirt`
ci/prow/e2e-metal-ipi	`b31c4ea`	link	false	`/test e2e-metal-ipi`
ci/prow/okd-e2e-aws-upgrade	`b31c4ea`	link	false	`/test okd-e2e-aws-upgrade`
ci/prow/okd-e2e-aws-ovn	`b31c4ea`	link	false	`/test okd-e2e-aws-ovn`
ci/prow/okd-scos-e2e-aws-ovn	`b31c4ea`	link	false	`/test okd-scos-e2e-aws-ovn`
ci/prow/e2e-aws-ovn	`b31c4ea`	link	true	`/test e2e-aws-ovn`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Miciah · 2022-10-17T16:55:43Z

/close
because #6490 has merged and reverts the problematic code. #6491 reverts #6490 and incorporates the bugfix in this PR.

openshift-ci-robot · 2022-10-17T17:00:43Z

@Miciah: This pull request references Jira Issue OCPBUGS-2436. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

When generating the ingresses.config.openshift.io/cluster manifest on AWS, don't set spec.loadBalancer unless the install-config lbType is nonempty.

Before this PR, if lbType was empty, the installer generated a manifest with the following:
 loadBalancer:
   platform:
     aws: {}
     type: AWS
Whereas loadBalancer, platform, and aws are optional fields, the type subfield of the aws field is required. As a consequence, the cluster bootstrap would fail with the following error:
   "cluster-ingress-02-config.yml": failed to create ingresses.v1.config.openshift.io/cluster -n : Ingress.config.openshift.io "cluster" is invalid: spec.loadBalancer.platform.aws.type: Required value
This PR ensures that the installer doesn't generate an invalid ingress manifest when lbType is empty.

Follow-up to #6478.

pkg/asset/manifests/ingress.go (generateClusterConfig): Don't set spec.loadBalancer unless we have a nonempty lbType value to put in spec.loadBalancer.platform.aws.type.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-10-17T17:00:49Z

@Miciah: Closed this PR.

Details

In response to this:

/close
because #6490 has merged and reverts the problematic code. #6491 reverts #6490 and incorporates the bugfix in this PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 16, 2022

openshift-ci bot requested review from barbacbd and sadasu October 16, 2022 18:39

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Oct 16, 2022

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 16, 2022

openshift-ci bot assigned miheer Oct 16, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2022

Miciah mentioned this pull request Oct 17, 2022

CCO-249: Replace GCP role with explicit permissions openshift/cluster-ingress-operator#844

Merged

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2022

Miciah mentioned this pull request Oct 17, 2022

OCPBUGS-2436: Revert "Revert "[AWS] Add LB Type in the infrastructure cluster object via install-config yaml"" and fix OCPBUGS-2436 #6491

Merged

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 17, 2022

openshift-ci bot closed this Oct 17, 2022

Conversation

Miciah commented Oct 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Oct 16, 2022

Uh oh!

openshift-ci-robot commented Oct 16, 2022

Uh oh!

Miciah commented Oct 16, 2022

Uh oh!

openshift-ci-robot commented Oct 16, 2022

Uh oh!

miheer commented Oct 16, 2022

Uh oh!

miheer commented Oct 16, 2022

Uh oh!

patrickdillon commented Oct 16, 2022

Uh oh!

openshift-ci bot commented Oct 16, 2022

Uh oh!

r4f4 commented Oct 16, 2022

Uh oh!

openshift-ci-robot commented Oct 16, 2022

Uh oh!

frobware commented Oct 17, 2022

Uh oh!

miheer commented Oct 17, 2022

Uh oh!

JoelSpeed commented Oct 17, 2022

Uh oh!

stbenjam commented Oct 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-merge-robot commented Oct 17, 2022

Uh oh!

openshift-ci bot commented Oct 17, 2022

Uh oh!

Miciah commented Oct 17, 2022

Uh oh!

openshift-ci-robot commented Oct 17, 2022

Uh oh!

openshift-ci bot commented Oct 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Comments

Miciah commented Oct 16, 2022 •

edited

Loading

stbenjam commented Oct 17, 2022 •

edited

Loading