Skip to content

Updating golang version to fix gofmt issues#6484

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
sadasu:fix-gofmt-issues
Oct 18, 2022
Merged

Updating golang version to fix gofmt issues#6484
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
sadasu:fix-gofmt-issues

Conversation

@sadasu
Copy link
Contributor

@sadasu sadasu commented Oct 13, 2022 •
edited
Loading

gofmt issues are preventing #6447, #6448 and #6449 from merging.

Fixing gofmt issues arising from upgrading to golang 1.19

@sadasu
Copy link
Contributor Author

sadasu commented Oct 13, 2022

/cc @r4f4

@openshift-ci openshift-ci bot requested a review from r4f4 October 13, 2022 18:22
r4f4
r4f4 reviewed Oct 13, 2022
View reviewed changes
Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
It looks like all the formatting changes are happening in comments.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2022
@sadasu
Copy link
Contributor Author

sadasu commented Oct 14, 2022

/retest-required

1 similar comment
@sadasu
Copy link
Contributor Author

sadasu commented Oct 14, 2022

/retest-required

@jhixson74
Copy link
Member

jhixson74 commented Oct 14, 2022

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhixson74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2022
@sadasu
Copy link
Contributor Author

sadasu commented Oct 14, 2022

/retest-required

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 15, 2022

/retest-required

Remaining retests: 0 against base HEAD c5d7528 and 2 for PR HEAD 7202c95 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 15, 2022

/retest-required

Remaining retests: 0 against base HEAD 85c8d56 and 1 for PR HEAD 7202c95 in total

@sadasu
Copy link
Contributor Author

sadasu commented Oct 17, 2022

/skip
gofmt only made changes to comments

@sadasu
Copy link
Contributor Author

sadasu commented Oct 17, 2022

/override ci/prow/e2e-aws-ovn
Known issue fixed by #6491

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2022

@sadasu: Overrode contexts on behalf of sadasu: ci/prow/e2e-aws-ovn

Details

In response to this:

/override ci/prow/e2e-aws-ovn
Known issue fixed by #6491

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 17, 2022

/retest-required

Remaining retests: 0 against base HEAD 045b952 and 0 for PR HEAD 7202c95 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 17, 2022

/hold

Revision 7202c95 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2022
@sadasu
Copy link
Contributor Author

sadasu commented Oct 17, 2022

/hold cancel

@sadasu
Copy link
Contributor Author

sadasu commented Oct 17, 2022

/retest-required

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 17, 2022

/retest-required

Remaining retests: 0 against base HEAD 045b952 and 2 for PR HEAD 7202c95 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2022 •
edited
Loading

@sadasu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-proxy 7202c95 link false /test e2e-openstack-proxy
ci/prow/okd-e2e-aws-upgrade 7202c95 link false /test okd-e2e-aws-upgrade
ci/prow/e2e-metal-ipi 7202c95 link false /test e2e-metal-ipi
ci/prow/e2e-azurestack 7202c95 link false /test e2e-azurestack
ci/prow/e2e-aws-ovn-single-node 7202c95 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-gcp-ovn-shared-vpc 7202c95 link false /test e2e-gcp-ovn-shared-vpc
ci/prow/e2e-nutanix 7202c95 link false /test e2e-nutanix
ci/prow/e2e-openstack-kuryr 7202c95 link false /test e2e-openstack-kuryr
ci/prow/e2e-azure-ovn-resourcegroup 7202c95 link false /test e2e-azure-ovn-resourcegroup
ci/prow/e2e-azure-ovn-shared-vpc 7202c95 link false /test e2e-azure-ovn-shared-vpc
ci/prow/e2e-agent-mce 7202c95 link false /test e2e-agent-mce
ci/prow/okd-scos-e2e-aws-ovn 7202c95 link false /test okd-scos-e2e-aws-ovn
ci/prow/okd-e2e-aws-ovn 7202c95 link false /test okd-e2e-aws-ovn
ci/prow/okd-scos-e2e-aws-upgrade 7202c95 link false /test okd-scos-e2e-aws-upgrade
ci/prow/e2e-aws-ovn-shared-vpc 7202c95 link false /test e2e-aws-ovn-shared-vpc
ci/prow/e2e-ibmcloud-ovn 7202c95 link false /test e2e-ibmcloud-ovn
ci/prow/e2e-aws-ovn-proxy 7202c95 link false /test e2e-aws-ovn-proxy
ci/prow/e2e-libvirt 7202c95 link false /test e2e-libvirt

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 18, 2022

/retest-required

Remaining retests: 0 against base HEAD 927dd43 and 1 for PR HEAD 7202c95 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 18, 2022

/retest-required

Remaining retests: 0 against base HEAD 53766db and 0 for PR HEAD 7202c95 in total

@openshift-merge-robot openshift-merge-robot merged commit d853fa5 into openshift:master Oct 18, 2022
@r4f4 r4f4 mentioned this pull request Oct 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iurygregory iurygregory Awaiting requested review from iurygregory

@jhixson74 jhixson74 Awaiting requested review from jhixson74

1 more reviewer

@r4f4 r4f4 r4f4 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@r4f4 r4f4

@jhixson74 jhixson74

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sadasu @jhixson74 @openshift-ci-robot @r4f4 @openshift-merge-robot