Skip to content

AGENT-347: generate OS_IMAGES dynamically #6441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Oct 11, 2022
Merged

AGENT-347: generate OS_IMAGES dynamically #6441

openshift-merge-robot merged 1 commit into from
Oct 11, 2022

Conversation

@andfasano
Copy link
Contributor

@andfasano andfasano commented Sep 30, 2022

This patch uses the current rhcos.json information stored in the installer to craft properly the OS_IMAGES env var (arch is currently hard-coded to x86_64)

@zaneb zaneb mentioned this pull request Sep 30, 2022
Merged
zaneb
zaneb reviewed Sep 30, 2022
View reviewed changes
Copy link
Member

@zaneb zaneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2022
lranjbar
lranjbar reviewed Sep 30, 2022
View reviewed changes
Copy link
Contributor

@lranjbar lranjbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non blocking question/comment: This PR seems to assume that there will only be one version and CPU architecture. Do we think that OCP will have multi arch images in the future? LGTM mostly just thinking ahead to multi arch support.

pawanpinjarkar
pawanpinjarkar reviewed Sep 30, 2022
View reviewed changes
pawanpinjarkar
pawanpinjarkar reviewed Sep 30, 2022
View reviewed changes
pawanpinjarkar
pawanpinjarkar reviewed Sep 30, 2022
View reviewed changes
pawanpinjarkar
pawanpinjarkar reviewed Sep 30, 2022
View reviewed changes
pawanpinjarkar
pawanpinjarkar suggested changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@pawanpinjarkar pawanpinjarkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes TBD

zaneb
zaneb reviewed Oct 6, 2022
View reviewed changes
@andfasano
agent: generate OS_IMAGES dynamically
da5bce7 
This patch uses the current rhcos.json information stored in the installer to craft properly the OS_IMAGES env var (arch is currently hard-coded to x86_64)
@andfasano
Copy link
Contributor Author

andfasano commented Oct 7, 2022

/test e2e-agent-mce

@zaneb
Copy link
Member

zaneb commented Oct 7, 2022

/retest-required

@celebdor
Copy link
Contributor

celebdor commented Oct 7, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 7, 2022

/retest-required

Remaining retests: 0 against base HEAD 7b739cd and 2 for PR HEAD da5bce7 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 7, 2022

/retest-required

Remaining retests: 0 against base HEAD 46f1005 and 1 for PR HEAD da5bce7 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 8, 2022

/retest-required

Remaining retests: 0 against base HEAD d0afaa3 and 0 for PR HEAD da5bce7 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 8, 2022

/hold

Revision da5bce7 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 8, 2022
@andfasano
Copy link
Contributor Author

andfasano commented Oct 10, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2022
@andfasano
Copy link
Contributor Author

andfasano commented Oct 10, 2022

/test okd-images

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 10, 2022

/retest-required

Remaining retests: 0 against base HEAD 02102a9 and 2 for PR HEAD da5bce7 in total

@andfasano
Copy link
Contributor Author

andfasano commented Oct 10, 2022

/test okd-scos-images

(this job is not related at all with this patch)

@zaneb
Copy link
Member

zaneb commented Oct 10, 2022

/test okd-scos-images

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 10, 2022

/retest-required

Remaining retests: 0 against base HEAD 46e95b3 and 1 for PR HEAD da5bce7 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2022 •
edited
Loading

@andfasano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-gcp 73a30edf597a3acee0c1af9962fbe2f29d7f6f6a link false /test okd-scos-e2e-gcp
ci/prow/okd-scos-e2e-vsphere 73a30edf597a3acee0c1af9962fbe2f29d7f6f6a link false /test okd-scos-e2e-vsphere
ci/prow/okd-scos-e2e-gcp-ovn-upgrade 73a30edf597a3acee0c1af9962fbe2f29d7f6f6a link false /test okd-scos-e2e-gcp-ovn-upgrade
ci/prow/e2e-agent-mce da5bce7 link false /test e2e-agent-mce

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 11, 2022

/retest-required

Remaining retests: 0 against base HEAD fef1d0f and 0 for PR HEAD da5bce7 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 11, 2022

/hold

Revision da5bce7 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2022
@andfasano
Copy link
Contributor Author

andfasano commented Oct 11, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 11, 2022

/retest-required

Remaining retests: 0 against base HEAD edd32e0 and 2 for PR HEAD da5bce7 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 11, 2022

/retest-required

Remaining retests: 0 against base HEAD 54d95a3 and 1 for PR HEAD da5bce7 in total

@openshift-merge-robot openshift-merge-robot merged commit a62fb1a into openshift:master Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zaneb zaneb zaneb left review comments

+3 more reviewers

@celebdor celebdor celebdor left review comments

@lranjbar lranjbar lranjbar left review comments

@pawanpinjarkar pawanpinjarkar pawanpinjarkar requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@celebdor celebdor

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@andfasano @zaneb @celebdor @openshift-ci-robot @lranjbar @pawanpinjarkar @openshift-merge-robot